From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Wed, 14 Apr 2021 22:52:28 +0300 Organization: LINKOV.NET Message-ID: <87im4or6df.fsf@mail.linkov.net> References: <87pmz8lc17.fsf@mail.linkov.net> <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> <87o8eo38q9.fsf@mail.linkov.net> <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> <87eefh9176.fsf@mail.linkov.net> <5c7b677f-0f4a-bbef-8c1f-42cd024c7314@yandex.ru> <87czuzxysf.fsf@mail.linkov.net> <874kg9mj7f.fsf@gmail.com> <87h7k8n3uy.fsf@mail.linkov.net> <87tuo8of2g.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , Ramesh Nedunchezian , 47566@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 14 21:57:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWldP-0002Xu-TE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 21:57:11 +0200 Original-Received: from localhost ([::1]:57478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWldO-0000pI-Ux for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 15:57:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWldG-0000no-Qu for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 15:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWldG-0000lm-JF for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 15:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWldG-0003KZ-Gi for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 15:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Apr 2021 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-submit@debbugs.gnu.org id=B47566.161843021412789 (code B ref 47566); Wed, 14 Apr 2021 19:57:02 +0000 Original-Received: (at 47566) by debbugs.gnu.org; 14 Apr 2021 19:56:54 +0000 Original-Received: from localhost ([127.0.0.1]:35797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWld8-0003KD-LE for submit@debbugs.gnu.org; Wed, 14 Apr 2021 15:56:54 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWld5-0003Jx-26 for 47566@debbugs.gnu.org; Wed, 14 Apr 2021 15:56:53 -0400 X-Originating-IP: 91.129.96.157 Original-Received: from mail.gandi.net (m91-129-96-157.cust.tele2.ee [91.129.96.157]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4FBFFFF803; Wed, 14 Apr 2021 19:56:41 +0000 (UTC) In-Reply-To: <87tuo8of2g.fsf_-_@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Wed, 14 Apr 2021 21:12:55 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204030 Archived-At: > Thanks! Was this bit intentional? > >> ;;;###autoload >> (put 'mode-line-defining-kbd-macro 'risky-local-variable t) Thanks for noticing this, I stole this from bindings.el, but now that repeat-echo-mode-line-string is highlighted correctly in the mode-line, I wonder if such property is needed for repeat-echo-mode-line-string at all? And why it was needed for mode-line-defining-kbd-macro to keep its text properties? After removing this line from bindings.el: (put 'mode-line-defining-kbd-macro 'risky-local-variable t) mode-line-defining-kbd-macro loses its text property face=font-lock-warning-face, but repeat-echo-mode-line-string keeps it. This is explained in (info "(elisp) Properties in Mode"), but I don't understand why text properties are preserved for repeat-echo-mode-line-string without ‘risky-local-variable’ property? > Also, AFAICT the indication (whether in the mode-line or in the echo > area) only shows up once I start repeating a key (e.g. after C-x o o), > not when I first hit a repeatable key (e.g. after C-x o). Strange, I see it immediately after C-x o.