From: Michael Albinus <michael.albinus@gmx.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Vladimir Nikishkin <lockywolf@gmail.com>, 47493@debbugs.gnu.org
Subject: bug#47493: 27.1; auto-save-file-name-transforms with uniquify should not create invalid filenames
Date: Sat, 08 May 2021 14:42:17 +0200 [thread overview]
Message-ID: <87im3tiehi.fsf@gmx.de> (raw)
In-Reply-To: <875yztqu9l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 08 May 2021 14:34:14 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
Hi Lars,
> Michael Albinus <michael.albinus@gmx.de> writes:
>
>>> Maybe we could have a flag which means "convert the directory part of a
>>> file name into sha1" (or whatever `secure-hash' provides).
>>
>> Nobody has commented. Well, in a couple of days I will push the appended
>> patch, unless there are objections.
>
> As far as I can tell, the patch wasn't pushed?
No. It is in my todo queue, but I wanted to check first, whether Tramp
needs some changes in its own implementation of make-auto-save-file-name
>> + If the optional element UNIQUIFY is a symbol returned by function
>> + `secure-hash-algorithms', the auto-save file name is constructed
>> + by taking the directory part of the replaced file-name,
>> + concatenated with the buffer file name run through `secure-hash'
>> + instead. This returns a valid name for your filesystem any way.
>
> Vladimir didn't have any examples for invalid file names, apparently,
> but it looks like a good change to me. (I.e., being able to opt in to
> using a hash instead of !!-ing.)
The patch is planned to be pushed, once I find the time to fix that
remaining question. Or does somebody else want to eat this cookie?
Best regards, Michael.
next prev parent reply other threads:[~2021-05-08 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 5:06 bug#47493: 27.1; auto-save-file-name-transforms with uniquify should not create invalid filenames Vladimir Nikishkin
2021-03-30 7:55 ` Michael Albinus
2021-04-06 18:40 ` Michael Albinus
2021-04-06 20:57 ` Glenn Morris
2021-04-07 8:24 ` Michael Albinus
2021-05-08 12:34 ` Lars Ingebrigtsen
2021-05-08 12:42 ` Michael Albinus [this message]
2021-05-09 9:58 ` Lars Ingebrigtsen
2021-05-10 11:46 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im3tiehi.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=47493@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=lockywolf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).