From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder Date: Thu, 08 Jul 2021 20:40:39 +0300 Organization: LINKOV.NET Message-ID: <87im1kya94.fsf@mail.linkov.net> References: <87r1h1jnf2.fsf@riseup.net> <87a6npf7pr.fsf@riseup.net> <871r90fsoq.fsf@riseup.net> <87o8boy8cd.fsf@riseup.net> <87pmw4tn2t.fsf@mail.linkov.net> <87czs4xqn7.fsf@riseup.net> <87zgv76skf.fsf@mail.linkov.net> <87mtqw6cg8.fsf@riseup.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19028"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 49069@debbugs.gnu.org To: Trust me I am a Doctor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 08 20:39:52 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1YwC-0004pI-EY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 20:39:52 +0200 Original-Received: from localhost ([::1]:60010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1YwB-0000rZ-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 14:39:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Y4C-0005a4-NS for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 13:44:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45865) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1Y4C-0002bX-Dz for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 13:44:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1Y4A-00006y-TI for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 13:44:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jul 2021 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49069 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49069-submit@debbugs.gnu.org id=B49069.1625766219367 (code B ref 49069); Thu, 08 Jul 2021 17:44:02 +0000 Original-Received: (at 49069) by debbugs.gnu.org; 8 Jul 2021 17:43:39 +0000 Original-Received: from localhost ([127.0.0.1]:57407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Y3m-00005p-Ps for submit@debbugs.gnu.org; Thu, 08 Jul 2021 13:43:39 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:45723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Y3j-00005I-0h; Thu, 08 Jul 2021 13:43:37 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 895381BF205; Thu, 8 Jul 2021 17:43:26 +0000 (UTC) In-Reply-To: <87mtqw6cg8.fsf@riseup.net> (Trust me I. am a. Doctor's message of "Thu, 08 Jul 2021 17:18:33 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209705 Archived-At: tags 49069 fixed close 49069 28.0.50 thanks > To be fair, blaming the different repositories gives no evidence that > this macro is a reaction to perspective.el Indeed, we don't know for sure, it was just a hypothesis. But anyway such "catch-all" tricks as ".*" should be avoided. Also I don't know if there is any chance to fix Org-mode. Anyway, I'm using such workaround for Org-mode problem: #+begin_src emacs-lisp ;; Unfortunately, Org window customization has no effect because ;; ‘display-buffer-alist’ is ignored in ‘org-no-popups’ ;; until ‘org-switch-to-buffer-other-window’ is overridden below: (defalias 'org-switch-to-buffer-other-window 'switch-to-buffer-other-window) ;; This allows such user customizations: (push '("\\`\\*Org \\(Links\\|Select\\)\\*\\'" display-buffer-below-selected (window-height . fit-window-to-buffer) (preserve-size . (nil . t))) display-buffer-alist) #+end_src > Ok you convinced me. Thanks for the tip, I installed it on a low-vision > setup of a knowledge of me. We will see more in detail the differences > that it implies. > > So it seems that the patch of the Thu, 17 Jun 2021 16:50:07 +0200 > was indeed the one we want to keep. > > I tested it again, with : > > (customize-set-variable > 'display-buffer-base-action > '((display-buffer-reuse-window display-buffer-same-window))) > > (setf (alist-get "*RE-Builder*" display-buffer-alist nil nil #'string=) > `((display-buffer-in-direction) > (direction . top) > (dedicated . t))) > > (re-builder) > > And it obeys to display-buffer-alist, be it for an other > function or others parameters, and keep being functional ... etc. Thanks for confirming and for implementing the patch. Now your patch was pushed in commit 57354bc64b.