From: Lars Ingebrigtsen <larsi@gnus.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 45562@debbugs.gnu.org, Stefan Kangas <stefan@marxist.se>
Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm
Date: Wed, 21 Jul 2021 13:30:10 +0200 [thread overview]
Message-ID: <87im13lxa5.fsf@gnus.org> (raw)
In-Reply-To: <87o8i87gu3.fsf@igel.home> (Andreas Schwab's message of "Fri, 01 Jan 2021 17:38:28 +0100")
Andreas Schwab <schwab@linux-m68k.org> writes:
>>>> --- a/src/fns.c
>>>> +++ b/src/fns.c
>>>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length,
>>>> if (c == '=')
>>>> continue;
>>>>
>>>> - if (v1 < 0)
>>>> - return -1;
>
> Looking at commit 5abaea334cf, that likely needs to test v1 == 0 instead.
Seems like so to me, too. So I've now made that change on the trunk --
so the lgtm checks found a real bug there.
As for the others, skimming this thread there didn't seem to be any
consensus that the proposed changes makes the code any better (or
clearer), so applying those doesn't seem to be a net win, and I'm
closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-07-21 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 8:33 bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Stefan Kangas
2020-12-31 14:12 ` Eli Zaretskii
2021-01-01 11:08 ` Lars Ingebrigtsen
2021-01-01 11:37 ` Unknown
2021-01-01 16:10 ` Stefan Kangas
2021-01-01 12:05 ` Eli Zaretskii
2021-01-01 16:21 ` Stefan Kangas
2021-01-01 16:38 ` Andreas Schwab
2021-07-21 11:30 ` Lars Ingebrigtsen [this message]
2021-01-01 18:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im13lxa5.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=45562@debbugs.gnu.org \
--cc=schwab@linux-m68k.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).