unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 13339@debbugs.gnu.org
Subject: bug#13339: 24.3.50; doc of `next-frame'
Date: Mon, 23 Aug 2021 16:32:03 +0200	[thread overview]
Message-ID: <87ilzws04c.fsf@gnus.org> (raw)
In-Reply-To: <79C6D147824B47049C223D2476CEE799@us.oracle.com> (Drew Adams's message of "Wed, 2 Jan 2013 10:56:41 -0800")

"Drew Adams" <drew.adams@oracle.com> writes:

> What is unclear is which frames are _included_ in this case.  The only
> thing we are told is that minibuffer-only frames are _excluded_.  Does
> that mean that all other frames are included?  Or only visible frames?
> Or only visible or iconified frames?

Looking at the code, it's absolutely all frames on that terminal.  I've
now adjusted the doc string and the manual.

"Drew Adams" <drew.adams@oracle.com> writes:

> BTW, the doc of `other-frame' says that it includes _visible_ frames.
> And its code calls `next-frame' with a nil value for argument
> MINIFRAME.  So if the doc of `other-frame' is correct then the
> `next-frame' with nil MINIFRAME must include only visible frames, not
> all frames except minibuffer-only frames and not all visible or
> iconified frames except minibuffer-only frames.

I haven't dug into the code history here, but the code today says:

    (while (> arg 0)
      (setq frame (next-frame frame))
      (while (and (not (eq frame sframe))
                  (not (eq (frame-visible-p frame) t)))
	(setq frame (next-frame frame)))
      (setq arg (1- arg)))

So the doc string of `other-frame' is correct.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      parent reply	other threads:[~2021-08-23 14:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-02 18:56 bug#13339: 24.3.50; doc of `next-frame' Drew Adams
2013-01-02 19:02 ` Drew Adams
2014-02-08 13:20 ` Lars Ingebrigtsen
2014-02-10 23:54   ` Drew Adams
2021-08-23 14:32 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilzws04c.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=13339@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).