From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sat, 28 Aug 2021 17:07:01 +0200 Message-ID: <87ilzpk3qi.fsf@gnus.org> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> <87o89ieruy.fsf@mail.linkov.net> <87a6l2d5kd.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2461"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , Dmitry Gutov , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 28 17:08:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJzwN-0000Qj-4c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Aug 2021 17:08:15 +0200 Original-Received: from localhost ([::1]:40200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJzwL-0004E3-Gl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Aug 2021 11:08:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJzwB-0004Dm-5P for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 11:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43277) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJzwA-0000E5-QU for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 11:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJzwA-0003UH-MB for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 11:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Aug 2021 15:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.163016323313324 (code B ref 39452); Sat, 28 Aug 2021 15:08:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 28 Aug 2021 15:07:13 +0000 Original-Received: from localhost ([127.0.0.1]:54818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJzvN-0003Sp-KO for submit@debbugs.gnu.org; Sat, 28 Aug 2021 11:07:13 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:43644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJzvM-0003Sb-6k for 39452@debbugs.gnu.org; Sat, 28 Aug 2021 11:07:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gwV7mNgiXmKilD+BdZGZ+OFefyxkQlYddj/tXEwohok=; b=r6VQfqjMC1xqwnMCglzRn+4HEp +FIq+tqMxxlifljKNZ5/vc49XxqBegVhjxafPmc0w0POHeSADIMQHx78badCJJ4O7QnQ7pJO8yz19 MP/A6r10oVb2BvNkamPxrSpHJ6NCJun/UgKbso0a1EGNCIyys0/e2CvWLEEMCwYEUpgo=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJzvB-0004d7-ME; Sat, 28 Aug 2021 17:07:05 +0200 In-Reply-To: <87a6l2d5kd.fsf@gmx.net> (Stephen Berman's message of "Fri, 27 Aug 2021 21:57:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212874 Archived-At: Stephen Berman writes: > I just discovered that some code I have that uses vc-print-log-internal > broke after the literal-pathspecs change; specifically, my code passes a > directory name beginning with "~/" to vc-print-log-internal, and this > had worked fine till that change, which broke it, and I found I have to > wrap the directory name in expand-file-name to make the code work again. > Is this expected fallout from that change or was I perhaps misusing > vc-print-log-internal and was just lucky that it had worked before? I think it's reasonable to expect parameters to `vc-print-log-internal' to have been expanded first, but that should be documented, at least. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no