unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#50279: 28.0.50; ffap-file-finder customization no longer works
@ 2021-08-30 17:07 Bob Rogers
  2021-08-31  1:59 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 13+ messages in thread
From: Bob Rogers @ 2021-08-30 17:07 UTC (permalink / raw)
  To: 50279

   I have a long-standing customization to ffap-file-finder which offers
external applications depending on file extension that is broken by the
following commit:

    commit 253b36bd40d1b342cdda09b0bee183788120f67e
    Author: dickmao <none>
    Date:   Tue Aug 3 12:02:48 2021 -0400

	ffap ido accommodation

	Now that ffap-file-finder can be ido-find-file, the
	noninteractive portion of find-file-at-point cannot
	assume ffap-file-finder always takes an argument
	(ido-find-file does not).

	* lisp/ffap.el (find-file-at-point): Do not call ffap-file-finder.
	* test/lisp/ffap-tests.el (ffap-ido-mode): Test it.

The essence of the change is that it does find-file at the critical
point instead of funcalling ffap-file-finder.  I assume that breaking
such extensions was not the intent, as it is an incompatible change to a
defcustom variable, and there is no associated NEWS entry.

					-- Bob Rogers
					   http://www.rgrjr.com/





^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-09-06 20:14 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-30 17:07 bug#50279: 28.0.50; ffap-file-finder customization no longer works Bob Rogers
2021-08-31  1:59 ` Lars Ingebrigtsen
     [not found]   ` <24877.41211.907036.418118@orion.rgrjr.com>
2021-08-31  3:43     ` Lars Ingebrigtsen
2021-09-29 16:02       ` Lars Ingebrigtsen
2021-09-29 16:11         ` Bob Rogers
2021-09-30  6:09           ` Lars Ingebrigtsen
2022-08-22 18:52             ` Lars Ingebrigtsen
2022-08-22 19:08               ` Bob Rogers
2022-08-23 10:00                 ` Lars Ingebrigtsen
2022-09-06  3:10                   ` Bob Rogers
2022-09-06 10:25                     ` Lars Ingebrigtsen
2022-09-06 17:03                       ` Bob Rogers
2022-09-06 20:14                         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).