From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50508: 27.2; find-function ignore find-function-source-path Date: Mon, 13 Sep 2021 09:48:19 +0200 Message-ID: <87ilz4j4qk.fsf@gnus.org> References: <87zgskmxhe.fsf@posteo.net> <87ee9vkzln.fsf@gnus.org> <87fsubax48.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37703"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50508@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 09:49:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPgiV-0009fc-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 09:49:27 +0200 Original-Received: from localhost ([::1]:55766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPgiT-0006Jx-Od for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 03:49:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPgi6-0006Jm-2P for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 03:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPgi5-0004SZ-RN for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 03:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPgi5-0002fM-Lj for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 03:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 07:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50508 X-GNU-PR-Package: emacs Original-Received: via spool by 50508-submit@debbugs.gnu.org id=B50508.163151931210210 (code B ref 50508); Mon, 13 Sep 2021 07:49:01 +0000 Original-Received: (at 50508) by debbugs.gnu.org; 13 Sep 2021 07:48:32 +0000 Original-Received: from localhost ([127.0.0.1]:44112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPghc-0002ec-8W for submit@debbugs.gnu.org; Mon, 13 Sep 2021 03:48:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPghZ-0002eM-Of for 50508@debbugs.gnu.org; Mon, 13 Sep 2021 03:48:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=M1kuoZO17HZZTI2h5S1WJXgUDGBWfcBqWy24v48sGyE=; b=j7YEtoIZuk9st1GLznJ900bNgV fPey9mpoaVptz5BosjtzFMW8TPsTc59kYy2pvsO0kRSh+T8kupUYCeoIcLmm8MdOo43VffSOSh01y DTVqyoCZUXLcyFPDo/lxGZ6vwR+PustW7OwEmUPt8kmi+WTg6N2HR6hIjK+IyHmoEeoA=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPghQ-00068a-C0; Mon, 13 Sep 2021 09:48:23 +0200 In-Reply-To: <87fsubax48.fsf@posteo.net> (Thierry Volpiatto's message of "Sat, 11 Sep 2021 16:29:58 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214183 Archived-At: Thierry Volpiatto writes: > Lars Ingebrigtsen writes: > >> 2) If the function was defined in a .el file (as this bug report >> describes), then Emacs knows the name of the library. But it doesn't >> then use `find-library-name' to locate the library, but just uses >> load-history. Fixing this is pretty easy -- just use >> `find-library-name' and use that instead of the value from >> `load-history'. > > Yes, this is working fine, it is what I am using actually. > https://github.com/emacs-helm/helm/blob/master/helm-lib.el#L1230 I'm just wondering whether it makes sense to fix 2) if we're not fixing 1), and I don't think fixing 1) is a good idea (it'd make the function massively slower). Instead I'm wondering whether we should just fix the doc strings here to not mention `find-function-source-path' in `find-function' (etc), so that the doc string matches the implementation, and instead mention `find-library-name' (in the doc string) for your use case. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no