From: "João Távora" <joaotavora@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 50244@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>,
Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el
Date: Mon, 13 Sep 2021 21:04:01 +0100 [thread overview]
Message-ID: <87ilz444zy.fsf@gmail.com> (raw)
In-Reply-To: <m1y280uukc.fsf@Frende-MacBook.lan> (Theodor Thornhill's message of "Mon, 13 Sep 2021 21:47:15 +0200")
Theodor Thornhill <theo@thornhill.no> writes:
> I will absolutely jump at this as quickly as possible. I'm not exactly
> sure how fast I'll be, since I'm on parental leave right now.
Congrats And enjoy it (I enjoyed mine very much)! >
> How would you want to receive the changes to eglot? As part of this
> bug, or as a new issue over at GH? I'm fine with either. Considering
> both flymake and eglot may be affected, maybe this bug is a good
> place?
Yes, it is (but the PR also works). I hope to transfer eglot.el to
Emacs core soon anyway.
Earlier you said project-wide diagnostics is become a trend with LSP
servers. Besides your elm-language-server where you most need this,
what other servers are doing this? Maybe I can install one of those for
a language I know and start testing this.
> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
> index 83c0b4dd99..543cfe64f4 100644
> --- a/lisp/progmodes/flymake.el
> +++ b/lisp/progmodes/flymake.el
> @@ -815,8 +815,6 @@ calling convention described in
> to handle a report even if TOKEN was not expected. REGION is
> a (BEG . END) pair of buffer positions indicating that this
> report applies to that region."
> - (unless state
> - (error "Can't find state for %s in `flymake--state'" backend))
> (cond
> ((null state)
> (flymake-error
Nice catch.
next prev parent reply other threads:[~2021-09-13 20:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 0:53 bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el João Távora
2021-08-29 23:27 ` Dmitry Gutov
2021-08-30 7:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-30 8:46 ` João Távora
2021-09-11 1:08 ` João Távora
2021-09-13 0:08 ` Dmitry Gutov
2021-09-13 6:48 ` João Távora
2021-09-13 18:03 ` João Távora
2021-09-13 19:47 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 20:04 ` João Távora [this message]
2021-09-13 20:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 8:50 ` João Távora
2021-09-14 9:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 11:34 ` João Távora
2021-09-14 12:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 19:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 20:22 ` João Távora
2021-10-23 20:50 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 20:11 ` Dmitry Gutov
2021-09-14 8:20 ` João Távora
2021-09-16 22:27 ` Dmitry Gutov
2021-09-16 23:37 ` João Távora
2021-09-13 20:26 ` Dmitry Gutov
2021-09-13 20:53 ` João Távora
2021-09-13 23:35 ` Dmitry Gutov
2021-09-14 8:43 ` João Távora
2021-09-16 22:19 ` Dmitry Gutov
2021-09-16 23:36 ` João Távora
2021-09-18 1:19 ` Dmitry Gutov
2021-09-18 9:59 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilz444zy.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=50244@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=p.stephani2@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).