From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with the most specific path. Date: Tue, 14 Sep 2021 09:57:27 +0200 Message-ID: <87ilz3vbbs.fsf@elite.giraud> References: <877dfkxyt4.fsf@elite.giraud> <83y280cv8g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8349"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (berkeley-unix) Cc: 50572@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 09:58:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ3KU-0001wK-GO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 09:58:10 +0200 Original-Received: from localhost ([::1]:52460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ3KT-0001nR-8F for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 03:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ3KM-0001nE-9f for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 03:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ3KM-0003Rl-1v for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 03:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ3KM-0002cN-01 for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 03:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 07:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50572-submit@debbugs.gnu.org id=B50572.163160625010006 (code B ref 50572); Tue, 14 Sep 2021 07:58:01 +0000 Original-Received: (at 50572) by debbugs.gnu.org; 14 Sep 2021 07:57:30 +0000 Original-Received: from localhost ([127.0.0.1]:47414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ3Jq-0002bK-Ha for submit@debbugs.gnu.org; Tue, 14 Sep 2021 03:57:30 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:44504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ3Jo-0002bC-VS for 50572@debbugs.gnu.org; Tue, 14 Sep 2021 03:57:29 -0400 Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 84214147 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 14 Sep 2021 09:57:27 +0200 (CEST) In-Reply-To: (Dmitry Gutov's message of "Tue, 14 Sep 2021 02:48:11 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214282 Archived-At: Dmitry Gutov writes: > On 13.09.2021 19:10, Eli Zaretskii wrote: >>> From: Manuel Giraud >>> Date: Mon, 13 Sep 2021 17:47:19 +0200 >>> >>> When calling 'vc-next-action' on an unregistered file, VC could choose a >>> backend that is very far above this file in the directory hierarchy. >>> >>> In my case, it chooses SVN as backend (because I have one in my homedir) >>> but I wanted it to choose the Git backend of the directory this file >>> resides. >>> >>> This patch solves this issue by selecting the backend with the most >>> specific (in fact, the longest string) path to the file. >> Isn't that already available with "C-u C-x v v"? > > A better default is an improvement anyway. > > I think the patch is a good idea, especially given that > vc-responsible-backend has only recently been changed in the same way > (commit 2697123933). I see: this is the same functionality. Should I package this selection into a function then? -- Manuel Giraud