From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Thu, 16 Sep 2021 20:51:47 +0200 Message-ID: <87ilz0l5fg.fsf@gmx.de> References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> <8335q7c655.fsf@gnu.org> <87pmta6buq.fsf@gmail.com> <837dfgaerv.fsf@gnu.org> <8735q4zcdh.fsf@gmail.com> <87tuikl79i.fsf@gmx.de> <87y27wxt6c.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21334"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: phst@google.com, 49723@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 16 20:52:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQwUe-0005NG-9L for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 20:52:20 +0200 Original-Received: from localhost ([::1]:56522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQwUd-0003YW-6Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 14:52:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQwUR-0003Xj-9T for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:52:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQwUM-0004nd-6i for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:52:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQwUM-0003Ko-2f for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2021 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49723 X-GNU-PR-Package: emacs Original-Received: via spool by 49723-submit@debbugs.gnu.org id=B49723.163181832012809 (code B ref 49723); Thu, 16 Sep 2021 18:52:02 +0000 Original-Received: (at 49723) by debbugs.gnu.org; 16 Sep 2021 18:52:00 +0000 Original-Received: from localhost ([127.0.0.1]:56562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwUK-0003KX-I0 for submit@debbugs.gnu.org; Thu, 16 Sep 2021 14:52:00 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:55925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwUJ-0003KI-0C for 49723@debbugs.gnu.org; Thu, 16 Sep 2021 14:51:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631818309; bh=n+7IgGDk4HDbjX2IpZSBwOZWs0RAEbxhyBi1o9cVA0U=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jFeGqZ8JxIYZQ0okE1MKT2FfmSJvib9W7ETjl5ua8cbmpxlQebIL+yhuAwiU5zyKx aUSDz/Nnm5UL0OwSoE3p0SCWzmB5spWea+h+hfd72LpRDmX1tfS2oGalJVHkEW1SkA O66PmD+CmIgPWFNCEjnHrYsyA+4RM+FXLFyUqh/Y= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.158.132]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MqJqN-1nCOT13LUp-00nTxS; Thu, 16 Sep 2021 20:51:48 +0200 In-Reply-To: <87y27wxt6c.fsf@gmail.com> (Federico Tedin's message of "Thu, 16 Sep 2021 20:38:03 +0200") X-Provags-ID: V03:K1:eNPU7XU4dqdw/KPkGMvuEkAOloUfA4BKkJiQuwqNlNuxaO1rLQD ovGqAuVyQB5wfa14hJU8mvzcRNacTMde+WIdVosh6SY92RfsFKC0o0F5jX3VI4Tg1xKgFe0 TWB5bre12dvi5R8XHMusZ9QEvhN8kIeLYmaz1udGhro0V7ZtQksn0PkLuPFqFV7Mm+keB60 UyRbWDuFYrCkTRmIQFcAQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:DBxFP7qqJOc=:S94CoRxCSllHsWwYWUKxYP z8EDPoH8mOQ0Rnde0Jt5w7VWlDbOa0XhI8q8Q37VpeiqUR1M76S8b+eS9mCLdbooceCJdXGnp BGyc28zYfIqHrNSY21o5jEbb5C2bFcuHio6ojtV9beDGNwwx5nq3cLV4n5J+B2pg5PUq2TK1o XQ/B+vu32NjexylRKecsXHnTKltgfJ9cCtq4sMANv5t0Jdt8w6eIknbAzQxZs46sUYsRVl+VX tZ+9acwzIJ/7U3vFo6hkzgq0l9De5ZBxO90pYTZoP6ZVg+JtAqv5hC1RzD2OcxtXz9FqcUVDr hYipx0AHa0YZOVCk66UQZwB5o4KWeGV0YF18+0VLBs7j3ru1/iHM2WZ+bT046OYIf+Dy3BqaD zjZ0PK9c0ik6God+qxxmDir9BrS+rTN4NylQGk3Uq5CwYKrnVUE1MsQky2OEe4iqom58AnRo2 e3Lbq6gDnFugb0vOf6/VbqP2AjlQj6smTJPNXnrHvveXK240vUNhg0EbFImhgS9aKsDuDmEsq Bo8gajaqkBEexbW2OFIbuqW6TTCGwEQzUPOjyfdRwgS4yrHgvL+CkzF84ewvN/pPrP6L69KJG IxKwIwBthNcpOLJ1WrqDUJ4DUh8VwccCVw8VYrDG/iLNw/OiwTbkn/t/TOdQdxMxV6X6HkCdf DSI9n9cCmwIpUqnNQOapy6GeeNF75eRuk4sYIa7Bf1GNuU3bJ7/mDQXkNCF14h5XqMqcn3Z5M pTtJo5rRN6BRCRY0qGfHVYZMnhnnZaGPougTn8jHYVzU9KiIqntJsowlipRxz+NSOqi1uLKv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214500 Archived-At: Federico Tedin writes: Hi Federico, > Would this imply only doing it in `tramp-handle-expand-file-name`, or > other functions as well? > > I had thought of doing it for at least `tramp-handle-expand-file-name`, > but then I noticed that the function eventually calls `expand-file-name` > with a combination of name + dir, or only with name. So in that case I > figured that the null bytes check would be performed by > `expand-file-name` anyways. I haven't checked yet what's needed. However, there are several incarnations of `expand-file-name' implementation in Tramp, namely --8<---------------cut here---------------start------------->8--- grep --color=auto -nH --null -E 'defun.+handle-expand-file-name' *.el tramp.el3393:(defun tramp-handle-expand-file-name (name &optional dir) tramp-gvfs.el1137:(defun tramp-gvfs-handle-expand-file-name (name &optional dir) tramp-sh.el2683:(defun tramp-sh-handle-expand-file-name (name &optional dir) tramp-smb.el736:(defun tramp-smb-handle-expand-file-name (name &optional dir) tramp-sudoedit.el346:(defun tramp-sudoedit-handle-expand-file-name (name &optional dir) --8<---------------cut here---------------end--------------->8--- Best regards, Michael.