From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#50667: Update ecomplete when used via standard UI Date: Sat, 18 Sep 2021 23:35:51 +0200 Message-ID: <87ilyxk1mw.fsf@gmail.com> References: <871r5l1tud.fsf@gmail.com> <87r1dlpp8t.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50667@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 23:36:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRi0I-0008Hg-QC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 23:36:10 +0200 Original-Received: from localhost ([::1]:44552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRi0H-0003wN-7G for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 17:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRi0A-0003vF-FI for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRi0A-0005tm-7X for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRi0A-0004OU-4I for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 21:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.163200096016882 (code B ref 50667); Sat, 18 Sep 2021 21:36:02 +0000 Original-Received: (at 50667) by debbugs.gnu.org; 18 Sep 2021 21:36:00 +0000 Original-Received: from localhost ([127.0.0.1]:37106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRi07-0004OE-R4 for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:36:00 -0400 Original-Received: from mail-ed1-f52.google.com ([209.85.208.52]:42677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRi06-0004O1-Li for 50667@debbugs.gnu.org; Sat, 18 Sep 2021 17:35:59 -0400 Original-Received: by mail-ed1-f52.google.com with SMTP id t6so44197602edi.9 for <50667@debbugs.gnu.org>; Sat, 18 Sep 2021 14:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SqmnvppMlktgJ4QJSpbAuhmVvuQN3TMXEhNVoJqXJxo=; b=Lex/AZbh9GRLN+qs2/PAv9tVHSA6aqIa776FxQdEuokyLLAms45wkfbDzq5waKr6W2 Dq30Q9zx6z9jTevpCOqQjOgVn1aiwtgUFesz0n9zyfpM4qldBDk4yJFvSu1h02T2rBVl NJiWS9zokFgItbVQMn2dfjWkEldVYC1EY7+N2Nr0C00kFvYNkLh5EVUF0F8V2kzWq9c3 YT0qfAlpWwX6tvYMVD2fQYIHsl2EOuHGWPT/Rtyk0g4lQY2ZeZGEAGjcKqi4Ny2xQ/Xt 6BLDEEGk1Tzy8gAKoWv0S7qeleHbaFoFmCWVB0yPe4KF13A0owHGxj0fL/QZZmNlLuxV BohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SqmnvppMlktgJ4QJSpbAuhmVvuQN3TMXEhNVoJqXJxo=; b=5u1LbxWo2l+oux+l8tpmbS6dogDjP0pxKwtzs8yJKNOnE6rBxsi+0QbRpDt30EEx6k 04W0NywJZiCwLEB6W6W/z96IHDKppDZ5KjHM7gPZuZaS8LgOeGnkKEQ5TBZO+/7qcRUq ZDYo6lcdYECX0eXcuQvc+0bV2NeBdTE1cRmAF5SR5TQkUkX/LWGECb1o6H5XiA4lgt66 iEraDHmHmBvelYZ5pJBX/ctouW7s9BB2GGLs/BbU9r6ds7oF20mLVcZmGVPB9ULYst0L owNkFIQG/Sh1X2HCcXQE8ptJRUcSVjONBUN4RTB5uA7DmlTUnVDrLT/VfsyTF5WdQGO/ rf9A== X-Gm-Message-State: AOAM533PMT6YqJi7y5W7gTiY38fFD6hbzA5mfo2T9brtAZHmVm4EbhAK pzOFaHKnAsktgkqaN8sapwxLBtqYzR0= X-Google-Smtp-Source: ABdhPJwsFfM8wV0GS1kBJmQVZTZwj8VSAWCDGJxE69kE53Y/D3EkLFcXEoS/1zN2LNJw4vDc/lFh6Q== X-Received: by 2002:a17:906:659:: with SMTP id t25mr19249673ejb.372.1632000952463; Sat, 18 Sep 2021 14:35:52 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::3c3e]) by smtp.gmail.com with ESMTPSA id jl12sm4066935ejc.120.2021.09.18.14.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 14:35:52 -0700 (PDT) In-Reply-To: <87r1dlpp8t.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 18 Sep 2021 23:06:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214664 Archived-At: On Sat, 18 Sep 2021 at 23:06, Lars Ingebrigtsen wrote: > Augusto Stoffel writes: > >> If one keeps sets >> >> (setq message-mail-alias-type nil ;; or keep the default 'abbrev >> message-expand-name-standard-ui t) >> >> and an ecomplete database file, then everything works OOTB, > > Works in what way? If I hit TAB in an address field, my completion UI kicks in and I can choose an address from the ecomplete database. > >> except that the ecomplete database doesn't get updated with new >> addresses. >> >> Is the following change a reasonable fix for this? > > [...] > >> - (when (and (message-mail-alias-type-p 'ecomplete) >> + (when (and (bound-and-true-p ecomplete-database) > > I think this would be highly surprising behaviour -- just loading a > library shouldn't have such side effects. Loading ecomplete doesn't populate 'ecomplete-database'. But if you set 'message-expand-name-standard-ui' to t, then 'ecomplete-start' will be called when request completions. > > What's your use case here? You don't want to use ecomplete for alias > expansions, but you still want to update the ecomplete database? I want to use ecomplete via completion at point instead of ecomplete's electric UI. This is what the variable 'message-expand-name-standard-ui' is meant for, right?