From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 51316@debbugs.gnu.org
Subject: bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup?
Date: Thu, 21 Oct 2021 14:18:32 +0200 [thread overview]
Message-ID: <87ilxqbmg7.fsf@miha-pc> (raw)
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
If function 'bug-reference--build-forge-setup-entry':
> `(,(concat "[/@]" host-domain "[/:]\\([.A-Za-z0-9_/-]+\\)\\.git")
This should be "(regexp-quote host-domain)".
Also, it would be nice if the final "\\.git" wasn't mandatory. I often
git clone a website url as displayed in a web browser
("https://gitlab.com/rstocker/emacs-bluetooth" for example) without
appending ".git". Git has no problem fetching from such an url (tested
with github, gitlab and gitea), but bug-reference autosetup machinery
fails to detect it as a valid url.
Unfortunately, we can't simply change the final .git into
"\\(?:\\.git\\)?" because regexp greediness would then swallow it into
the first match group. Instead, something like this could work
(concat
"[/@]" (regexp-quote host-domain)
"\\(?:"
"\\(?1:[.A-Za-z0-9_/-]+\\)\\.git\\|"
"\\(?1:[.A-Za-z0-9_/-]+\\)"
"\\)")
Thanks and best regards.
In GNU Emacs 29.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version
3.24.30, cairo version 1.17.4)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next reply other threads:[~2021-10-21 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 12:18 miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-10-22 14:59 ` bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup? Lars Ingebrigtsen
2021-10-22 20:45 ` Tassilo Horn
2021-10-22 21:42 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 9:12 ` Tassilo Horn
2021-10-23 12:58 ` Gregory Heytings
2021-10-24 12:17 ` Lars Ingebrigtsen
2021-10-26 9:01 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 13:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilxqbmg7.fsf@miha-pc \
--to=bug-gnu-emacs@gnu.org \
--cc=51316@debbugs.gnu.org \
--cc=miha@kamnitnik.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).