From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#38024: Remove icomplete workaround Date: Mon, 01 Nov 2021 10:28:40 +0100 Message-ID: <87ilxckywn.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38995"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org, joaotavora@gmail.com, Aaron Jensen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 01 10:29:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhTct-0009mG-N7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 10:29:11 +0100 Original-Received: from localhost ([::1]:50164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhTcr-0003o3-RK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 05:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhTck-0003no-FR for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 05:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhTck-0008E5-6k for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 05:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhTcj-0008Cv-Nr for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 05:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Nov 2021 09:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38024 X-GNU-PR-Package: emacs Original-Received: via spool by 38024-submit@debbugs.gnu.org id=B38024.163575892931529 (code B ref 38024); Mon, 01 Nov 2021 09:29:01 +0000 Original-Received: (at 38024) by debbugs.gnu.org; 1 Nov 2021 09:28:49 +0000 Original-Received: from localhost ([127.0.0.1]:33704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhTcW-0008CS-Nc for submit@debbugs.gnu.org; Mon, 01 Nov 2021 05:28:48 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:44852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhTcV-0008CE-Gh for 38024@debbugs.gnu.org; Mon, 01 Nov 2021 05:28:47 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id d13so27210476wrf.11 for <38024@debbugs.gnu.org>; Mon, 01 Nov 2021 02:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=yEL+mRPeqAWLST8MiRY0wFoW3wPkL8ek/y6WpedJ6ho=; b=pAwH8ypHnqH31FjD5D8ObuXpF24q7c8ZzZHXtOSi8woezeK+aSPKZ9TFGbgpz7S1JV Eo4ayuwUDsdRfRGZy+08s9GA41HYuQHqwOa0vQOWGO8tKu6zZO/gY1AEJBxq/aKHsIhv O3HpIZ3UQCp0lVY7i2FTjxDgfhXkhRSnAm3XxUyRi0+hcPcdX3IVND5fXWNBlHKlJwEP 8rKbp/njpFkkLtgIbXbuT8hx4BDhwo1QFkv4Lt39FsBz9qKHx5eBYz9DRMXiIUrK0tBE 5PT0Ftu0VtSHPrglEzr+/TyNYCo1DCaaJDnrn4rTf6XgjV1/F20ZGrECWYplAGFGxdYl bmTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yEL+mRPeqAWLST8MiRY0wFoW3wPkL8ek/y6WpedJ6ho=; b=zGB+DuXQeLF/Mne3M3y6s26F+N93ndDIvXjXMuIPL6LeLlfs8TxJIkC6yMuAG9ooYN 9gxRAUqha2b1tbQm54/YOpX0XOWrG4u2gLvyWCVl8bMpKBt+Ut2jWjnbQst/PS9HJR9F sL1cc/rDZQCsKqryqsqgRa0kRBRbU2fFCRQC9jcZQDVBGwC8HJFUNSuKTWEqidVXA0OX hMHQTpbhdXxXP9mLFwXizM+fgDWmkETQQwSnc+tepaiBoCRrJBu66mgSFnUVMuGAFyWB cV89t/2fsfdA9FWoX9NilkEHzMyz4kXzHePgiC0Dp3FUUxjrvVTJaVVcWp1vB/Zd45rO +5DA== X-Gm-Message-State: AOAM5314bPLqMFR+WiVsTa5NQkYjoW7XhCutSe2CfLShNTYpSokhV6qb HcKi412b55Y2jLFPXxUQFry1w6h0oPc= X-Google-Smtp-Source: ABdhPJx2mIVbM/C341Ab6V0bFkDu+EqhxEWZHsWtDHwrnovcaS/Ipy6WsWzzJE6YpZGrNK+EMprvbA== X-Received: by 2002:adf:f448:: with SMTP id f8mr27362842wrp.47.1635758921349; Mon, 01 Nov 2021 02:28:41 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id n8sm12514965wrp.95.2021.11.01.02.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 02:28:40 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 31 Oct 2021 22:38:45 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218750 Archived-At: Hey Aaron, Stefan Monnier writes: > Aaron Jensen [2021-10-31 20:49:23] wrote: >> >> Would it be possible to remove it? I'm ccing the original reporter and >> fixer in case they are able to shed more light on this or test without >> the fix to see if they can reproduce it. >> >> I've attached a patch if we are good to remove it. > > Thanks, I just pushed your patch to `master`. > We'll see if the problem comes back, and if so, we'll have to try and > fix it better. Congrats on your investigation work; I wish I could shed more light on what this workaround was meant to accomplish. I've tried to reproduce my original issue, but so far I was not successful. If my initial report can be trusted, the bug happened (1) back when the development branch was 27.0.50 (commit 61fb521481) (2) on an old battered laptop that I can no longer power on without disturbing loud fan demons. 26.3 no longer compiles on my end[1], so all I could do was try to reproduce on master, where the workaround has been reverted, on other computers I have lying around. The symptoms have not resurfaced yet, so=E2=80=A6 I'll go with a timid, yet hopeful "yay" =F0=9F=99=82 [1] With gcc 11.2.1: sysdep.c:1795:22: error: variably modified =E2=80=98sigsegv_stack=E2=80=99 = at file scope 1795 | static unsigned char sigsegv_stack[SIGSTKSZ]; | ^~~~~~~~~~~~~