From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51658: [PATCH] Haiku port (again) Date: Wed, 10 Nov 2021 08:00:25 +0800 Message-ID: <87ilx0yj52.fsf@yahoo.com> References: <87ee7surtv.fsf.ref@yahoo.com> <87ee7surtv.fsf@yahoo.com> <83mtmd43fa.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33177"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 51658@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 10 01:01:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkb3F-0008R7-UY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Nov 2021 01:01:18 +0100 Original-Received: from localhost ([::1]:52120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkb3E-0002IP-Nf for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 19:01:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkb30-0002IH-R3 for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 19:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkb2z-000328-WA for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 19:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkb2z-0001FH-VH for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 19:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Nov 2021 00:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51658 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51658-submit@debbugs.gnu.org id=B51658.16365024413712 (code B ref 51658); Wed, 10 Nov 2021 00:01:01 +0000 Original-Received: (at 51658) by debbugs.gnu.org; 10 Nov 2021 00:00:41 +0000 Original-Received: from localhost ([127.0.0.1]:36265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkb2f-0000xO-DT for submit@debbugs.gnu.org; Tue, 09 Nov 2021 19:00:41 -0500 Original-Received: from sonic308-10.consmr.mail.ne1.yahoo.com ([66.163.187.33]:33120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkb2b-0000oh-Pp for 51658@debbugs.gnu.org; Tue, 09 Nov 2021 19:00:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636502430; bh=FYS1czwGpgIzB7ziKXFkzlabcyQABJxFkEQtBUM7+gM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=UrLyz7zOrZKhurvqMpT3eHVnkSdx75SyRJAVwD5/kFWGTfg7liB7QwVy/Hl7Of8CHFUwuu065myKlSq0l+za7P1KxgHmFE3wuYVEvzv7xYBpq90xaDUKjIlNSnf3r415GZlSHESvONRNB5OTcclFVR2bQPsxLGMIhIR8LTqWPCZfpCdAzPPbsD4RO5mvtQwjByzDB7t8LKMKo70gKKaFQVbG29awi/pbURhe1p0LCKI7Ufy98EPEeADS9w1ngE+QpkZtOefBuWGfo/0FyL7IcclfNtkvMBDg/7eLnwGpWdGZsdQ9lIcCujIkPmOJAueJjP37VhCFpulsdwzIeBmtKA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636502430; bh=w2+r6TP7WnL+BLrfVvJZfmB5VuMD3/VssejOo2GBoDY=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=TrLfk7FpLFWLqtIpzvuZKT34XLMtxM3i3LKP0OxuWRgQUZilk2NepFclnSdHzHdLfwIlsTFLrr2mixWMI8gjwSJQ/TZwo+rcLXJ8S0gkOJoWkuJ+PuN65yJo6UX0rl67mOIn0enxn4lCKfDzVxNxe1cQez5GCD3AlM++UOMFQTviQCodZQuggPsxJvDhc+UkLvyJwNupRoFuxaEFEYuDnbxoXGamCUl62nwtMAMnsELnJmnBH/TN9ZaimLJqzoepD0mqU2sPphryG5tPybY4DbaLjFYBPgQnMxHxVm1WosVj7dtlIS3iurzrVp+cJgcenFO2UViXAhnOj0yVlhyraw== X-YMail-OSG: y44FekMVM1l1Ssd1V9j7D5iWvV1PJLdNVsWMKJOsTr7AaSy4qzLMJA0mARbUar8 LJ4t87Wp40FhdPDUwJJCFUZzW18W4jWNWu0Td8sSXVGNyTmdg41Bc3np7sjoutys0G4NrHNECEvS p3sdqIESVp__ZqLLM2v3lmC6PZk9GAW2NlfnI6teSixqSja5EESauEA4Gm5gMTJl2jOjpRIOwD05 21mJHgeA9Ixc1QYEg7isyNC0uSJR7nuUpEy9EuTAT7_7IKygoqlAkdlc6qz6YyLJsCMzlXsiolc1 lLpM3IzZWe1xpy27JthcELKkRC1PLAJEVYOWrktgTucWMi2mpACFE14SHRsa_YxwZCbb2Riip14k VISpv.MAuoYV34d4g3z2Yj1.JiUVI86itGZfoWM.uqFK3Jf5SYf2hktqAeKNvin2KrDZYO2UcDhk bRdUBvLkGF7sIoLh1hqam1ymQfoc799Ad49_7RzFBTlInOClFYYn.M357HcAPUDdvCFJwb8V0GWU Tila.PkfvBqycWYc8l2cwNIocPWfKZtpAGvsJ99EAXBy6Dw3LAVZqArc086E87sIABrrOm95dh8K TTtlxtLRRyFghJH76YfjacrknUbkONJN83EqmyYa6te5zkjOyPX2HH_atT0nLflVqku2oiG2kLRR Ou5Xz.7OQW13EbxbSWCHJ1F6VTNPnMHYXgKKc78JLgBBOL05kB5ih.RvmqpkWm3BEotsue2Y3S4T b_den57nwHvUOPdbBzRhM.f32DaTSpv3JtZmyLLGTGLv_KD.m_wGfaW5hL3i8yh8BpB3bKG1wu_1 2q741q.3DzVyfWjmNJqEje1.pDoC4iNPpfyEJJy_4T X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Wed, 10 Nov 2021 00:00:30 +0000 Original-Received: by kubenode508.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 99ed442cea9826bc0e27f4d97fb43fe3; Wed, 10 Nov 2021 00:00:28 +0000 (UTC) In-Reply-To: <83mtmd43fa.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Nov 2021 19:58:01 +0200") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219483 Archived-At: Eli Zaretskii writes: > Thanks. > > It's a large patch, so let's start with the general, a.k.a. "big" > aspects. > > First, do we really need to use *.cc files and compile with a C++ > compiler? Is that a necessity? AFAICT, the code in those *.cc files > is plain C, so why not use a C compiler, as we do on every other > platform? That isn't C code. The code in the .cc code is written in C++, in order to use the Haiku GUI libraries which require C++. I tried to keep it simple and understandable for people who don't know C++, but know C. That C++ code, in turn, exports functions the rest of Emacs uses as `extern "C"'. > Next, the font backend stuff: do we really need 5 (five) backends? > How about having just one: HarfBuzz+Cairo? That's the direction we go > on other platforms, so how about making the Haiku code smaller and > simpler and support just that single backend, and drop all the older > ones? I'd definitely won't want to drag the unmaintained libm17n-flt > into this port. I'm fine with removing the ftbe backend, but I would prefer to keep the haikufont backend working. The reason is that Haiku users might not have Cairo installed, and it likes to break every now and then, as it's not considered important for that platform. > If you are okay with the above, could you please update the patch, so > that we could avoid reviewing code which eventually won't be > installed? Yes, but please tell me if you're OK with keeping haikufont first. Thanks.