From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#53070: 27.2; Message "Server closed connection" not verbose enough Date: Fri, 07 Jan 2022 10:35:14 +0100 Message-ID: <87iluv7ust.fsf@gmail.com> References: <87o84nhq0j.fsf@vagabond.tim-landscheidt.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6576"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53070@debbugs.gnu.org To: Tim Landscheidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 07 10:38:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5li4-0001Vm-2i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jan 2022 10:38:56 +0100 Original-Received: from localhost ([::1]:36802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5li3-0006T3-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jan 2022 04:38:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5lfM-0002MK-CQ for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5lfG-0000k4-VY for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5lfF-00048G-Me; Fri, 07 Jan 2022 04:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 07 Jan 2022 09:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53070 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 53070-submit@debbugs.gnu.org id=B53070.164154812515833 (code B ref 53070); Fri, 07 Jan 2022 09:36:01 +0000 Original-Received: (at 53070) by debbugs.gnu.org; 7 Jan 2022 09:35:25 +0000 Original-Received: from localhost ([127.0.0.1]:43072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5lef-00047J-0O for submit@debbugs.gnu.org; Fri, 07 Jan 2022 04:35:25 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:36775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5leb-000470-LR for 53070@debbugs.gnu.org; Fri, 07 Jan 2022 04:35:23 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id r10so2262442wrc.3 for <53070@debbugs.gnu.org>; Fri, 07 Jan 2022 01:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=AoU2ezlgDQHe+ISB4azAWNTzMbd0PGTGs/dk1OrYrIA=; b=G6ZdWIULzkMsfYldFL/mOr1xt0mggYFU/+QMHm0qU10LWMo7qbwF5LuKDIg6NGtOat GhxpIZp7pMDsBcL5Zz9WDg/ma7VhEeJhcQHYosAEHRNlRt+L4XyAj3e9KkmApAzr8Qgy fFx7Jr995ZVDLDF675tn/NJARWiqB0j7jVe2fajKOJuQhi6WMDJMnvv3IxWP6eQJy4I3 u5OP5aC1McMzqt3+XPQvg9Ni5Y0r4ABdrUgFHYVLU5PMCr0INUAkEooT3QLFVKq2FRJ6 y3VzfMEV2QmBIrAx8AMe3QAGZx0lt3VXt8IIr6pivs6RjrX7UXY39bmadNpVK3Cnqh3j csfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=AoU2ezlgDQHe+ISB4azAWNTzMbd0PGTGs/dk1OrYrIA=; b=4FXBdSj4YV7j2Zvq9USgiNW5FenmCHFEhyEoF4YPsIZ0Tt54gL9HXEkoGSrUO/6PMn hpjNlpFsim+Rz7I5UyFWj+MVgVMqBx6jDuhx4L0PGIlnfGtLZc93r+ihckhODjIilrwe 4QmhHVptTMr/DQqIkJCHgx2mzMckSIr1u+gk6Jxxxp8c5eImODuUnJu0b/RaUu7JDq0p JV6nDTkb0NMSO3JtqS7wXDANQfjDeLqZ9ihGVzzO6hb2XLiEuDZngZzkMfVbz70JuwVx gdEWumKDgzdf/j29RfNsg+KLrgpPy6s3otLSi2Vc76E5aqjBy7ap+aiB14YlOm8LDPCc Ya0A== X-Gm-Message-State: AOAM533iaVYecjxoVEP6F8NK8YJAkqB/FxRtxyME/3vVCGRL7dzNZm1t KRDeNlfK5WuIsk25RkrkIf83Dncaa2M= X-Google-Smtp-Source: ABdhPJzF6+nT2VEFqgWSrPwARKGa7j9EemZexACQNhef5h5MY/f9IPBAfdzqqq6/hHn8ICwNe464ZA== X-Received: by 2002:adf:e485:: with SMTP id i5mr4096365wrm.705.1641548115445; Fri, 07 Jan 2022 01:35:15 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:24e:3978:3b03:ee76]) by smtp.gmail.com with ESMTPSA id n14sm4530417wrf.107.2022.01.07.01.35.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 01:35:14 -0800 (PST) In-Reply-To: <87o84nhq0j.fsf@vagabond.tim-landscheidt.de> (Tim Landscheidt's message of "Fri, 07 Jan 2022 09:08:28 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223779 Archived-At: >>>>> On Fri, 07 Jan 2022 09:08:28 +0000, Tim Landscheidt said: Tim> Now "Server closed connection" is an error message defined Tim> for IMAP /and/ NNTP servers, and I have configured more than Tim> one NNTP server as well. So I had to set Tim> nntp-record-commands to t and look in *nntp-log*'s: Someone hasn't applied "Robert's rules for debuggability", which state: "All log messages must be unique" :-) Tim> | 20220106T154438.490 news.gmane.io MODE READER Tim> | 20220106T154508.531 news.gmane.io *** CONNECTION LOST *** Tim> | 20220106T154511.955 news.gmane.io MODE READER Tim> | 20220106T154541.984 news.gmane.io *** CALLED nntp-report *** Tim> to /assume/ that the error occurs while Gnus is trying to Tim> talk to news.gmane.io. Untested patch below. Tim> It would be more helpful if the error message read "Server Tim> news.gmane.io closed connection" or, to avoid any ambiguity, Tim> "NNTP server news.gmane.io closed connection". Tim> (Side note: If such a hiccup happens, it sometimes appears Tim> that the *Group* buffer is not updated with regard to number Tim> of unread messages per group, etc. for /other/ servers that Tim> were successfully contacted. I don't know if Gnus is more Tim> aggressive than it needs to be here; if it encounters an er- Tim> ror when trying to contact a POP3 server, it will just ask Tim> nicely and continue on.) That=CA=BCs a separate issue. My connections are reliable enough that I don=CA=BCt see this. diff --git i/lisp/gnus/nnimap.el w/lisp/gnus/nnimap.el index fd6e3c0ccf..710b08b9da 100644 --- i/lisp/gnus/nnimap.el +++ w/lisp/gnus/nnimap.el @@ -245,7 +245,7 @@ nnimap-retrieve-headers (nnimap-header-parameters)) t) (unless (process-live-p (get-buffer-process (current-buffer))) - (error "Server closed connection")) + (error "IMAP server %S closed connection" nnimap-address)) (nnimap-transform-headers) (nnheader-remove-cr-followed-by-lf)) (insert-buffer-substring diff --git i/lisp/gnus/nntp.el w/lisp/gnus/nntp.el index 038a6d0625..df4c0068e3 100644 --- i/lisp/gnus/nntp.el +++ w/lisp/gnus/nntp.el @@ -305,7 +305,7 @@ nntp-send-string (nntp-record-command string)) (process-send-string process (concat string nntp-end-of-line)) (or (memq (process-status process) '(open run)) - (nntp-report "Server closed connection"))) + (nntp-report "NNTP server %S closed connection" nntp-address))) =20 (defun nntp-record-command (string) "Record the command STRING." @@ -370,7 +370,7 @@ nntp-wait-for (nntp-snarf-error-message) nil)) ((not (memq (process-status process) '(open run))) - (nntp-report "Server closed connection")) + (nntp-report "NNTP server %S closed connection" nntp-address)) (t (goto-char (point-max)) (let ((limit (point-min)) @@ -1435,7 +1435,7 @@ nntp-accept-process-output ;; be the process's former output buffer (i.e. now killed) (or (and process (memq (process-status process) '(open run))) - (nntp-report "Server closed connection"))))) + (nntp-report "NNTP server %S closed connection" nntp-address))))) =20 (defun nntp-accept-response () "Wait for output from the process that outputs to BUFFER." @@ -1454,7 +1454,7 @@ nntp-possibly-change-group (when group (let ((entry (nntp-find-connection-entry nntp-server-buffer))) (cond ((not entry) - (nntp-report "Server closed connection")) + (nntp-report "NNTP server %S closed connection" nntp-address)) ((not (equal group (caddr entry))) (with-current-buffer (process-buffer (car entry)) (erase-buffer) Robert --=20