From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#50143: 28.0.50; Various issues with `tamil-itrans' input method Date: Fri, 18 Feb 2022 06:31:52 +0530 Message-ID: <87iltdoud0.fsf@gmail.com> References: <83fsv2x7jt.fsf@gnu.org> <874k509w4k.fsf@gmail.com> <83wnhu1zob.fsf@gnu.org> <87y229pxwt.fsf@gmail.com> <83czjl1jun.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23376"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50143@debbugs.gnu.org, rameshnedunchezian@outlook.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 18 02:08:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKrks-0005yM-Ns for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Feb 2022 02:08:14 +0100 Original-Received: from localhost ([::1]:39588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKrkq-0005nU-PT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 20:08:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKrkg-0005nL-UH for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 20:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59144) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKrkg-0007NC-LI for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 20:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKrkg-0008DL-Gq for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 20:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Feb 2022 01:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50143 X-GNU-PR-Package: emacs Original-Received: via spool by 50143-submit@debbugs.gnu.org id=B50143.164514645431538 (code B ref 50143); Fri, 18 Feb 2022 01:08:02 +0000 Original-Received: (at 50143) by debbugs.gnu.org; 18 Feb 2022 01:07:34 +0000 Original-Received: from localhost ([127.0.0.1]:53041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKrkD-0008Cc-Th for submit@debbugs.gnu.org; Thu, 17 Feb 2022 20:07:34 -0500 Original-Received: from mail-pj1-f66.google.com ([209.85.216.66]:33128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKrkC-0008CN-Vd for 50143@debbugs.gnu.org; Thu, 17 Feb 2022 20:07:33 -0500 Original-Received: by mail-pj1-f66.google.com with SMTP id k60-20020a17090a4cc200b001b932781f3eso7294219pjh.0 for <50143@debbugs.gnu.org>; Thu, 17 Feb 2022 17:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:date:lines:references:user-agent :message-id:mime-version:content-transfer-encoding; bh=zCUHdm6XfhUjxDwJ7z5uDN/HjU+C9AE/gVOE3J8fxoM=; b=Ulv/MW3zRti5gsfLopbwmUR6ctXb7K9D5/pbmR3N3Kx5SEf3EDyGZJM2XbVjPsOGz5 NS95zUs0LHUglWtlFNVNxObl8+kGRFHB7AsrO9oPJNm0hpVqX9f4dHN5zFNR02TtVrrX Hkd0aj5L0K36s49MN6VhhYjCoStDhIG3WzBxKEIxxhUk6qQCaUUWx2T/h+dtrgUuTASY M7k18Yvrq/Jlc6Xt7GQVTWOHPKeX4bZwH5s87YFbfBawhPKNx79970PMdU54nxU7GuM9 k2hD/LqtzIlK6RXAW2Esf6UJNOaeXwVPbig+J9UuiNFMSCLz1IRZVMOxKM8z6MGKc4aA /YPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:lines :references:user-agent:message-id:mime-version :content-transfer-encoding; bh=zCUHdm6XfhUjxDwJ7z5uDN/HjU+C9AE/gVOE3J8fxoM=; b=3NVZipAjTXeiZSmvUu6oIBSpkRAQcrDordAK3bKfyeMKGW5XVCRydnLXghYYRUQP8Y Slq5rnL2FBw/SuHRBsvC382iuR4J+2kyKWsKatIMWaYFcr3CoWLpA4u6yjZDpSOFVdz3 GoPIVzzQYeZ+hY6fNu+gLKuLj4CIdFmDtZ49zAFnHfOZRGGATyas3eOYHQh6/BwcIhoZ 565OU318qzgj+A1IUj3KbY/kJa84ZQXIVkAwLAcgnyuehZGDmRHbi5eRyRNsQ5CG59Rt CYvW5mcGgvKJJTNDRRcJB4N6HDskDECC/UIYtWYYZKVf0oaZnP8G8qY7SwljWma9qHOt WKwg== X-Gm-Message-State: AOAM533UFRt/JtOKHbzRAvHJvB6ta+0/wszD9hDIM9AYfWGwT7zQzA2T WcfifldT3yDu0PJvgUs/xMA= X-Google-Smtp-Source: ABdhPJwTQM/LIX1Vs4IuojDl07IB1PkEVkzI8NmLNpgUSgBLLnNsSYz2QOVmp1Dgpok7xX1xHX+wUQ== X-Received: by 2002:a17:902:b289:b0:14d:d3ab:97bd with SMTP id u9-20020a170902b28900b0014dd3ab97bdmr5213934plr.161.1645146446982; Thu, 17 Feb 2022 17:07:26 -0800 (PST) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id p9sm791606pfo.97.2022.02.17.17.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 17:07:26 -0800 (PST) In-Reply-To: <83czjl1jun.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Feb 2022 19:30:40 +0200") Original-Lines: 74 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227129 Archived-At: [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D, =E0=AE=AA= =E0=AE=BF=E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B5=E0=AE=B0=E0=AE=BF 17 2022] El= i Zaretskii wrote: >> From: Visuwesh >> Cc: rameshnedunchezian@outlook.com, 50143@debbugs.gnu.org >> Date: Thu, 17 Feb 2022 16:23:06 +0530 >>=20 >> > 1. For your items 1 and 3, just copy indian-tml-base-table to a new >> > variable, modify it to include the two missing characters and >> > replace the digits with nil, add a new variable similar to >> > indian-tml-itrans-v5-hash, and compute its value like we do with >> > indian-tml-itrans-v5-hash, but using the new table instead of >> > indian-tml-base-table. Then make a new input method, called, say, >> > tamil-itrans-alt, which would use the new hash variable instead of >> > indian-tml-itrans-v5-hash. Submit these changes as patches to >> > lisp/language/ind-util.el and lisp/leim/quail/indian.el. >> > >>=20 >> Does the attached patch look okay to you? > > Yes, thanks. > >> The names of the new input methods are bad. IMO, tamil-itrans and >> tamil-inscript should ideally be renamed to tamil-itrans-digits and >> tamil-inscript-digits, and the new input methods should be tamil-itrans >> and tamil-inscript. But I guess such a backwards incompatible change >> won't fly? > > No, I think you can do the renaming. The change is already > incompatible, because we will be changing the default input method, so > it will need a NEWS entry to tell how to get back old behavior, and in > that NEWS entry we can also tell users to switch to another input > method. > Okay, I will do that, thanks. >> > 2. For your item 2, submit a patch that fixes the docstring of the >> > relevant input methods. >>=20 >> About item 2: according to the docstring of `quail-define-package', >> constructs of the form "\" should be replaced by the VAR: >>=20 >> DOCSTRING is the documentation string of this package. The command >> =E2=80=98describe-input-method=E2=80=99 shows this string while repl= acing the form >> \ in the string by the value of VAR. That value should be a >> string. For instance, the form \ is >> replaced by a description about how to select a translation from a >> list of candidates. >>=20 >> but this is not the case, I checked the code but don't see a >> substitution like this happen. Maybe this should be fixed in >> `describe-input-method' instead? > > If you can find the problem and fix i there, fine. But fixing only a > small number of input methods with patches specific to those methods > is also fine. > I will see what if I can fix it in the `describe-input-method' level, and if I cannot figure it out, I will patch the input methods instead. > Btw, the patch is already close to the limit of what we can accept > without copyright assignment, so would you like to start your legal > paperwork rolling at this time, so that we could in the future accept > more contributions from you? If yes, I will send you the form to fill > and the instructions to go with that. > > Thanks. Yes, I would appreciate it, thanks.