From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54603: 29.0.50; [PATCH] Eshell's external pipe module interferes with other argument parsing hooks Date: Thu, 31 Mar 2022 13:46:09 +0200 Message-ID: <87ilru73b2.fsf@gnus.org> References: <70677cd2-f741-16d1-b38f-c39b507cc95e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54603@debbugs.gnu.org, John Wiegley To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 31 13:55:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZtOd-0009RV-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 13:55:23 +0200 Original-Received: from localhost ([::1]:37428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZtOb-0008V9-DS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 07:55:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZtGk-0002EQ-Dy for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 07:47:14 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZtGX-0005dr-WE for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 07:47:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZtGX-00079H-Qn for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 07:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Mar 2022 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54603-submit@debbugs.gnu.org id=B54603.164872718325603 (code B ref 54603); Thu, 31 Mar 2022 11:47:01 +0000 Original-Received: (at 54603) by debbugs.gnu.org; 31 Mar 2022 11:46:23 +0000 Original-Received: from localhost ([127.0.0.1]:38106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZtFu-0006ea-G5 for submit@debbugs.gnu.org; Thu, 31 Mar 2022 07:46:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZtFs-0006YG-QQ for 54603@debbugs.gnu.org; Thu, 31 Mar 2022 07:46:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rkHRnAfD670T6puldWhTn9Da1wTtk4JRaS3vxrTlYkM=; b=HxvkwNJJuLPjRGmi5IryH/9GHH zUlAEP6sYJGZjcfXuY1jEiYfm7UW2E7qZzvw/JfYaXvLTpcKwALwnuy204Wtfw+imCguUofQgeaOf Fvn+hRyoORAlj+W4aQp6avJzRETw18sAw8vmQV0A5/evOyp08qDrh7wZBScM/yjBzt3Y=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZtFk-000391-26; Thu, 31 Mar 2022 13:46:14 +0200 In-Reply-To: <70677cd2-f741-16d1-b38f-c39b507cc95e@gmail.com> (Jim Porter's message of "Sun, 27 Mar 2022 19:21:17 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229151 Archived-At: Jim Porter writes: > The attached patch resolves the issue for me, but I'm not sure if it's > the best strategy. If possible, I think it would be better for > `eshell-parse-external-pipeline' to solely focus on finding the > external pipe operators ("*|", "*<", and "*>")[1] and then for > `eshell-rewrite-external-pipeline' to prepare the command string to > pass to sh. This would also have the advantage[2] of making it > possible to support a richer set of Eshell features with external > pipes, such as the following: I think that sounds like a good idea (but I don't use eshell regularly, so I don't really have much of an opinion here). Perhaps John does; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no