From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#12840: 24.2.50; ediff: mode-line of control buffer - improvement request Date: Tue, 14 Jun 2022 16:45:02 +0200 Message-ID: <87ilp31ez5.fsf@web.de> References: <87mwys0zrv.fsf@web.de> <875ymdk2sm.fsf@gnus.org> <87ee11ylzj.fsf@web.de> <87wnesb835.fsf@gnus.org> <87leu0sme0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34410"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 12840@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 14 16:46:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o17o3-0008iI-4O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 16:46:11 +0200 Original-Received: from localhost ([::1]:58716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o17o1-0003Cu-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 10:46:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o17nu-0003Ck-TK for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 10:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o17nu-0000v2-L9 for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 10:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o17nu-00077L-Fx for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2022 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 12840-submit@debbugs.gnu.org id=B12840.165521791427295 (code B ref 12840); Tue, 14 Jun 2022 14:46:02 +0000 Original-Received: (at 12840) by debbugs.gnu.org; 14 Jun 2022 14:45:14 +0000 Original-Received: from localhost ([127.0.0.1]:35438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o17n7-00076A-IR for submit@debbugs.gnu.org; Tue, 14 Jun 2022 10:45:13 -0400 Original-Received: from mout.web.de ([212.227.17.11]:38835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o17n3-00075s-FG for 12840@debbugs.gnu.org; Tue, 14 Jun 2022 10:45:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1655217903; bh=pHFYuzgVSNEcUNCNsFVtWbxNJpoJe+tZ4CBV/T1y5gM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jleglcy00+l3kS0xfGB5+tbo3qZPHHre1OCdvLKQ45HZhnODHCDKbOuxppc3lenYp rmo5X8aS4w8N7huBgRlpbv3gMI6SzqwXu3JiZD2KOnDTmLiXD1zG26Z0Vt4mc0Nv/S 4SoEe49/5tScV4GzqtEZv0HAr7uSZUrA9iZRsdwE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.60.174.246]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MqZQY-1nNPFX0MDo-00mbAB; Tue, 14 Jun 2022 16:45:03 +0200 In-Reply-To: <87leu0sme0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 13 Jun 2022 15:50:31 +0200") X-Provags-ID: V03:K1:TzUUzeTNJcfqQVfVbxPcajB+20j0hAGQQFpCH1plsdlleAAg3FR Y4aUiACWjWAhguMS/Hqsczbkk2JFaJh5QZSviEEWOEEgTDm5EUHiI9zzkr4/f3vczTJ6tn5 8+ThK9vqXY+yyAAAIVp7p5143RAkjxtcRJ1WULAPyvzjIiQV3om+IizTS9J4aKgJNTUXy+j 1/k6MNniP1UjKMFlaGPNg== X-UI-Out-Filterresults: notjunk:1;V03:K0:BrxQPacnsU0=:nv0B950vVv1UNetCaXcj3m tss2ImCLlgH7Alraqhuuwb48WlQTJScNkSl/QPqMtOKOQhUDmIhSl5VRGOQg9WXvx5hHW4dr7 oUFpHt2w2Z0lvK9QFW3R5Bu1kMCp4pR4KRBlucQx7eT4Uggx7s35vlho7+lb4zCHluEoNqGRY DhnhvtqIlEqLzeyhfKd2SHXcoUf2cqOaDbpykCOysX/Gs8TASf8R9G2NmmaAdX99IodmkJFaK o7ec19Gobc9fhufdIxbcK9Pcb/YTG4OkqRavl1DC/+n2wPdVG5oBqGETq8S+/m1meH/u/xibw 2lZTi8Dg/k9v37SgeEeyeljolrIBNCZ772JitczQ/Enub0VBuE9vKmnwdxkMkvljfMX0c6Ipj 4SYdt4o66EeCWJ2CdkdZcavqkZ9QC2nGV3FDKW1GtwRxdMFNkrYH7cOqhI3/Tj9q7Wu9TFWsF ad09FA0sSdme84KR8w7SZ8g48Ak4htInLw/0LSepsd1Dgkwv6uajdoXTie497svjJ1nn3ZGZc zT9ecWfvjB+XgLvqIQ/CPXQRXe8JxWajzkI3YvxkwM7NhwP8EokI0FeK9fY4XoneRK9T1Gm6p 9HmxxNsgliyHKs2wp+LQ71LRl0Xvjm6U/279mQRNDY62UHpnUbiflvCAfjDViTnlSnwKns1lo KVOYdvzxRZdlD2elH6dhNwB9e7JbKYug955+qrxCIoJA262cN0UTvhqMk9RDYNiWjCnh5PDFk qfu67K5yAkvpwZ+llHpGEjqJ/ufVdNBB2xUOTu7yT2D1uW8j001aZS//xyo4vznxpEc3eDk2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234509 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > I've now done these changes in Emacs 29 -- removed the "Quick Help" > thing with the plain setting, and made the informative parts bold > (using your suggested function). Thanks. I would rather like to avoid to decide based on the value of `ediff-window-setup-function' since users may wish to implement their own setup functions. Maybe a better approach of deciding would be to make it depend on whether the Quick Help is currently displayed? Seems there is a variable we could use: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Tune-when-to-show-Quick-Help-in-Ediff.patch Content-Transfer-Encoding: quoted-printable =46rom fb2ff90ea8011eb7ebe1961869a74374a266c1d6 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Tue, 14 Jun 2022 15:09:31 +0200 Subject: [PATCH] WIP: Tune when to show "Quick Help" in Ediff =2D-- lisp/vc/ediff-wind.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el index 4549b910b1..6db3667545 100644 =2D-- a/lisp/vc/ediff-wind.el +++ b/lisp/vc/ediff-wind.el @@ -1136,9 +1136,7 @@ ediff-refresh-mode-lines (if (ediff-narrow-control-frame-p) (list " " mode-line-buffer-identification) (list "-- " mode-line-buffer-identification - (and (not (eq ediff-window-setup-function - 'ediff-setup-windows-plain)) - " Quick Help")))) + (list 'ediff-use-long-help-message " Quick Help"= )))) ;; control buffer id (setq mode-line-buffer-identification (if (ediff-narrow-control-frame-p) =2D- 2.30.2 --=-=-= Content-Type: text/plain Michael. --=-=-=--