From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#56255: 28.1.50; sxhash-equal does not change when object is modified Date: Wed, 29 Jun 2022 20:33:05 +0800 Message-ID: <87ilojk5tq.fsf@localhost> References: <87v8sm70ma.fsf@localhost> <87y1xhu34f.fsf@gnus.org> <87r139u2y6.fsf@gnus.org> <874k05q70i.fsf@gnus.org> <87sfnokz6p.fsf@localhost> <87o7yblreq.fsf@gnus.org> <87r137kcbt.fsf@localhost> <87fsjnlqrh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13956"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56255@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 29 14:35:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6Wuc-0003KD-Qr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jun 2022 14:35:18 +0200 Original-Received: from localhost ([::1]:54880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6Wub-0004Dr-2R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jun 2022 08:35:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6WsQ-0004CZ-NR for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 08:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6WsQ-00014b-CQ for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 08:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6WsQ-0005PX-9p for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 08:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jun 2022 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56255 X-GNU-PR-Package: emacs Original-Received: via spool by 56255-submit@debbugs.gnu.org id=B56255.165650592520725 (code B ref 56255); Wed, 29 Jun 2022 12:33:02 +0000 Original-Received: (at 56255) by debbugs.gnu.org; 29 Jun 2022 12:32:05 +0000 Original-Received: from localhost ([127.0.0.1]:57985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6WrV-0005OD-Jb for submit@debbugs.gnu.org; Wed, 29 Jun 2022 08:32:05 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:44660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6WrS-0005Ng-PW for 56255@debbugs.gnu.org; Wed, 29 Jun 2022 08:32:03 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id v126so11021284pgv.11 for <56255@debbugs.gnu.org>; Wed, 29 Jun 2022 05:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=7MWDLqf90e6FaM0Y2n/qetUoaowmXv17FlaGXDk8GmE=; b=G0kKxifHUCxfJV9XSvv4rry9kzfi5WfSNmuUh6zPt8Zp3gFL0tKQDXz8/Ax2Qnwrvb nfi3X9XE5Ump2UA8e+WBuToC0FwZapqCFpFhBfH+4hYjz6+T9C/+SsWq4VnJFC0aiWgR eLsw5kjv2PKmCHqezWvI9HVDvxatHLpb/BsxOiEL20JkeJWkvOCU9F6pUQ4cegrwcTv3 rcQ3S5rxXmqpGqqVTqgxClfVGlqlN7ruQE/X8qDWMKwu2aaydAzS4+w780I1Ak7HQFQj 3V3KNJxjPoJSpN0rgcNPuWhiB0M4vYzN9p80jlU2K4YafZMQTQ2jDP6MW9ssQ28d3YdI b6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=7MWDLqf90e6FaM0Y2n/qetUoaowmXv17FlaGXDk8GmE=; b=f5ofdzZbDSAoQpLDbPx/TLYqnxo/vdWrkuJFCOy+RTjDVNBEiSH+xcK83V2IwPW6zH 2HCv8VS6fWZaCjw7SHd3vu/X85vn9r0esNDEp+OdiTkKRWQE/IXJI5nEs2GKeahWxomq FpzqBYWi7ozXzTJUfV4LRIbAURSw65cCHm87eYU7NQDQSB/74pYqW/Hd8H2wIEzAltPO O5rLj/ImVTs/IGsop57ANcrKaB4MQXja5/Ilf2QKkBwT9cGT/j36Fr9I5sB71ndswxM9 PFBsNWxeOuUF9bw5yaDde46mHiU5OeSJnb3giNxJVr1XeiRacj9P5l+mRJcJ6GDQqjGQ gHwQ== X-Gm-Message-State: AJIora9MJefUAdeVLezGMr0mLZpoRwrxNZhWwsV+VlZ29XMofn59XAFK 3nForiGLREPWYXYplubbGBQ= X-Google-Smtp-Source: AGRyM1s2gNITsoNvvWqhw42ZjnGoUjk5hatldjfhanweOVG0NP3tYAYgGUxPfKOmBqQ6ki95Tu0lgw== X-Received: by 2002:a63:6e44:0:b0:40c:73a7:b6c9 with SMTP id j65-20020a636e44000000b0040c73a7b6c9mr2827190pgc.285.1656505916824; Wed, 29 Jun 2022 05:31:56 -0700 (PDT) Original-Received: from localhost ([155.94.207.39]) by smtp.gmail.com with ESMTPSA id gz4-20020a17090b0ec400b001ec4f258028sm1936481pjb.55.2022.06.29.05.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 05:31:56 -0700 (PDT) In-Reply-To: <87fsjnlqrh.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235632 Archived-At: Lars Ingebrigtsen writes: > Ihor Radchenko writes: > >> This is exactly the problem at hand. I was hoping to find a fast way to >> detect if a large deeply nested object is changed. If not, do not print >> that object for the purpose of saving it to disk cache. Printing can >> take up to 2-3 seconds in some cases. > > I think you basically have to restructure the code to add a guard to > whatever's updating the structure to see whether it's "dirty" or not. This is only possible when I have access to the code making changes to the object. The original idea was to detect changed objects in most generic way, as a part of persistent storage library. Oh well. Best, Ihor