unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Andrea Greselin <greselin.andrea@gmail.com>
Cc: 53773@debbugs.gnu.org
Subject: bug#53773: 27.2; Flyspell delays region overlay update when the region is overwritten
Date: Wed, 03 Aug 2022 13:17:31 +0200	[thread overview]
Message-ID: <87iln9vano.fsf@gnus.org> (raw)
In-Reply-To: <CAJ_oJbZP60cz=2DH_vCJJSoNpVfNgK6wsaTmHTw8NbtZw8pCCw@mail.gmail.com> (Andrea Greselin's message of "Tue, 2 Aug 2022 18:11:57 +0200")

Andrea Greselin <greselin.andrea@gmail.com> writes:

> Issuing a ‘(deactivate-mark)’ right before the line
>
>   (and (not unread-command-events)
>
> solves the problem but I don't know if it has any unwanted side
> effects or if it's a good way to go about it. By the way this bug
> also affects Emacs 28.1.

So the proposed change is the patch below, but I'm not really familiar
with this code.  Anybody have any comments?

diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
index 2c5e30fecd..883137d5bd 100644
--- a/lisp/textmodes/flyspell.el
+++ b/lisp/textmodes/flyspell.el
@@ -856,6 +856,7 @@ flyspell-check-word-p
        ((get this-command 'flyspell-delayed)
 	;; The current command is not delayed, that
 	;; is that we must check the word now.
+        (deactivate-mark)
 	(and (not unread-command-events)
 	     (sit-for flyspell-delay)))
        (t t)))






  reply	other threads:[~2022-08-03 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 10:00 bug#53773: 27.2; Flyspell delays region overlay update when the region is overwritten Andrea Greselin
2022-08-02 16:11 ` Andrea Greselin
2022-08-03 11:17   ` Lars Ingebrigtsen [this message]
2022-08-03 12:30     ` Eli Zaretskii
2022-08-04  6:16       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iln9vano.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=53773@debbugs.gnu.org \
    --cc=greselin.andrea@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).