From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Thu, 13 Oct 2022 22:05:52 +0000 Message-ID: <87ilknidkv.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <877d1d6rcy.fsf@gmail.com> <867d1cjc8w.fsf@mail.linkov.net> <87o7unkggk.fsf@posteo.net> <86edvids93.fsf@mail.linkov.net> <87zge52nx0.fsf@posteo.net> <86sfjvqz68.fsf@mail.linkov.net> <87edvecg45.fsf@posteo.net> <86r0ze2ldb.fsf@mail.linkov.net> <871qrchzli.fsf@posteo.net> <86tu471vhq.fsf@mail.linkov.net> <875ygnjyp0.fsf@posteo.net> <87mt9zii8w.fsf@posteo.net> <831qrba2g1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3530"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 57400@debbugs.gnu.org, ane@iki.fi, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 14 00:25:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oj6e3-0000lk-Rx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 00:25:39 +0200 Original-Received: from localhost ([::1]:49376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oj6e2-00016e-S1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 18:25:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj6M2-0007Cv-I4 for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 18:07:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oj6M2-0008TI-9A for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 18:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oj6M1-0007XA-Ul for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 18:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 22:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166569876828886 (code B ref 57400); Thu, 13 Oct 2022 22:07:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 13 Oct 2022 22:06:08 +0000 Original-Received: from localhost ([127.0.0.1]:35218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj6LA-0007Vp-89 for submit@debbugs.gnu.org; Thu, 13 Oct 2022 18:06:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:34519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj6L5-0007V7-0D for 57400@debbugs.gnu.org; Thu, 13 Oct 2022 18:06:06 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E0CBE240103 for <57400@debbugs.gnu.org>; Fri, 14 Oct 2022 00:05:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665698756; bh=beQkG8CMGROXeE1f7009uZNc42+WMMG9+vnAvkxhrus=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=lQaXjUfS5AmrIAP8qO27LvaIBoGfYiM8nJRKa7hDKLDMDo22bVCIIV98AvcJwPuRv HWyYWuVSjm8SQzX95bD2Vujnrfw+ViDWgpIz9xfrTPGkhKijIA04BrGCmkBiBHYPKH j7w/O1i2oBd2KAK7sqBZCTGV2rXlf2GrU3EXyr5Su82aNahnI90fB2xqitjjWMUfHe jD/Zha8nv9QfzcxXXThQ/khD9tehK2ed4paGH+RDUiYKKASgEcasrAx16XKdagaiD4 pBmtrx1Q2eqSuRdgZuhENw5NHnHnoZV50JymsMYwD4T6S7i+x5Rww28gRF3XgZrbAB lYNMkP/yZfPfA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MpNrK2RyHz9rxL; Fri, 14 Oct 2022 00:05:53 +0200 (CEST) In-Reply-To: <831qrba2g1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Oct 2022 23:33:34 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245359 Archived-At: Eli Zaretskii writes: >> Cc: Robert Pluim , 57400@debbugs.gnu.org, >> Antoine Kalmbach >> From: Philip Kaludercic >> Date: Thu, 13 Oct 2022 20:25:03 +0000 >> >> -(defun vc-git-symbolic-commit (commit) >> +(defun vc-git-symbolic-commit (commit &optional force) >> "Translate COMMIT string into symbolic form. >> -Returns nil if not possible." >> +Returns nil if not possible. > > And if possible? I guess the first sentence lacks something it should > say about that? (Also, we use "Return", not "Returns", to be > consistent with "Translate".) > >> If the optional argument FORCE is >> +non-nil, revisions containing positional >> +arguments (e.g. \"master~8\") will also be accepted." > > It is not a good idea to use "also" when you didn't explain before > that what this does without FORCE. (Maybe this should be part of the > explanation of what you mean by "not possible" above?) > > Also, there's a passive tense here... (This is getting embarrassing...) > And finally, you use "positional arguments", but "man gitrevisions" > doesn't use this term at all. So maybe we should use a more accepted > terminology, or at least provide more than just one example to explain > that via the examples? > > Thanks. I've rewritten the entire thing, how does this sound: "Translate COMMIT string into symbolic form. A symbolic form is any revision that is not expressed in using SHA-1 object name. If the optional argument FORCE is non-nil, this might include revision specifications like \"master~8\" (the 8th parent of the commit that \"master\" is currently pointing to). If it is not possible to determine a symbolic commit, the function returns nil."