From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#58893: 29.0.50; Feedback on Eglot manual Date: Sun, 06 Nov 2022 20:15:37 +0100 Message-ID: <87iljrhp2e.fsf@betli.tmit.bme.hu> References: <874jvlk5pm.fsf@betli.tmit.bme.hu> <83o7ttfvto.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2952"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Eli Zaretskii , 58893@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 06 20:16:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orl8I-0000bl-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Nov 2022 20:16:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orl7k-000860-Q1; Sun, 06 Nov 2022 14:16:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orl7i-00085J-Eu for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 14:16:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orl7i-0006kN-6q for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 14:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orl7i-0007Jl-1n for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 14:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Nov 2022 19:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58893 X-GNU-PR-Package: emacs Original-Received: via spool by 58893-submit@debbugs.gnu.org id=B58893.166776214728105 (code B ref 58893); Sun, 06 Nov 2022 19:16:02 +0000 Original-Received: (at 58893) by debbugs.gnu.org; 6 Nov 2022 19:15:47 +0000 Original-Received: from localhost ([127.0.0.1]:60611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orl7S-0007JF-Ph for submit@debbugs.gnu.org; Sun, 06 Nov 2022 14:15:46 -0500 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:42587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orl7R-0007J1-3G for 58893@debbugs.gnu.org; Sun, 06 Nov 2022 14:15:45 -0500 Original-Received: by mail-wr1-f47.google.com with SMTP id cl5so13434305wrb.9 for <58893@debbugs.gnu.org>; Sun, 06 Nov 2022 11:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=0cxZ+lhIxKlPFuGsdydkoqhXBgLuNcfSenkd9xj4fuw=; b=XFsQfOP6h6aAv+z0tyZqiaDTK/4ySA0bRrspeNdet0KweZ31AdpZVqeAIpy/rvoU2x MQC+cuq3gMOyGx3kzNO9n/tvq0gzAy+IURrkyefuPkcKkNIH6LIc7uU1p3krUtaPSQnw uxVgWIWla1CnCwMg697GUxsbPHj0CeDxumqTU254rkFV7K/3wpX9lkgR5hRgaE+sLBar sI65i7IzLME/916Oct3qPOEd4u4U/DKCLSgXw/+LaZBlF3b9LQ463Cks6TQXeZvYOhMy kIksN6TTgh5bViO1YGczkkcGZEkg+6bTS7tHIap237Vk9rJCCmes2Y4/5qz9uubsryhb UvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0cxZ+lhIxKlPFuGsdydkoqhXBgLuNcfSenkd9xj4fuw=; b=avuepH8LRFPJCljhF5y0bxz2RcN1kvX72DQZCWIVM5oegBPRER2eNNZQNAyGwRk54L o4KRe0dQdC3seiMk50Xe0bVQ73SEG6IZOIONXohsz0YdgwC0KlsyaCMQK32goELY608i BQhnPmMcd481mc0HiOCFCwQpH6uE9utOHq3TU33FmR7wuSe7Jr1CBxFrNySNSlcbwjQM HJnvPV+L1I+elZTSvk1piRNujjo/5shNXxqJEMsGhv3zYxRZ34o7pWpLiWP7q0O7o8As 3CAlsS53i9futHbMH9exlvu1a2CVqEyOe7nLHkHEScyBqP6KwiH+AvcXyU2MI7fgnsY/ w1Ow== X-Gm-Message-State: ACrzQf2upcFPXup2tg5ZGlLbMste5NkfDz0Z94Yj0EE4FBjT0JiAt4Ix v7pXgANKtltJEF5JogKgIWRjuvoq4iU= X-Google-Smtp-Source: AMsMyM4ssZ1/OqGLFCX6Zw0wU/f9VeJB1VAXyvM3wmTrf6C/rDNS31mC7nKukgL6r0C4q+mI5y58hQ== X-Received: by 2002:a5d:64c3:0:b0:236:695d:39f7 with SMTP id f3-20020a5d64c3000000b00236695d39f7mr30061727wri.614.1667762138911; Sun, 06 Nov 2022 11:15:38 -0800 (PST) Original-Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id j22-20020a05600c1c1600b003a6125562e1sm6254527wms.46.2022.11.06.11.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 11:15:38 -0800 (PST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 2 Nov 2022 08:26:00 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247233 Archived-At: >> > * Snippet completion >> > >> > Yasnippet should be enabled in the current buffer before Eglot connects >> > to the LSP server. > > Felici=C3=A1n, are you sure? If that's true, then I think it's a bug. I > don't want users to have to remember this. So I think the current > gist "just install yasnippet" should be enough. Eglot does not enable yasnippet mode anywhere. eglot--snippet-expansion-fn only checks whether yas-minor-mode/yas-global-mode is enabled. So if it is considered as a bug, then I think the fix is to make eglot--snippet-expansion-fn and eglot--managed-mode turn yas-minor-mode on when it is available and yasnippet is not in eglot-stay-out-of.