From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#60722: 30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil Date: Sun, 15 Jan 2023 10:23:44 +0100 Message-ID: <87ilh8p2vz.fsf@gmx.de> References: <87eds1za8a.fsf@gmx.de> <87zgapcgtw.fsf@gmx.de> <0ecbefc7-ea79-d172-5e84-58368870b818@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30153"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60722@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 15 10:24:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGzFf-0007kX-9C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Jan 2023 10:24:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGzFH-0001fJ-Bs; Sun, 15 Jan 2023 04:24:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGzFG-0001dR-88 for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 04:24:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGzFD-0004mR-9K for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 04:24:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGzFD-0003Wk-18 for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 04:24:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Jan 2023 09:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60722 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60722-submit@debbugs.gnu.org id=B60722.167377463713511 (code B ref 60722); Sun, 15 Jan 2023 09:24:02 +0000 Original-Received: (at 60722) by debbugs.gnu.org; 15 Jan 2023 09:23:57 +0000 Original-Received: from localhost ([127.0.0.1]:56100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGzF6-0003Vr-Iu for submit@debbugs.gnu.org; Sun, 15 Jan 2023 04:23:56 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:35571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGzF3-0003Vb-KC for 60722@debbugs.gnu.org; Sun, 15 Jan 2023 04:23:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1673774626; bh=NbmawQoYfUS3yOcJA+Dw+/Bi/GLEahcixGsJXFYzKI0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=rcGrpUp3ongCTuVAmPFxqacYCr82Hw8OZPYhX2gvdOMEnloAntdg3cpkCS2zVfqIf 4L9Uke6TzsarC1BuGu5ahYQnrJ/uPT0vkXu/yBkMTilmBlGfBRJahOchgfP7qhcJm5 4IwgJKY8Ic3JjXktb9DMUiL+VUgvnAhtMjUK0ZxmK3uatwxttUqXv9j6vSjq9R2hp+ KUVmo1ZeQpNT15dRzpBlIileJm9r7+T99Vy0BjnGulNN7dpl5s441uSFS8RGjI+gIq WJrEBsOZodryeuwKlZ+VbQdd9qJ7MrX98E/gOjJVVgEZOxn4lxOki9P1b2S7JYBXkV rHx2YYS/cj+8A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.37.45]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6Db0-1pNc1C2pYW-006jZY; Sun, 15 Jan 2023 10:23:46 +0100 In-Reply-To: (Jim Porter's message of "Sat, 14 Jan 2023 14:10:27 -0800") X-Provags-ID: V03:K1:nIfRgQmA2orWMkys370dfu8p0/rfgddYaQY5WZO84jsoxowG0vX SQhvvrcdoUWlWHLzPQ9/FQQC4nOQww1unkLLi6DiJDsmaaQ0qq5GGA3m2y7n1bU5feEkBA3 cBTF8r7NTe9FlTdwotqRSdnVh0KJZf8IMa5CAIUHCcF63p6gvRNY+R0CXosJ4L7Zs/lOuHq rC8FUsUF+YVcnpUQpVXDg== UI-OutboundReport: notjunk:1;M01:P0:BE8EwbNhm1U=;RyMKpbZgHCWD8BP5mauGTyUt6F2 +LtNTysMAoJk9Qrgn4sAUR+Qs/Z1lGjuSVA0aV4/STQ9nz2Y5ndHlqT480715s8fgBCRYOk5d mgqd6p8DWtfKyvPAXo2RwTUS1qwkBP69jA2WsTBgYtdUgjx/x1TRZnHYLOwRjtPqerUNg3sSj PcbUYB300age9X7uS9Ke6C8aq+AmCQ4fA4VH42itFONmmExxCK2z4RCIVtUs9wPN6UeTKxh6i tvXXbvGVzZ5vd1ExI2CjHABy/yYHpdYkvkciKq8+0hzXVat9/xCjj2xrGS6KXjDa0XpLx9bNx gPeOrcn6tfwoL0rzsnO38HgM75xmlMCJbanjrVWitHn0hDTHwYF5bSd2Friw4VGofsZ5sVT4q Gxnw0FVEKTU367sHAdnq7G7Z+Cmv89khFq6DrRrN4IpIerx2FG7hXphYwm7quq4zJXmoAm8ic Z6lqrXNt684hdPqfPVfRJuVv4I11MSq6suycrZEO9Vs5J+1Z4iqA1afY4eCa0va2+uijcE1jZ FX3e1adDqLq5I+rZFNHW8BcxaAcCpmyrtnBcc1iEgp8vYbsZ+6XBfvvsInZhkakdFTguPyUQ0 e4aT4hYZDaObJ4pXjHi28F02avosodp0xnYockSg72wZZ+WM8ypoTtDgwFYBOioh7Bi+Yrhy0 0NtU4BEXJl5R56coTeg4i8yaMLLVTe3sKTnE+ybRd15OpzQNNgSUrA4Bm4kcTqqCqYwk9uZKc h3kl9Pm0QLjRYsFZI9RwMAKl/shccnviEMHlxnDPW4/5q8WtLlNZUazAcTb3Dtfqc80QyGf1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253415 Archived-At: Jim Porter writes: Hi Jim, >> Finally, I added documentation to the manuals. I didn't add any >> Tramp regression tests though, since I wasn't sure of the right way >> to test this. > > Oops. I missed an "@end defun" in the manual. Fixed. Thanks. LGTM. Don't care about the tests, I'll add them once your patch has arrived Emacs master. One question is left for me: do we really need FILENAME as argument? I believe it would be sufficient to check default-directory; this would also be consistent with the functions for remote hosts described in os.texi. Btw, another idea is to simplify the implementation. Let Tramp set a connection-local variable `tramp-user-uid' or alike, and your function `remote-user-uid' or however you rename it will ask for this connection-local variable, like we do it already in functions `null-device' and `path-separator'. This would avoid the overhead of running the file name handler mechanism. WDYT? Best regards, Michael.