From: Sean Whitton <spwhitton@spwhitton.name>
To: 61539@debbugs.gnu.org
Cc: cohen@bu.edu
Subject: bug#61539: 29.0.60; When nnselect-always-regenerate, group info gets out-of-date
Date: Sat, 18 Feb 2023 13:20:25 -0700 [thread overview]
Message-ID: <87ilfy3euu.fsf@melete.silentflame.com> (raw)
In-Reply-To: <87lekyaeyh.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 15 Feb 2023 12:47:18 -0700")
control: tag -1 + patch
Hello,
On Wed 15 Feb 2023 at 12:47PM -07, Sean Whitton wrote:
> 1. Same setup described in #56592, but additionally set
> nnselect-always-regenerate to t for the groups.
> 2. Enter group. Mark an unread article as read.
>
> (length gnus-newsgroup-selection) => 935
> (car (last (gnus-info-read (gnus-get-info gnus-newsgroup-name))))
> => (930 . 935)
>
> 3. Exit group. Enter group again.
>
> (length gnus-newsgroup-selection) => 934
> (car (last (gnus-info-read (gnus-get-info gnus-newsgroup-name))))
> => (930 . 935)
>
> 4. Attempt to exit group again. Then, while binding select-reads at the
> beginning of nnselect-push-info, nnselect-categorize signals
> args-out-of-range, because one of the inline functions it calls
> attempts to read the 935th element of gnus-newsgroup-selection.
Andrew Cohen sent me the following fix. I've asked him whether he
thinks this is safe enough for emacs-29.
-- >8 --
From: Andrew Cohen <cohen@bu.edu>
diff --git a/lisp/gnus/nnselect.el b/lisp/gnus/nnselect.el
index 87cb1275313..516433aba93 100644
--- a/lisp/gnus/nnselect.el
+++ b/lisp/gnus/nnselect.el
@@ -350,9 +350,9 @@ nnselect-request-group
;; the result.
(unless nnselect-artlist
(nnselect-store-artlist group
- (setq nnselect-artlist (nnselect-generate-artlist group)))
+ (setq nnselect-artlist (nnselect-generate-artlist group))))
(nnselect-request-update-info
- group (or info (gnus-get-info group))))
+ group (or info (gnus-get-info group)))
(if (zerop (setq length (nnselect-artlist-length nnselect-artlist)))
(progn
(nnheader-report 'nnselect "Selection produced empty results.")
@@ -880,11 +880,13 @@ nnselect-search-thread
-(defun nnselect-push-info (group)
+(defun nnselect-push-info (_group)
"Copy mark-lists from GROUP to the originating groups."
(let ((select-unreads (numbers-by-group gnus-newsgroup-unreads))
(select-reads (numbers-by-group
- (gnus-info-read (gnus-get-info group)) 'range))
+ (gnus-sorted-difference gnus-newsgroup-articles
+ gnus-newsgroup-unreads)
+ 'range))
(select-unseen (numbers-by-group gnus-newsgroup-unseen))
(gnus-newsgroup-active nil) mark-list)
;; collect the set of marked article lists categorized by
--
Sean Whitton
next prev parent reply other threads:[~2023-02-18 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 19:47 bug#61539: 29.0.60; When nnselect-always-regenerate, group info gets out-of-date Sean Whitton
2023-02-18 20:20 ` Sean Whitton [this message]
2023-03-11 21:18 ` Sean Whitton
2023-09-04 19:46 ` stefankangas
2023-09-04 23:21 ` Andrew Cohen
2023-09-05 6:16 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilfy3euu.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=61539@debbugs.gnu.org \
--cc=cohen@bu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).