From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#61730: 30.0.50; Compiler warnings for delq and delete Date: Thu, 23 Feb 2023 11:29:25 +0100 Message-ID: <87ilfsisje.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8735"; mail-complaints-to="usenet@ciao.gmane.io" To: 61730@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 23 11:30:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pV8rp-0002AA-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Feb 2023 11:30:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pV8rU-0006LW-Nw; Thu, 23 Feb 2023 05:30:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV8rT-0006Kg-1e for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 05:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pV8rS-0004J8-JB for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 05:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pV8rS-00067G-0f for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 05:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Feb 2023 10:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61730 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167714817523420 (code B ref -1); Thu, 23 Feb 2023 10:30:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Feb 2023 10:29:35 +0000 Original-Received: from localhost ([127.0.0.1]:33082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV8r1-00065g-FN for submit@debbugs.gnu.org; Thu, 23 Feb 2023 05:29:35 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV8qy-00065Y-UB for submit@debbugs.gnu.org; Thu, 23 Feb 2023 05:29:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV8qy-00069a-Ku for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 05:29:32 -0500 Original-Received: from mout.web.de ([212.227.15.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV8qw-0004GW-Vw for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 05:29:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677148168; i=michael_heerdegen@web.de; bh=Gm0W8PWHyYguGkg5ccsotBDDE/XZRvj8PGOmrawbnmA=; h=X-UI-Sender-Class:From:To:Subject:Date; b=D7yY+SYLjC9E34HuRm96poAOeqgC6Ldv/RecJM8E9gzuvJlZ7W7+vFkQr8LN40cVR k36EEik5u7EIh7a/JUVd/uADQjrDx+2iptrvf9iI38S8uyeI601/MzZ9qRHEucdBfu JIAtiS97ymAryacq9XmGXJeFXlT2fngkAadOWspxPAKLkKe9/+dfkYdBkG9hgC4w/p U0Zk9SxPO0NqVsldd/VZYv16dNN0++ygOOhSZLwvsUjBg/ffwzMSXTcJZA189MtqKp 1NlaWQDR06/8w8r0kww03By2aY+mM9okm7LXYBbnLAWZhanMsbPSpgdWdPPodRAFLC 9P0LnKW546ylA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mc1ZT-1owNCK3OYB-00daQB for ; Thu, 23 Feb 2023 11:29:27 +0100 X-Provags-ID: V03:K1:18dyQULZ2Y5sLk2Rx0jrIMy5UqY8u5CSpX5idCcI6oNq7TY3Ohd 9wR+0zhThu/xRbOt3bXli52DA0C17KFSNX+bBMDvmgycfr9aJtp3IvitqkKMtxC75AAt4Vh /TqL+kfboFxbzSUUaarrQexswDpno5TeIWbULWZ0KNYtwbgESYzGa+BixMR031WO6xRjN4V iKryzm16x1//KchdNG5iQ== UI-OutboundReport: notjunk:1;M01:P0:QozTabbUJtM=;fJe5golr36m9lDQR1cfY06QOOHT nUHObFe2Fh6DP1R45fgT17p1uKbffJT5USkXbC7KpCq47wQWKh4Ksa6nSvnPDxr9kqZFNyYSO h619pO+egdRbI0/leueAgRukk+yS+4p8ZHm0zWkpPAtNjx8S83MnADlb7jHSxs3JlnWz9X4Dj V5AY19WmqQnbpswQaZ0bIp08lx6chtPPHT52c2Q1xkfmVW47vF/Y0zRs9YQneF23K5B4fOkRb 77IqNmvCyzz4D4CzjDIy+psZA1T05zUu4XAYzpZu8rG/fjGVSwS1j65GSgiDyhmhIRnJbQEb3 WOW1pSd1i3Q7HHOI6e7xZaGVpq5rN3UbIowYOBXSBvMpcP27FXTXNSfg0xxz4veE0CjcOl6Ss d5Yp8/nKIXvDdIP23bynZISc2I8o37gBFjm9xzlq8+b6WaNb8mGJrVOw5G58mYcbPDfMQwsFS C7pRBia3lK0HhKIhOXCCVEYwagxMTZWW4T8ePLycNkL+rROr9V5S6rLIbgOQrkzhYFyQLnV+v J9RbGlwrYntvYMoDOy7uLbh+lyHMNVGMXMFLl0FCrD5EoLdYvNj8vunfAAOnO73CJ+FBkxvB5 nHMFm6uMqH4t7gAk3ZiuINg1BBuFR+a81IHlT9Fvj7onaqmXYePS3T9BOFvvrOLBxNIHGf189 e49S0Yi6QYvCmkPqXc+kh6Kv0sjGAO2jFsyj7g4aUMFFkqBrgDRSuHdAVxZakyk3m+UZtlFmI xpKIP684ldo7iZowbwv546xEdqnM+t8yTkAKvIDod/ST8ZZBXpnZdLmJYd2PuhX7D9RysiXl Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256437 Archived-At: Hello, I think we should add compiler warnings for `delete' and `delq' function calls whose return values are unused. Those are most likely unintended: still some programmers don't know that the return value must be assigned back because the destructive operation on the original list structure does not necessarily lead to the return value. It's a pitfall and can lead to bugs that are hard to debug, so having warnings would be an improvement. I think the warnings could be added in a similar way as the "mapcar called for effect" warnings work. Adding the same kind of warning for `remq' and `remove' would probably also be useful. This will probably not occur that often but it still would be useful I think. TIA, Michael.