From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#62207: 29.0.60; Trying to remove non-existent key binding instead adds a binding Date: Fri, 17 Mar 2023 09:54:05 +0100 Message-ID: <87ilezu5aq.fsf@gmail.com> References: <875yb2gfqp.fsf@bernoul.li> <83pm9aq6of.fsf@gnu.org> <83ttyjeqgm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62207@debbugs.gnu.org, larsi@gnus.org, jonas@bernoul.li, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 17 09:55:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd5rz-0003j1-7n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Mar 2023 09:55:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd5rd-0003aL-75; Fri, 17 Mar 2023 04:55:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd5rb-0003Zt-8o for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 04:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd5ra-0000VG-U7 for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 04:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pd5ra-000067-EP for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 04:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2023 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62207 X-GNU-PR-Package: emacs Original-Received: via spool by 62207-submit@debbugs.gnu.org id=B62207.1679043256313 (code B ref 62207); Fri, 17 Mar 2023 08:55:02 +0000 Original-Received: (at 62207) by debbugs.gnu.org; 17 Mar 2023 08:54:16 +0000 Original-Received: from localhost ([127.0.0.1]:43643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5qp-00004x-Us for submit@debbugs.gnu.org; Fri, 17 Mar 2023 04:54:16 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:42731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5qn-0008WO-LT for 62207@debbugs.gnu.org; Fri, 17 Mar 2023 04:54:14 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id o11-20020a05600c4fcb00b003eb33ea29a8so2800283wmq.1 for <62207@debbugs.gnu.org>; Fri, 17 Mar 2023 01:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679043247; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=xt70AXRp04V95Nm0NGXWpC6nBv1ULf/Iy3gpwulzKZc=; b=MS/WBU9zBILAwBx3qPD7FJFB300LnlLJ1oHSvOLwHgumiAh20GtMHLFIAwFn6ggQfK ol4G0HYdunIbkjUQNaXx2odZQHXXloQ8HpC6m0rND6MJHPthFtY8uTcUjuJJd3VwLc5a ctGJmsximUI8HWTPBz3hlSJ0lzP5e3XmZxF7aQEzLG+P7MZcBrO8IH8FLUuzD0MUiQZt qfWJf+sUDZs15ZeWDDpCSDP39v8Kb+zOEi2Nb9nvJv4DCKKwVufRxaUSOxYnmb7LXv3R YVlvNL4tW4/3tNvAs31Lgd4xvZKaPrUlkm9VPadgP3Fup9TyfR27knZx+LV+TC5OPY6g O9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679043247; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xt70AXRp04V95Nm0NGXWpC6nBv1ULf/Iy3gpwulzKZc=; b=4CyGke0N4IGFhpWefKhlqVC5EpqOrt6nV545PUsw8/R/iGrKLc9uhJcUJK64iCm9M1 6QafqC1GxlwE9NM5f3wm3ZQGuwWhbV4WX2m8SRweLGno0Vq3h8+I+eXe8YkqsR26oV17 PBXcSVQYPR00Be1VrOt9dpKR3Os3lBzYCN5AphKCaHruLTvsmg9E52WpvYXnQYgskcD6 jf1wE9OXWBKdyII0uPFGn7dCE62kMPQpkHNU9m0eJx1/vJj44ogCgrpubFImMxZ5jVST StmBtsfg7Ns0Q1OLChDPDTNjVdOT93NYJy+/xz+3atbyb4qpjQ83pspffEFYwd0v86gv oCIQ== X-Gm-Message-State: AO0yUKWoHCqEiCToQegFgKPVqdtsLd4a11SNO3Iue5a/3/NchY3AQk4n cA/KEvsfnzWgvi1fTHfjB/HMiJ/9/OY= X-Google-Smtp-Source: AK7set+XDOCtx5HuDam9nItSYkGhMaVpgE94WSu5Ebe9tyxGljGAZfpc6QQy4V7GhTcLRqk0K+S3EA== X-Received: by 2002:a05:600c:4ecf:b0:3eb:29fe:70ec with SMTP id g15-20020a05600c4ecf00b003eb29fe70ecmr26328919wmq.27.1679043246983; Fri, 17 Mar 2023 01:54:06 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id u13-20020a7bc04d000000b003eb0d6f48f3sm7189194wmc.27.2023.03.17.01.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 01:54:06 -0700 (PDT) In-Reply-To: <83ttyjeqgm.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Mar 2023 10:23:37 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258061 Archived-At: >>>>> On Fri, 17 Mar 2023 10:23:37 +0200, Eli Zaretskii said: >> From: Stefan Monnier >> Cc: Jonas Bernoulli , Lars Ingebrigtsen , >> 62207@debbugs.gnu.org >> Date: Wed, 15 Mar 2023 14:02:59 -0400 >>=20 >> > Stefan, it sounds like the part of store_in_keymap after the label >> > keymap_end should do nothing if REMOVE is non-zero, am I right? >>=20 >> Sounds right, yes. Eli> Then Robert, please install on the emacs-29 branch the part of your Eli> suggested patch which fixes the problem with REMOVE. The other pa= rt Eli> should go to master, I think. The former I can do. Stefan seemed to object to the other part. It=CA=BCs also not been tested a great deal =F0=9F=98=80 >> This said, the semantics of REMOVE a bit murky, so I'd rather tell >> people not to use it. Eli> Robert, could you please say something to this effect in the doc Eli> string? Sorry to be difficult, but why? I think the semantics are clear, although I=CA=BCd prefer it if the first line of the docstring for `keymap-unset' said Unset key sequence KEY in KEYMAP. to reduce confusion with the REMOVE argument. Robert --=20