From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Date: Fri, 05 May 2023 22:41:22 -0700 Message-ID: <87ild6vwxp.fsf@ericabrahamsen.net> References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9522"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 07:42:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvAga-0002I4-AH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 07:42:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvAgH-0000jo-Km; Sat, 06 May 2023 01:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvAgE-0000jW-33 for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 01:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvAgD-0002L5-Qr for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 01:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvAgD-0000k1-MW for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 01:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 05:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs Original-Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16833516952815 (code B ref 62845); Sat, 06 May 2023 05:42:01 +0000 Original-Received: (at 62845) by debbugs.gnu.org; 6 May 2023 05:41:35 +0000 Original-Received: from localhost ([127.0.0.1]:58032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvAfn-0000jL-BM for submit@debbugs.gnu.org; Sat, 06 May 2023 01:41:35 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:42482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvAfj-0000j6-Vw for 62845@debbugs.gnu.org; Sat, 06 May 2023 01:41:34 -0400 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 77AEAFA01F; Sat, 6 May 2023 05:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683351683; bh=EuO8YayRsrrFxJcC1VhYw5tnD2VilnGW9INbihBDL+w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VdkGpR3R7+fjE73OnySEjxxkeO2Ok2PnWu6FiPYvUcCIkjiuzaCN9K8iCpEyE1qZs 4v9AdnhxVPcRtqhvXGqkYURe8E5RG5LNm8ZDwzkYH5g7EvXWE/GKJCXeINK1SRRWup +Qpq8j4SSjpoX5dcHvEGNnUjXj5Ad9c0cIfKI/HE= In-Reply-To: <87y1m2w2s5.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 05 May 2023 20:35:06 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261154 Archived-At: Eric Abrahamsen writes: > Eric Abrahamsen writes: > >> Eli Zaretskii writes: >> >>>> From: Eric Abrahamsen >>>> Cc: Eli Zaretskii , 62845@debbugs.gnu.org >>>> Date: Wed, 26 Apr 2023 20:08:53 -0700 >>>> >>>> Andreas Schwab writes: >>>> >>>> > commit 032969e8c65 "Don't have nntp-report signal an error" >>>> >>>> Ooh, I knew this would end up being me. Give me a couple of days, it >>>> might not be the weekend before I have time to dig through this. >>> >>> Eric, >>> >>> Any progress? I'd like to make another pretest of Emacs 29 soon, and >>> I'm waiting for this fix. TIA. > > [...] > >> Other code in this library checks if the timer has killed the process >> buffer in the meantime. There's probably a safe solution in here >> somewhere, but if you're looking for a reliable regression fix to >> include in Emacs 29, it's probably best just to revert 032969e8c65. That >> behavior is annoying, but at least not buggy. > > Looking more closely at this, there's already a mechanism for throwing > out of the `nntp-with-open-group' wrapper: if `nntp--report-1' is t, > then `nntp-report' should throw the appropriate symbol and we'd get the > desired effect of canceling this server connection, without raising a > top-level error. > > `nntp--report-1' should be non-nil in the case, I'll try to figure out > why it isn't working. The answer is, that mechanism is designed to work only once. If the connection is dead or times out, it catches that condition once and tries to re-connect, and won't catch it a second time. So we'd have to be hitting the timeout twice in a row to see this (which definitely happens). I still think it's best just to revert 032969e8c65 on Emacs 29.