unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>,
	Wang Diancheng <dianchengwang@gmail.com>,
	Yuan Fu <casouri@gmail.com>
Cc: 64818@debbugs.gnu.org
Subject: bug#64818: 30.0.50; c++-ts-mode highlight does not work
Date: Mon, 24 Jul 2023 15:26:36 +0200	[thread overview]
Message-ID: <87ila9sann.fsf@thornhill.no> (raw)
In-Reply-To: <83sf9dsewi.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Wang Diancheng <dianchengwang@gmail.com>
>> Date: Mon, 24 Jul 2023 12:49:06 +0800
>> 
>> I use the latest tree-sitter and tree-sitter modules.
>> Only preprocessor instructions and comments are highlighted, please see attached
>> screenshot. BTW c-ts-mode highlight is OK.
>> 
>> Following are values of treesit-font-lock-feature-list and
>> treesit-font-lock-level:
>> 
>> treesit-font-lock-feature-list is a variable defined in ‘treesit.el’.
>> 
>> Its value is
>> ((comment definition) (keyword preprocessor string type)
>>  (assignment constant escape-sequence label literal)
>>  (bracket delimiter error function operator property variable))
>> Local in buffer sql_select.cc; global value is nil
>> 
>> treesit-font-lock-level is a variable defined in ‘treesit.el’.
>> 
>> Its value is 3
>
> Thanks.
>
> Yuan, Theo: can you please look into this?  I can confirm the above
> behavior, and I also see it in the very first pretest 29.0.90.  So
> either some change broke c++-ts-mode before April, or maybe the latest
> changes in the C++ grammar library did that.  treesit-explore-mode
> seems to show that the code is parsed correctly, so why aren't
> fontifications working?

With the version of the grammar on my system everything worked
perfectly, but I updated the grammar, and now I can reproduce. So it
seems something upstream broke it. I'll bisect tree-sitter-cpp and
figure out whats breaking it.

Thanks,
Theo





  parent reply	other threads:[~2023-07-24 13:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24  4:49 bug#64818: 30.0.50; c++-ts-mode highlight does not work Wang Diancheng
2023-07-24 11:54 ` Eli Zaretskii
2023-07-24 13:10   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-24 13:26   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-07-24 13:46     ` Eli Zaretskii
2023-07-24 14:31       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-24 16:08         ` Eli Zaretskii
     [not found]           ` <9173CE5D-08AE-4BF3-AD37-3B521845F8AC@thornhill.no>
2023-07-24 16:56             ` Eli Zaretskii
2023-07-24 17:13               ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-24 18:08                 ` Eli Zaretskii
2023-07-24 18:22                   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-16  6:14                 ` Yuan Fu
2023-07-24 20:33               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ila9sann.fsf@thornhill.no \
    --to=bug-gnu-emacs@gnu.org \
    --cc=64818@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dianchengwang@gmail.com \
    --cc=eliz@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).