From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felix Newsgroups: gmane.emacs.bugs Subject: bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk Date: Fri, 04 Aug 2023 14:43:40 +0200 Message-ID: <87il9vascg.fsf@web.de> References: <875y5wf6ti.fsf@web.de> <87y1irabhw.fsf@yahoo.com> <87tttfh9iv.fsf@web.de> <87tttfa80m.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.12; emacs 30.0.50 Cc: 65042@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 14:47:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRuDF-00045p-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 14:47:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRuCu-00038Z-EG; Fri, 04 Aug 2023 08:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRuCt-00038Q-5G for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 08:47:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRuCs-0000sb-T8 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 08:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRuCs-0003OC-B0 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 08:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felix Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 12:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65042 X-GNU-PR-Package: emacs Original-Received: via spool by 65042-submit@debbugs.gnu.org id=B65042.169115318012963 (code B ref 65042); Fri, 04 Aug 2023 12:47:02 +0000 Original-Received: (at 65042) by debbugs.gnu.org; 4 Aug 2023 12:46:20 +0000 Original-Received: from localhost ([127.0.0.1]:53554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRuCB-0003N1-Hy for submit@debbugs.gnu.org; Fri, 04 Aug 2023 08:46:19 -0400 Original-Received: from mout.web.de ([212.227.17.12]:48917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRuC7-0003Mg-UI for 65042@debbugs.gnu.org; Fri, 04 Aug 2023 08:46:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1691153167; x=1691757967; i=felix.dick@web.de; bh=lWeMTZfJIY/F7JjMN1AJfKvtDVlRFb/dnIaceeJCO6w=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=QwfxXMy45c8gVe5s1iKgyx3LyPp1kX/7SEEcHeQW7GQl+0bBx46eewddXFrbnk5fz/9z1q5 IGeXgdq3vjV+kGJ7jy2iLL63y6SWMRPN1TC/4QSFNEz1nhTmDTBul2jhRQPyC9YYt4Vq6277G R3XEV7T88YNXp/qlJJplE+RrUeoSsCsXW++ASq4AWB8Z3wJ1XUXZnfTwJ8nKA65rJY+Lli1Qq SmZxd+FcPQyZP8zTqMfG/oiAOikVGPx3kMsjJW1KaYxTYdr7mxhY/OU+QQfdRocAqIGjiKqX6 Cm2Y+R5Red89hah9FRbkEdc3dtqtWotN9bli2T/lA6JAIem36KZg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from felix-lifebooka531.web.de ([95.91.241.11]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MZjET-1qN6zo1QbX-00WWfI; Fri, 04 Aug 2023 14:46:07 +0200 In-reply-to: <87tttfa80m.fsf@yahoo.com> X-Provags-ID: V03:K1:vHvJtCBifx0598YPC0f1tRRxd77kvKst+l99LnHVZEX8b3LxoFg NzZyL3W7vbaB08j3jWmq+XwKmjUNONBVfqJ+sp96j+HlOjsv4qBNFoFqDzOcH+EKZNRlokl UA6x3SWuock2qb/CxNavb5C0hg4BxXVKXsubwVOWOIhvPgepiQqNNJg/eTaae2TNs8aT68v 46RgLzdKvAflyI52T6xmA== UI-OutboundReport: notjunk:1;M01:P0:/uV4mOf7gQ8=;eV1/GN+PnA+wS99myC1u7FgJDyY x0YuRijI/4/YGCYvgScLcq0NUvoHS+3oa3hQ1VLsBsGbt4qsbOeji06To7WCBGQe6446fRhIE P5VkHhtEOq/KCIKvBGGY/q6U1ocFe+GJ1dBXwGs0wkzN+k6NdyLpqWXkJ9w0I2HgFB+s3/7+v 80sUn5gXJu6lnskjjOb6qsmRGWll1k/+b9aQoqj1/jABaFbK0qsK3TbJ4X9/vRNXAf0QWa7oy GVHpKzJr+fn89rfkZD4bKADj5iRNZOfNOFFMhGH7lGR0ujt01zKzGCS27l0j89+FmTdcsQVxM BhUAnEbkpWQOdOujn+FRXvYvQbEMqaLZJPVrY/0WvDliQtszDXB7NKhgBOnpFUVVg22BL69rN GNRo/2qNJdtXRE8V+xyC7DYCXkcGTfVS6EIYwF9pclrHPrAefm9HqnGRYqbAsaa+5+3gCdaTG wLuiI3aYBr+q+3D28eK+oVAKVzmMcJLPKSfFdyra93HVFL5Zh5TUJ1IG+s7a/TSrLZD03zqEr +oo0R4j3QT+gpK3ZpxJ56Hgtnx/Bv4BIEzEgtrMtn83H8gfMH0sVfb7utPBl/G5ZZdGztSXUt Fo039+/L8wcoMxf148IXprhDU0EmNwIVmeuCEZ6IZx6ZX0Jplt1MMTK8TVA7tnfFa7DD04Bjy vb0gFRMaHcwaOZ0YDJZFG2X/q1MCaZQ+PSSnbJqVOZJiXtm8qth5seTwF+6mqaDDisSLRCvDs 28jmPkFN1ZC07bkrIcTmfF2ZCfxRnmFVbL+z8ZbwcpR3lZRV2gvRxuk7tz+vDjBZ2+0J2GV5 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266667 Archived-At: Po Lu writes: > Felix writes: > >> Po Lu writes: >> >>> Felix writes: >>> >>>> The background of stipple stays opaque with alpha-background parameter >>>> set for transparency. >>>> This came up in the use of the new package 'indent-bars'. >>>> The github issue: https://github.com/jdtsmith/indent-bars/issues/8 >>>> I tested this with 'emacs -Q' only enabling the needed packages (compat >>>> and indent-bars). >>> >>> Thanks. Do stipples start displaying adequately with this change? >>> >> No it doesn't. >> But it gives weird artifacts (doubling the character one >> line above or something like that) > > How about this? > > diff --git a/src/pgtkterm.c b/src/pgtkterm.c > index 9c1fc7bef4e..a7c687d811d 100644 > --- a/src/pgtkterm.c > +++ b/src/pgtkterm.c > @@ -1328,14 +1328,17 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y, > int width, int height) > { > cairo_t *cr = pgtk_begin_cr_clip (f); > + double r, g, b, a; > > + cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE); > cairo_rectangle (cr, x, y, width, height); > cairo_clip (cr); > > - double r = ((face->background >> 16) & 0xff) / 255.0; > - double g = ((face->background >> 8) & 0xff) / 255.0; > - double b = ((face->background >> 0) & 0xff) / 255.0; > - cairo_set_source_rgb (cr, r, g, b); > + r = ((face->background >> 16) & 0xff) / 255.0; > + g = ((face->background >> 8) & 0xff) / 255.0; > + b = ((face->background >> 0) & 0xff) / 255.0; > + a = f->alpha_background; > + cairo_set_source_rgba (cr, r, g, b, a); > cairo_paint (cr); > > if (face->stipple != 0) > @@ -1343,10 +1346,10 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y, > cairo_pattern_t *mask > = FRAME_DISPLAY_INFO (f)->bitmaps[face->stipple - 1].pattern; > > - double r = ((face->foreground >> 16) & 0xff) / 255.0; > - double g = ((face->foreground >> 8) & 0xff) / 255.0; > - double b = ((face->foreground >> 0) & 0xff) / 255.0; > - cairo_set_source_rgb (cr, r, g, b); > + r = ((face->foreground >> 16) & 0xff) / 255.0; > + g = ((face->foreground >> 8) & 0xff) / 255.0; > + b = ((face->foreground >> 0) & 0xff) / 255.0; > + cairo_set_source_rgba (cr, r, g, b, a); > cairo_mask (cr, mask); > } > This time it works, Thanks for this, and thanks your work on Emacs in general!