From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63511: [Patch] Fix for hidden window bug Date: Thu, 24 Aug 2023 08:12:02 +0800 Message-ID: <87il9570z1.fsf@yahoo.com> References: Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40923"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Christian Schmidt , 63511@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 02:13:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYxyP-000APZ-F5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 02:13:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYxy8-0000jg-JZ; Wed, 23 Aug 2023 20:13:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYxy7-0000ht-7Z for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 20:12:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYxy6-0008Gi-CB for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 20:12:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYxyA-0003mi-03 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 20:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 00:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63511 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63511-submit@debbugs.gnu.org id=B63511.169283594714498 (code B ref 63511); Thu, 24 Aug 2023 00:13:01 +0000 Original-Received: (at 63511) by debbugs.gnu.org; 24 Aug 2023 00:12:27 +0000 Original-Received: from localhost ([127.0.0.1]:35640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxxa-0003ll-NH for submit@debbugs.gnu.org; Wed, 23 Aug 2023 20:12:27 -0400 Original-Received: from sonic305-22.consmr.mail.ne1.yahoo.com ([66.163.185.148]:46316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxxY-0003lV-Dd for 63511@debbugs.gnu.org; Wed, 23 Aug 2023 20:12:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692835934; bh=cAWIQ8lMQPZ+aiXHJOCMusbqWxDRNVy4SyTCFx0yVAg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=bYooj8mYEsTDyZ4geJTsICeHUfcNIBGptfY8VJ4PBBSPO0OKtROHvUOGreAAVO03k/Fvux48RYuIABoM0P3V8PRrCE0AdD8gzHaQf4hvkhuiAAmIXZvvTtECIfqZe8OJoZ0cl6lq8tC+JgD5Pu6hR+6PFueK3aWqjdsBd8kyUswU6uzzgyw/LrNs0zB/kYrEmxKPDt47qwgFJgbuKTQfdkSNNYUlFwFjwX9iKh+dFJ9176YjbGtditag7giqu4/u5/q2UhMj3sXMPLauaSlkVbhIjN2IyoQ9ZYKzRFWWHkAUcqrbQILPIvSeBaCvBc1bONABZczST8lws6TjkYAZww== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692835934; bh=SCU2HRutmpx0yvShx4i/xLTtMNb2s40BESLPtnn7bAu=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=D13ihFo13L+GxjzUgtTdMnzdIE4Ffslkg7xd64/thgBwZFLKYUN4Y7RlqfSDxaTdQqJfbbhaFjTcipG8n8AzbkNEEwjsORjGLAayo3rceUEv9SslZ8sfJee1Wvj908/TArknDI0oaZfqw1C3D76y71saf9lph7WTzZ8VZvcJ/gmzFbr/krfvTl66sF36LpH5mrnV4Dv+dx1hKRD9o27/XbTiXpvL3cYFNxCKuBBbE8MScXps6JpBkUIvFZAfD9i5TVGeQTyi07IZDs+G2x1EcFG3FuFHmbGuuktSpREYylz/30+iXN6a/vd79YWC68NdDYXQ6oi7rX4uACyy084k3A== X-YMail-OSG: jZzJ4v0VM1maOkvRRKO1.SYR6bSEiU1tnNzEdMlLV5D7WLFedzFbZOoIhwUQNn_ MHjds9ovNWWR0yYi3SpOQMjbz9tEs8jAE6FpiA.G31qSX00f4SoL2B67Yl5MMmVzEswr0pTfUxAu yG4XJ8hD23ceoorA5gtanYOclMgYAgUb63Qkb6gJ.JNlM45Io5igLkOmwO1uH9Oi1TTTedNWQwTa 6cStYkMzsY8OSsUrkyKgP8f8QQIBnSKgIqXmxPISDHHAIzuYoi9wRmHuQPeU6opkdzP70feRD0vz JY99bUjewQNGumNTW7kbCsZ2oixy5BnlgZXro5Mm8WnO1EHVeMe_P7ndPXip30ZUV8wSTspH5cjY fgaHLZxpdCm7Ou5epZxElN0_1oihLjpGJGG2MhU9fJ8fF48YT0gyeXqzZKeoRrl38_is.DAOP738 sjkmQnJtaabGSDRtqMcjVvdwY6YWiFME65PUik9x1V7MDNJTc3TF7i2m8HCF6AKngZYfoxzO2mlm Kckj3F1GORcSngVJZhVqMwEBZgne8RpMUFrEKL2n0pBHoPx1WasEACsoqk7hBnjoQd0XmdUtQSjO vV3lxFDQFwLLVMKhiYBIorq4rD5rUw23T56iRPP2hx7Z46Eq2euQZXprgNPnL9MZcl8MRdkwZp74 wE4ZpdqGIUXVYEX08V9t3uhZbhT8HYFXMSQcfEC993lHWPsd8LBS1_JQsCrjPsIQyRRvUU_egy0t XU3GuCxABySU6iyIJfUG7J5ggvgE6Ano_f_ZxCXFGkApCWU11p1.H9DafYtmIrNgvXv_rLHAS2A0 z0bvYPEfvXuLyBcq_QaOt7RcSuiE0YSOPCYovMxVeJ X-Sonic-MF: X-Sonic-ID: 0080d73e-e345-4351-8d08-70e085d78e80 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Thu, 24 Aug 2023 00:12:14 +0000 Original-Received: by hermes--production-sg3-69654d8bd-752gm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6f1268fa69232363d99b2b84863ec12b; Thu, 24 Aug 2023 00:12:07 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Thu, 24 Aug 2023 01:24:11 +0200") X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268286 Archived-At: Stefan Kangas writes: > Christian Schmidt writes: > >> At least on enlightenment, when switching virtual desktop away from the >> on containing emacs and back, emacs does not render screen updates. >> This patch fixes the cause. >> Analysis for the bug tracker, copied from commit message: >> >> If no state flags are set in the _NET_WM_STATE property, >> the returned X property type will be "0". This situation >> occurs when "_NET_WM_STATE_HIDDEN" was the only property >> set for the emacs window, e.g. in enlightenment due to >> change of a virtual desktop. Does Enlightenment _remove_ the property, or merely set its type to something other than ATOM? > Po, could you take a look at this patch please. That's a bug in Enlightenment, as the type of _NET_WM_STATE should always be set to an array of atoms irrespective of its contents. If the window manager outright removes the property, clients have no means to ascertain if the window manager has relinquished control over the window, or it is still iconified by some other means (such as the traditional WM_STATE). I would prefer a check against that other property when that is the case, rather than overriding the results of the loop below.