From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Davide Masserut via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Tue, 05 Sep 2023 16:46:30 +0200 Message-ID: <87il8oodrm.fsf@mssdvd.com> References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> <8334zwa4vi.fsf@gnu.org> <87y1hokr6v.fsf@yahoo.com> <83jzt795wi.fsf@gnu.org> <87r0nflrhb.fsf@yahoo.com> <87lednqw1v.fsf@mssdvd.com> <871qffl97z.fsf@yahoo.com> <87wmx7jts3.fsf@yahoo.com> <87lednz6u8.fsf@mssdvd.com> <87edjekc1k.fsf@yahoo.com> Reply-To: Davide Masserut Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16449"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Kangas , 65509@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 05 17:13:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdXk3-00045N-N7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Sep 2023 17:13:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdXjo-0005Z7-DU; Tue, 05 Sep 2023 11:13:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdXji-0005YS-6x for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 11:13:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdXjh-0000mE-TV for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 11:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdXji-0006Rm-4Y for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 11:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Davide Masserut Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65509-submit@debbugs.gnu.org id=B65509.169392674424733 (code B ref 65509); Tue, 05 Sep 2023 15:13:02 +0000 Original-Received: (at 65509) by debbugs.gnu.org; 5 Sep 2023 15:12:24 +0000 Original-Received: from localhost ([127.0.0.1]:57819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXj5-0006Qq-UI for submit@debbugs.gnu.org; Tue, 05 Sep 2023 11:12:24 -0400 Original-Received: from out-225.mta0.migadu.com ([2001:41d0:1004:224b::e1]:51965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXj2-0006Qe-OX for 65509@debbugs.gnu.org; Tue, 05 Sep 2023 11:12:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693926738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=leG+wuafwuqgKp6u+6hP0/osB50jiwYM8BSNJSYASwc=; b=zEhXLtFMpcJRkgDoFONW/lJBYGP1O9zG9W7pFxOGnJOJMnB4+IZPtkgTMxCGWcMfP7sijC +Jy09jiuCzjVX2YkTGNwnI81SD/rzh2v/1P5C2hDQPunOysx68tbWMICEl6Rst2BIaqLHK pANVfvpi7NwbaL2DWjS6+4+6Aomm8X0Lmj5CYM3ZfhbgAKN5QbuiryM2sqrlB0Zyjn6sA5 zS7Vtf8cV9kfxlaQabqhTNDDUPJabZd8DlAudrYakWG9xIz9yaR01/GVmvIfxjjNhIPmnN yLt8u/yBV/3y6Gs2nXD2NQ3S1TRjqz1R/Nacriq1rX0IHQgkTSll6SKODzZmvw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87edjekc1k.fsf@yahoo.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269357 Archived-At: Po Lu writes: > Davide Masserut writes: > >> X DEs don't set the $WAYLAND_DISPLAY environment variable, so >> querying for it returns an empty string. >> >> If I run this in X: >> >> emacsclient --alternate-editor= --display=$WAYLAND_DISPLAY >> .emacs.el >> >> the following occurs. >> >> When the --display argument is an empty string, Emacs first tries >> to >> reuse an exiting frame and, if doesn't find one, it falls back to >> open it in the same terminal. The problem arises when an instance >> is >> launched through the DE facilities: Emacs can't use a terminal as a >> fallback and therefore it opens in the background without showing >> the >> frame. >> >> If we decide that handling such case is not worth the trouble, an >> error in system log should warn the user to use the X backend. > > I don't quite follow: if neither of the display environment > variables > are present, then Emacs deduces that no display server is running, > whereupon it resorts to displaying a TTY frame. Correct. However, that TTY is occupied by the X window manager, which hides the Emacs interface. When the argument of --display doesn't exits or is empty, should we check if $DISPLAY is present in the environment and use its value? When PGTK is enabled, we could check $WAYLAND_DISPLAY and then $DISPLAY before resorting to displaying the frame in a terminal or in a TTY. I tested this with Gnome and i3, both started from a TTY using startx. I'm not sure how this behaves when using a display manager.