From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas Newsgroups: gmane.emacs.bugs Subject: bug#65914: Exclude current buffer from eww-switch-to-buffer Date: Sat, 16 Sep 2023 06:01:53 +0530 Message-ID: <87il8bargm.fsf@gmx.net> References: <87y1ha1he8.fsf@gmx.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65914@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 16 02:33:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhJFO-0006pD-Qu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Sep 2023 02:33:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhJF3-0008Kh-En; Fri, 15 Sep 2023 20:32:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhJF1-0008KU-R9 for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 20:32:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhJF1-0007Jz-JH for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 20:32:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhJF7-0007WW-Ot for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 20:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Sep 2023 00:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65914-submit@debbugs.gnu.org id=B65914.169482434228868 (code B ref 65914); Sat, 16 Sep 2023 00:33:01 +0000 Original-Received: (at 65914) by debbugs.gnu.org; 16 Sep 2023 00:32:22 +0000 Original-Received: from localhost ([127.0.0.1]:45091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhJEQ-0007VU-8p for submit@debbugs.gnu.org; Fri, 15 Sep 2023 20:32:21 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:43415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhJEJ-0007VB-UQ for 65914@debbugs.gnu.org; Fri, 15 Sep 2023 20:32:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1694824318; x=1695429118; i=jimjoe@gmx.net; bh=Llt8meqJ+gYAmlp1weuOnyTWcvvD2AKaPHcvKL5UKGc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=AfJHSnjfPXmS+Ru0xSZGnljLK4BDwnPcZoH9F2M/emGaP2qIxkP08NrKlfDB0a/pPnU04zz8/UO 6j2KuSAoZRLP/Fc9jjElHLKsDfI4zE3wUuOX7FyzTyN/MTK9lgahiA8gwZyTETumZ5w3IUElLx524 itU00i4lGM1rRnLXpI0yYLDQxufW9tshUuYn2eQDEbcM8Vn8E7QU4bkFOMyPHduLaed9vu/5STxGV QuIgoyP2BO/djKReee5dy5HCIRw0eR0Ibadn5RWiTFKKSeZsmwwIJua6306Dfum7uDRNnvC9iyMdE I+xLjVdC9RLDdu78tT/+bUPZJdPHjuRtQz/A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-15-5518 ([59.182.118.17]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M1Ycl-1qkL5y40PT-003A0L; Sat, 16 Sep 2023 02:31:58 +0200 In-Reply-To: (Stefan Kangas's message of "Fri, 15 Sep 2023 05:05:23 -0700") X-Provags-ID: V03:K1:4knP64+7XJC8zl4bbL9NDi5lA95MnyYJP/iicn041jjj2r8JqmE A0gXsoAl//I3l0dZFOfW8fGUNlM8HQYinyvxl+w9hTy7M7ZfohflSeBKoi5yGGop63EMpwO 51oZRJ6uOzgqSnsGn9q8BufEWJuId+OfvqCvVXx0qx3AeBOPJOOHMjsNOViGeUcFoTJLGxN y/JDvH6Ka4ojYZzdj8CPg== UI-OutboundReport: notjunk:1;M01:P0:HSlaC+yY+Ng=;eR4WxshLeD38MkDWnJ0FlgF7ClW OhdpyX/jR+7djTc0ArSI2xF2PWlBub+W0jjjLk3Sr9khXXODgAJK3hDBL850IJWEiDQz1GtGd ekTHRb8wdlpbzSXDR/JPKYfrPe8smJE3ueTcmZuLW9qoXQ2stZbq1NWevQT5JPB9cV5ZLGNjZ 3EO8eB4/Q/Z4lC8zyzKS+3h3PeCWA3IDJo/mXS3w0+qCDny9tvR87eHPzwYRmfOz/KGQSpCcK ob2f169+Apt/hdV5FdDPuCc/NL6q++k95O440ggQDqJwti1gzJoHqGg4dmLXbGxV4Tg9pOqXC JFSuJ0cdlynBmezuXey29MjXq8PrdkMc8aeib+cYNR9nTpvyRvfUPB0t03193voDMqJycMte+ N5pAYfvQsrtLWbKtw7slsGomfjUuxj5X1QokB+SzcKhUIzPftM94kOwtHDNh8INH2HeNX+eUq igSqW7RlndVEWu1zQSS8J5clh07rNHG+mrv+rGYegc74TPnBZHGTBP1/FSgAUbKBxsm5QCUOW 4fqMpgknHiNtWpDe7Bl0ejX2ErpN0H6XMJOq4ccQsf7ILKk2sr6oIDdwSY2mATSTvw/IsxOHF tp9RoaGy3idrYSZ2YS1IL34SV3fHq0G+bEs+dfx7wW4IWPmksxyLlA5BiGXp8lwuclh0HPMmP he7Xe8GRcPgLE4zEftkf+D6atvQolhh4l9PD+CQFHbBaBQpoVkdPoXT/o7ErnitJmn5vEPJV8 5km05ko204eIeuYdS4tbnMEhzHdADSDAxdTtSl+63UQGxSsHEUk2PNxSeJkGWtWkp0KKxc7X X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270568 Archived-At: --=-=-= Content-Type: text/plain Stefan Kangas wrote: > Thanks, I would like to install this patch. > > Could you please send the patch as an attachment instead? We prefer > that patches are created with a command like `git format-patch -1'. > > Please also include: > > - The bug number of this bug in the commit message, like so: Bug#65914 > > - A ChangeLog entry, as described in the CONTRIBUTE file. > > That would make it easier for us to review and install this patch. > Thanks in advance. PFA: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: [PATCH] Exclude current buffer from eww-switch-to-buffer Content-Transfer-Encoding: quoted-printable =46rom 229b3e5be1df7c753410e840d6ea9c36f822fefd Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sat, 16 Sep 2023 05:50:58 +0530 Subject: [PATCH] Exclude current buffer from eww-switch-to-buffer Exclude the current buffer from the completion list of eww-switch-to-buffer; to avoid an extra cycling keystroke (Bug#65914). * lisp/net/eww.el (eww-switch-to-buffer): =2D-- lisp/net/eww.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 4ddda216afc..e43ef2bfe8b 100644 =2D-- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -2062,7 +2062,8 @@ eww-switch-to-buffer (let ((completion-extra-properties '(:annotation-function (lambda (buf) (with-current-buffer buf - (format " %s" (eww-current-url))))))) + (format " %s" (eww-current-url)))))) + (curbuf (current-buffer))) (pop-to-buffer-same-window (read-buffer "Switch to EWW buffer: " (cl-loop for buf in (nreverse (buffer-list)) @@ -2070,9 +2071,10 @@ eww-switch-to-buffer return buf) t (lambda (bufn) - (with-current-buffer - (if (consp bufn) (cdr bufn) (get-buffer bufn)) - (derived-mode-p 'eww-mode))))))) + (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bu= fn))) + (and (with-current-buffer bufn + (derived-mode-p 'eww-mode)) + (not (eq bufn curbuf)))))))) (defun eww-toggle-fonts () "Toggle whether to use monospaced or font-enabled layouts." =2D- 2.34.1 --=-=-= Content-Type: text/plain -- --=-=-=--