From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Sat, 21 Oct 2023 21:24:15 +0800 Message-ID: <87il702jnk.fsf@yahoo.com> References: <87zg4d56l8.fsf@ledu-giraud.fr> <83edj3png3.fsf@gnu.org> <877cov7d7b.fsf@yahoo.com> <83bke7pm6m.fsf@gnu.org> <87y1hb5y0x.fsf@yahoo.com> <83a5trplax.fsf@gnu.org> <87pm2n5wyk.fsf@yahoo.com> <871qf22f5g.fsf@ledu-giraud.fr> <87wmvzkjaw.fsf@ledu-giraud.fr> <87wmvzc2qq.fsf@yahoo.com> <87sf6nn4km.fsf@ledu-giraud.fr> <87o7hbn3mo.fsf@ledu-giraud.fr> <87r0lo2s8a.fsf@ledu-giraud.fr> <874jik46cs.fsf@yahoo.com> <87mswc2q70.fsf@ledu-giraud.fr> <87zg0c2pua.fsf@yahoo.com> <87il702nfo.fsf@ledu-giraud.fr> <87v8b02mae.fsf@yahoo.com> <87a5sc2lh4.fsf@ledu-giraud.fr> <87mswc2lb1.fsf@yahoo.com> <875y302km0.fsf@ledu-giraud.fr> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40618"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , stefankangas@gmail.com, 64440@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 21 15:25:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1quBzC-000ANZ-7H for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Oct 2023 15:25:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quBz1-0007Cr-0N; Sat, 21 Oct 2023 09:25:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quByy-0007CN-1H for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 09:25:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quByw-00022k-6u for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 09:25:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quBzN-0000H5-Oy for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 09:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 13:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.1697894713750 (code B ref 64440); Sat, 21 Oct 2023 13:26:01 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 21 Oct 2023 13:25:13 +0000 Original-Received: from localhost ([127.0.0.1]:42567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quByb-0000Bs-0Z for submit@debbugs.gnu.org; Sat, 21 Oct 2023 09:25:13 -0400 Original-Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]:43592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quByW-0000BQ-LX for 64440@debbugs.gnu.org; Sat, 21 Oct 2023 09:25:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697894675; bh=3baNXAWy6VGuKJcSAHYnbHLb/1WQo3Bd+Lga7yQmQ4c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=I9B7QgQoMXgh7z1UbRE2mucyFrLTnWNk8+0GgLwguj5Uu/Z59414U+znIGdun2Xb+2gAsOfyKlWgpgWsUih3kaDJl+pbZQLmllO2CFoZLlnEkDeSwxq2MTe5GDAaS3Dj50QygLhUGSq2eSYdctw3y57MFNT6SW+6NMHG+dyiLSmJWQHWGMg8kJDuXGJeuJia1/HjSK+5dy/enqxnmGemHpBSQDw308fkzNb+uy6927Pz53iRJNWsTW9Au0z8wVf+kukzeL2KHpsSANY4T2Ks16hPyFB7RurwLvno1I6lk2OUrc1yIHq7+x3xyw4X+q98TAeaZr4Px0XA0ynYyjeSZQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697894675; bh=uDWfe0Tm+WAgQOaO2Yuqu/ZcmHCGYT6yCMZYUfG13yP=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HhARZFePPHw5HiYIbzZ8NsmTr6MvoDG41vlyBlnUguzmotSgAp9+jCRql5JXsgHgYpjF+PiUbQfFIHzFojDh6hED/vFo3Sxokxh4ydIAuohyLo6l5SIK8L1HGMmQYqTM9aVduHgJltmcOJXsuuuwZhB0M2VGnyGNrc7oHrOO7eZB3Ainfua2Hx0Xztp8yLWhkSJqWacZgTEqgTVYiFiWPTLYXScF/M4S1bKpGfY05twOvp/FP1HGE1X4+90YjfMpiGud9TwC0H2O6CClzD/rzhlB774ekpOZ3f8T/XF3pMWiE7D5YMprK+5dZrg8hdui1uwGLAt6TOmkhlAD0yEAyQ== X-YMail-OSG: ILYRLiIVM1mv_vzAxsDKXRpAMammdf4HWKLw295UWQAnPcQMYu.z1ZYkecOdhwX 828Ewi0s5nsTjgAfHdfgy7t1UotfqwjqsDkWiMHQuvh7EuB6jCFDrK4B_5C3iBSGCP68XDg878I5 UKviv_Poo1dHd5nGE1aTy9bOmvqQU9eV9TrDMhfP4Ynd_jlqkxGFfiQKlC1jXgy5QKzTPCLE5FAf gbJrg_NiW5vp1o95o0DTdDuDqutKPEI7Mek19M8VnGr5j3CIPt88sEn1LjWPszwFbsK6ahgpSYCW Bps88REJA6IENrBdiq9GH_xkJKUSVpZACqtB_10h.EQfVvPf2VDHYsSOHCz0QFKU5.rfh0wB1KdM Pvixsdk0DI8QzbMlBjTUCpO.roZDNVREn441rTX.NGNKGET228mpbiSp6RhOt2s16xqAqPrvpP60 o3EqjTm4aFMZcoaN6hdgdVN.lEGDY2wlLnStuQjVIXikOwVtvdN06vVkG.TrBc9DqnSBtJk2VA_z khmW3_G0FkLjxpEfEGOD3GqSWSQEx78uIZm6B5o2G7d8erLdEyPlzS3ahx6LQxO5nwvbtXLPxFPU gc0LOjoyfoENjhK4.768O8CECi4hqw04ps1pRB0cYk.UpiFjyfnNmr9Ibe3ISPjfmndFvdrxqnod NqgakuBiqnZgMiWx.wTPgitx_ipUkgBDmpNddC76LXtYzZsYjQBoudSutA2zsV2_ayH4ohoKTHm9 qbsguTZbCZHeDgn6Qbjp9YMxNcDzky50fslotniRbB8yfb7hoN68Hnq2ZVMjit92sY3bDqzc_dq7 c0qWxmvfcy5ffUGuDURhUIyMREIbaOkLxY88WzVwJS X-Sonic-MF: X-Sonic-ID: 92bcdd9b-0496-4da5-bc51-5a7e2cfb0cf3 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sat, 21 Oct 2023 13:24:35 +0000 Original-Received: by hermes--production-sg3-57f7997989-qz7zb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9de32f1420b423f37b29d5de42087df4; Sat, 21 Oct 2023 13:24:29 +0000 (UTC) In-Reply-To: <875y302km0.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Sat, 21 Oct 2023 15:03:35 +0200") X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272897 Archived-At: Manuel Giraud writes: > Po Lu writes: > >> Better, thanks. Although the commit message must be filled to 64 >> columns, and I'd rather callers passing true be enumerated there. > > What about this one? > > From d2ed7c704854082e5f84a717d18f29c92785a638 Mon Sep 17 00:00:00 2001 > From: Manuel Giraud > Date: Sat, 21 Oct 2023 14:36:24 +0200 > Subject: [PATCH] Support for menu bar in window_from_coordinates > > * src/window.h: > * src/window.c (window_from_coordinates): In the no toolkit > build, add support for the menu bar window. Add a new > 'menu_bar_p' argument so the function's signature has changed. > All callers changed. > > * src/androidterm.c (handle_one_android_event): > * src/haikuterm.c (haiku_read_socket): > * src/keyboard.c (make_lispy_position): > * src/nsterm.m ([EmacsView mouseDown:]): > * src/pgtkterm.c (button_event): > * src/w32term.c (w32_read_socket): > * src/xdisp.c (note_mouse_highlight): > * src/xterm.c (handle_one_xevent): All those callers have > 'menu_bar_p' set to true. I would write: [...] * src/xterm.c (handle_one_xevent): Set menu_bar_p to true. With that aside, LGTM. Thanks.