From: "João Távora" <joaotavora@gmail.com>
To: Richard Copley <rcopley@gmail.com>
Cc: 66759-done@debbugs.gnu.org
Subject: bug#66759: 30.0.50; Flymake (with Eglot) error cleaning up old overlay
Date: Thu, 26 Oct 2023 18:10:46 +0100 [thread overview]
Message-ID: <87il6t1f8p.fsf@gmail.com> (raw)
In-Reply-To: <CAPM58oiiA+RcD=C6EWH2KWB+KGJvUjZ73gUuLGLZ-w_DTn0SLA@mail.gmail.com> (Richard Copley's message of "Thu, 26 Oct 2023 15:17:34 +0100")
Richard Copley <rcopley@gmail.com> writes:
> On Thu, 26 Oct 2023 at 14:24, João Távora <joaotavora@gmail.com> wrote:
>> Please keep an eye out of this bug.
>
> Thanks, will do.
I've now reproduced the bug consistently. It happens exactly as you
conjectured. To test, I temporarily hacked Eglot to take 2 seconds
longer to process each request/notification with this patch:
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index eba66503bf7..48845a889a8 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1488,7 +1488,7 @@ eglot--connect
,@more-initargs)))))
(spread (lambda (fn) (lambda (server method params)
(let ((eglot--cached-server server))
- (apply fn server method (append params nil))))))
+ (run-at-time 2 nil #'apply fn server method (append params nil))))))
(server
(apply
#'make-instance class
And then made sure there was a diagnostic at the end of the file,
changed the file and quickly enough (but only after the changes were
sent to server), deleted the region with the diagnostic at the end of
the file.
Without my fix, I get exactly the (overlayp nil) error you reported.
With the fix, everything works correctly.
So I think with the fix I pushed earlier this bug can be closed, which
I'm doing now.
>> What language server are you using with Eglot btw?
> [1] https://leanprover-community.github.io/learn.html
> [2] https://github.com/leanprover/lean4-mode
> [3] https://github.com/bustercopley/lean4-mode
> [4] https://github.com/joaotavora/eglot/issues/615
> [5] https://github.com/joaotavora/eglot/pull/839
Yeah I know about these PRs. If you want can start a new report in the
Emacs bug tracker proper (i.e. here) )and direct people to it. Write a
summary of the situation if you can, and present this Lean4 use case as
a argument.
This gives visibility to more Emacs maintainers, and allows me to ping
specialists like Eli more easily on the matter.
João
prev parent reply other threads:[~2023-10-26 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 12:09 bug#66759: 30.0.50; Flymake (with Eglot) error cleaning up old overlay Richard Copley
2023-10-26 13:27 ` João Távora
2023-10-26 14:17 ` Richard Copley
2023-10-26 17:10 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il6t1f8p.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=66759-done@debbugs.gnu.org \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).