From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gerd.moellmann@gmail.com, 67794@debbugs.gnu.org, alan@idiocy.org
Subject: bug#67794: 30.0.50; mouse-face is not respected on SVG images
Date: Tue, 19 Dec 2023 14:23:27 +0100 [thread overview]
Message-ID: <87il4utjg0.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <83cyv2ibtr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Dec 2023 15:03:28 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: Eli Zaretskii <eliz@gnu.org>, gerd.moellmann@gmail.com,
>> 67794@debbugs.gnu.org
>> Date: Tue, 19 Dec 2023 13:45:03 +0100
>>
>> > I believe that we need to do some final set-up for the image under
>> > X/GTK/whatever and it looks as though this is all that's needed:
>> >
>> > id = lookup_image (f, s->img->spec, hlinfo->mouse_face_face_id);
>> > s->img = IMAGE_FROM_ID (f, id);
>> > prepare_image_for_display (f, s->img); <------
>> >
>> > Under X we need to send the image to the X server, and under Cairo it
>> > does some other stuff. That's what prepare_image_for_display does. It
>> > does nothing under NS, so the image worked fine under GNUstep.
>>
>> Thank you Alan! That does the trick. So here is an updated version of
>> the patch that works with XRender (i'll test with cairo).
>
> With this change, if you move the mouse pointer on and off the image
> several times, what happens to the Emacs memory footprint?
> Specifically, how many times is memory allocated for the SVG image,
> and if it's allocated each time, does it ever get deallocated?
I didn't measure this memory footprint but AFAIU lookup_image uses the
image cache so an image is allocated once (for one foreground/background
combination). And I think that there is an eviction timeout in the
image cache, no?
--
Manuel Giraud
next prev parent reply other threads:[~2023-12-19 13:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 13:12 bug#67794: 30.0.50; mouse-face is not respected on SVG images Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 13:31 ` Eli Zaretskii
2023-12-12 14:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 14:43 ` Alan Third
2023-12-12 16:35 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 17:28 ` Eli Zaretskii
2023-12-13 8:18 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 12:19 ` Eli Zaretskii
2023-12-13 14:13 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 15:08 ` Eli Zaretskii
2023-12-13 16:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 16:23 ` Eli Zaretskii
2023-12-13 16:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 17:29 ` Eli Zaretskii
2023-12-13 17:57 ` Gerd Möllmann
2023-12-13 18:11 ` Eli Zaretskii
2023-12-13 18:24 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 18:46 ` Eli Zaretskii
2023-12-14 9:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 9:23 ` Eli Zaretskii
2023-12-14 9:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 10:05 ` Eli Zaretskii
2023-12-18 11:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 11:42 ` Alan Third
2023-12-18 18:36 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 19:48 ` Alan Third
2023-12-19 12:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 13:03 ` Eli Zaretskii
2023-12-19 13:23 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-12-19 13:40 ` Eli Zaretskii
2023-12-19 13:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 14:25 ` Eli Zaretskii
2023-12-19 14:39 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 15:34 ` Eli Zaretskii
2023-12-20 8:47 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-20 13:19 ` Eli Zaretskii
2023-12-20 13:54 ` Alan Third
2023-12-20 13:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-20 17:53 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 10:22 ` Eli Zaretskii
2023-12-12 14:47 ` Eli Zaretskii
2023-12-12 15:20 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il4utjg0.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=67794@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).