From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sat, 23 Dec 2023 14:30:42 +0000 Message-ID: <87il4pc7ot.fsf@localhost> References: <878r919qfh.fsf@localhost> <83zg1d468w.fsf@gnu.org> <87bkdr2651.fsf@localhost> <87pm2584oz.fsf@localhost> <83cyy11ln1.fsf@gnu.org> <87lecp84mf.fsf@localhost> <83ttrdx8j9.fsf@gnu.org> <87a5su261p.fsf@localhost> <838r8e24yy.fsf@gnu.org> <87y1gezspg.fsf@localhost> <834jj21z05.fsf@gnu.org> <87il7izo4l.fsf@localhost> <831qe61xrh.fsf@gnu.org> <87cyxqzmhh.fsf@localhost> <83zg0uzlgw.fsf@gnu.org> <87v8bhxzcu.fsf@localhost> <83sf3te1tu.fsf@gnu.org> <87msu1qmqv.fsf@localhost> <83zfy1cgoa.fsf@gnu.org> <87le9lcg4e.fsf@localhost> <83v88pcf2p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2548"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 23 15:28:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rH2zC-0000Uy-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Dec 2023 15:28:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rH2yu-0004ys-OP; Sat, 23 Dec 2023 09:28:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rH2yr-0004yM-Js for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 09:27:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rH2yr-00012z-Bj for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 09:27:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rH2yw-0001aB-63 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 09:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Dec 2023 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.17033416676060 (code B ref 66117); Sat, 23 Dec 2023 14:28:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 23 Dec 2023 14:27:47 +0000 Original-Received: from localhost ([127.0.0.1]:48831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH2yh-0001Zf-7n for submit@debbugs.gnu.org; Sat, 23 Dec 2023 09:27:47 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:48751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH2ye-0001ZR-J6 for 66117@debbugs.gnu.org; Sat, 23 Dec 2023 09:27:45 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D9815240103 for <66117@debbugs.gnu.org>; Sat, 23 Dec 2023 15:27:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703341652; bh=kQc1yXzvt8TKqruJcI8tQwaNrs/LkhQOSsvbffAJbDM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=pVuS93T0+PwnmrsKPfKn/bvGNwDpiIa0R86sr5FNmbbejGPiwRkOu5Oh+hL9Cnyqr T3U0MA8t4pHFVyBbyPX7v1TAH5LU+nzLU0F6s8bvhZiBgKXX70kT8dJcoUkffJNeiU SeKw6NPyQCXtsqI2Pul8691xhN0JNlN9uDojelVADDGqx/CvyTzWOSyH0qIsQer04I L8oILVQia+J10yM2iYu8F+nodqhWIkaXSXY5j/jPydKV/7zvpMOKPaZVeDkXHNRM/v M0bQ3yV9udI4StYUZijhjLs54Q0tD6aFEuflJIEf9JrrmSyJkSLY8LewXNbGhD9+4E Lt8HuVODVansg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Sy62C118Fz6tsf; Sat, 23 Dec 2023 15:27:30 +0100 (CET) In-Reply-To: <83v88pcf2p.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276742 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> I do not mind adding tests, but it will not be as fast - I need help >> with them. > > We could install just a few now, and the rest afterwards. You have > already presented enough non-trivial cases that can be easily > converted to tests, and I think it is a good idea to do that when we > change such low-level and veteran code. See the attached. I am not sure if these few cases are enough to warrant a separate commit though. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-tests-for-let-bug-66117.patch >From 147ae00df849f04cdb00e09d8079533fa5dea98a Mon Sep 17 00:00:00 2001 Message-ID: <147ae00df849f04cdb00e09d8079533fa5dea98a.1703341788.git.yantar92@posteo.net> From: Ihor Radchenko Date: Sat, 23 Dec 2023 15:29:36 +0100 Subject: [PATCH] Add tests for `let' (bug#66117) * test/src/eval-tests.el (eval-tests/default-value): New test. --- test/src/eval-tests.el | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el index 4589763b2f5..c1219591e40 100644 --- a/test/src/eval-tests.el +++ b/test/src/eval-tests.el @@ -282,4 +282,25 @@ eval-tests-defvaralias (should-error (defvaralias 'eval-tests--my-c 'eval-tests--my-d) :type 'cyclic-variable-indirection)) +(defvar eval-tests/global-var 'value) +(defvar-local eval-tests/buffer-local-var 'value) +(ert-deftest eval-tests/default-value () + ;; `let' overrides the default value for global variables. + (should (default-boundp 'eval-tests/global-var)) + (should (eq 'value (default-value 'eval-tests/global-var))) + (should (eq 'value eval-tests/global-var)) + (let ((eval-tests/global-var 'bar)) + (should (eq 'bar (default-value 'eval-tests/global-var))) + (should (eq 'bar eval-tests/global-var))) + ;; `let' overrides the default value everywhere, but leaves + ;; buffer-local values unchanged in current buffer and in the + ;; buffers where there is no explicitly set buffer-local value. + (should (default-boundp 'eval-tests/buffer-local-var)) + (should (eq 'value (default-value 'eval-tests/buffer-local-var))) + (should (eq 'value eval-tests/buffer-local-var)) + (with-temp-buffer + (let ((eval-tests/buffer-local-var 'bar)) + (should (eq 'bar (default-value 'eval-tests/buffer-local-var))) + (should (eq 'bar eval-tests/buffer-local-var))))) + ;;; eval-tests.el ends here -- 2.42.0 --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--