From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Wed, 28 Feb 2024 15:47:34 +0100 Message-ID: <87il28ve61.fsf@epfl.ch> References: <6BAFD8BF-8F18-4D9F-9DB3-A185AEF2EBCA@gmail.com> <867cj5wuo6.fsf@gnu.org> <865xypwu5e.fsf@gnu.org> <87il2kvbh5.fsf@epfl.ch> <878r3fz37e.fsf@epfl.ch> <87sf1leujg.fsf@epfl.ch> <877ciwwqjt.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , kobarity@gmail.com, mattias.engdegard@gmail.com, 68559@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 28 15:49:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfLF1-0007Fz-9b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Feb 2024 15:49:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfLEd-0003PU-TX; Wed, 28 Feb 2024 09:48:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfLEb-0003Ot-Gw for bug-gnu-emacs@gnu.org; Wed, 28 Feb 2024 09:48:37 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfLEa-00062g-G9 for bug-gnu-emacs@gnu.org; Wed, 28 Feb 2024 09:48:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rfLF0-0004vn-Mk for bug-gnu-emacs@gnu.org; Wed, 28 Feb 2024 09:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Feb 2024 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.170913169118636 (code B ref 68559); Wed, 28 Feb 2024 14:49:02 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 28 Feb 2024 14:48:11 +0000 Original-Received: from localhost ([127.0.0.1]:45005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfLEA-0004qR-JO for submit@debbugs.gnu.org; Wed, 28 Feb 2024 09:48:11 -0500 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:41327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfLE8-0004q5-7Z for 68559@debbugs.gnu.org; Wed, 28 Feb 2024 09:48:09 -0500 Original-Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-56617252a07so769996a12.1 for <68559@debbugs.gnu.org>; Wed, 28 Feb 2024 06:47:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709131656; x=1709736456; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QZyvc/xPGxbLH50KJqkIJ1xWKzn7FxSnq/0NVFXlN5A=; b=fSyqSPonl7dUhK0i8Eb21NulvOBeDp6WdUXPP2xgoGTs01LMaZIDSBL80Ws5TjOpma 0+mZlMBZQxASfJMjOQk4MgG52+rEJllOMm5C65DVfbMTioZu2S3ke7hm3xofsoMNvNsP embIFwVXPIW/HQbM6o+r1tSGAQyPASiPQPFD3O5u08tGRIGfB/wws+zbtGwsu7EBLglG fNHw9kLXcw66TTnPycvX05V8FFD6OapmrytVsVKxWDD2WGTqZha9ptusC7JtpWwZwser a9UybRnnwX4RNjx+c5TTk42Tf/BBR3aVH+8Td5dwRa6OmLT5JG9wZnunp0NY7C/X9u6H Efkw== X-Forwarded-Encrypted: i=1; AJvYcCUw42tbk8IkSqzG5ABMosVkxUHO2GeIWalzVR9+KejuDWDEZ/gYqFUR2SBDSLgwNeHc+yum1ARCYecIp2UIrMVZNeF8tNo= X-Gm-Message-State: AOJu0Yxq0sfR8BvFbgc1H2JBojtdwrHjvZXW/5YmsUfbdkvDx6VYGAGD 3V84RomZTbkDTlZ/6BavBv0b0xxnumKycRCi+nTD3VkF5gwhCLaFOz6/zARB1nU= X-Google-Smtp-Source: AGHT+IG/IG1mUXuJyG7zi1DGOehbrb96eYxWDAk1ESA93b74Ubsjd68582xcs59ezHmJ4y6A8U6peg== X-Received: by 2002:a50:aadc:0:b0:566:6726:7aa5 with SMTP id r28-20020a50aadc000000b0056667267aa5mr1482172edc.0.1709131655463; Wed, 28 Feb 2024 06:47:35 -0800 (PST) Original-Received: from localhost ([2001:620:618:5c0:2:80b3:0:15c]) by smtp.gmail.com with ESMTPSA id w15-20020aa7da4f000000b00561c666991csm1836366eds.73.2024.02.28.06.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 06:47:35 -0800 (PST) In-Reply-To: (Liu Hui's message of "Fri, 23 Feb 2024 21:07:22 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280758 Archived-At: Liu Hui [2024-02-23 21:07 +0800] wrote: > On Thu, Feb 22, 2024 at 9:56=E2=80=AFPM Basil L. Contovounesios > wrote: >> >> The python-shell-completion-at-point-ipython test is still skipped, with >> or without specifying PYTHONSTARTUP=3D"$(python -m jedi repl)", but like >> you suggest that's not necessarily a problem. > > I have no idea why the test is skipped. You may still check if native > completion works for IPython with following steps: > > 1. PYTHONSTARTUP=3D"$(python -m jedi repl)" emacs -Q Oops: $ PYTHONSTARTUP=3D"$(python -m jedi repl)" ./src/emacs -Q /home/blc/.pyenv/versions/3.12.2/bin/python: No module named jedi Once I 'pip install jedi' the rest works as expected, and python-shell-completion-at-point-ipython is no longer skipped. >> I'm guessing you don't have write access to emacs.git, but have signed >> the CA? If so, and if there are no other comments/objections in a few >> days, I'll apply the patch in your name. > > Yes, I've signed the CA. Thanks. Done: Fix Python shell completion test failures 8a2d013be37 2024-02-28 15:25:56 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D8a2d013be37 >> If that was from you, do you have any objection to me mapping >> ilupin@users.noreply.github.com to liuhui1610@gmail.com in the .mailmap >> file in emacs.git? Then all commits will show up under a single name >> and email address. > > Yes. I have no objection, thanks. Done: ; * .mailmap: Fix GitHub address (bug#68559#170). 1ddd9c8e29f 2024-02-28 15:30:41 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D1ddd9c8e29f Thanks, --=20 Basil