unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer
@ 2024-03-20  1:33 john muhl
  2024-03-20  2:00 ` john muhl
  0 siblings, 1 reply; 4+ messages in thread
From: john muhl @ 2024-03-20  1:33 UTC (permalink / raw)
  To: 69909

Tags: patch

I noticed a couple of changes requested in the initial round of
review weren’t included in the final patch of bug#65673.

This one changes it so the inferior Lua buffer uses a window
instead of a frame.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer
  2024-03-20  1:33 bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer john muhl
@ 2024-03-20  2:00 ` john muhl
  2024-03-20  2:16   ` john muhl
  0 siblings, 1 reply; 4+ messages in thread
From: john muhl @ 2024-03-20  2:00 UTC (permalink / raw)
  To: 69909

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Use-window-instead-of-frame-for-inferior-Lua-buffer.patch --]
[-- Type: text/x-patch, Size: 1065 bytes --]

From beef7e1ec5fd3a5871e92b594b20b3ba430aeff0 Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Tue, 19 Mar 2024 19:46:12 -0500
Subject: [PATCH] Use window instead of frame for inferior Lua buffer

* lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Replace
'display-buffer-pop-up-window' with
'display-buffer-pop-up-frame'.  (bug#69909)
---
 lisp/progmodes/lua-ts-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el
index 25fd7792f42..b6d6e90680c 100644
--- a/lisp/progmodes/lua-ts-mode.el
+++ b/lisp/progmodes/lua-ts-mode.el
@@ -628,7 +628,7 @@ lua-ts-inferior-lua
                 nil t)))
   (select-window (display-buffer lua-ts-inferior-buffer
                                  '((display-buffer-reuse-window
-                                    display-buffer-pop-up-frame)
+                                    display-buffer-pop-up-window)
                                    (reusable-frames . t))))
   (get-buffer-process (current-buffer)))
 
-- 
2.41.0


[-- Attachment #2: Type: text/plain, Size: 276 bytes --]


john muhl <jm@pub.pink> writes:

> Tags: patch
>
> I noticed a couple of changes requested in the initial round of
> review weren’t included in the final patch of bug#65673.
>
> This one changes it so the inferior Lua buffer uses a window
> instead of a frame.


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer
  2024-03-20  2:00 ` john muhl
@ 2024-03-20  2:16   ` john muhl
  2024-03-23  7:25     ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: john muhl @ 2024-03-20  2:16 UTC (permalink / raw)
  To: 69909

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

Oops. Probably don’t want these in the Changelog.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Open-inferior-Lua-buffer-in-a-window-not-a-frame.patch --]
[-- Type: text/x-patch, Size: 1065 bytes --]

From 4c7f50cb28489f5f2bf62af2b09bf16ac6b16045 Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Tue, 19 Mar 2024 19:46:12 -0500
Subject: [PATCH] ; Open inferior Lua buffer in a window, not a frame

* lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Replace
'display-buffer-pop-up-window' with
'display-buffer-pop-up-frame'.  (bug#69909)
---
 lisp/progmodes/lua-ts-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el
index 25fd7792f42..b6d6e90680c 100644
--- a/lisp/progmodes/lua-ts-mode.el
+++ b/lisp/progmodes/lua-ts-mode.el
@@ -628,7 +628,7 @@ lua-ts-inferior-lua
                 nil t)))
   (select-window (display-buffer lua-ts-inferior-buffer
                                  '((display-buffer-reuse-window
-                                    display-buffer-pop-up-frame)
+                                    display-buffer-pop-up-window)
                                    (reusable-frames . t))))
   (get-buffer-process (current-buffer)))
 
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 417 bytes --]



john muhl <jm@pub.pink> writes:

> [1. text/x-patch; 0001-Use-window-instead-of-frame-for-inferior-Lua-buffer.patch]...
>
>
> john muhl <jm@pub.pink> writes:
>
>> Tags: patch
>>
>> I noticed a couple of changes requested in the initial round of
>> review weren’t included in the final patch of bug#65673.
>>
>> This one changes it so the inferior Lua buffer uses a window
>> instead of a frame.


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer
  2024-03-20  2:16   ` john muhl
@ 2024-03-23  7:25     ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2024-03-23  7:25 UTC (permalink / raw)
  To: john muhl; +Cc: 69909-done

> From: john muhl <jm@pub.pink>
> Date: Tue, 19 Mar 2024 21:16:57 -0500
> 
> Oops. Probably don’t want these in the Changelog.

Thanks, installed on master, and closing the bug.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-03-23  7:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-20  1:33 bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer john muhl
2024-03-20  2:00 ` john muhl
2024-03-20  2:16   ` john muhl
2024-03-23  7:25     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).