From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70794: 30.0.50; Add Rust compilation regex Date: Thu, 6 Jun 2024 00:56:38 +0200 Message-ID: <87ikyn578o.fsf@aol.com> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@gmail.com> <86sexukpuh.fsf@gnu.org> <8BC5E59B-63B1-4784-9454-51925E9DBCFC@gmail.com> <86ikyqkmuo.fsf@gnu.org> <09473128-D0DB-442C-8404-EE58A18F5A5B@gmail.com> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34437"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70794@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Eli Zaretskii To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 00:57:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEzZv-0008oy-61 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 00:57:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEzZk-0004bh-PG; Wed, 05 Jun 2024 18:57:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEzZj-0004bV-Oo for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:57:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEzZj-0006bQ-Gw for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:57:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEzZx-0006yA-OZ for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 22:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70794 X-GNU-PR-Package: emacs Original-Received: via spool by 70794-submit@debbugs.gnu.org id=B70794.171762822626655 (code B ref 70794); Wed, 05 Jun 2024 22:58:01 +0000 Original-Received: (at 70794) by debbugs.gnu.org; 5 Jun 2024 22:57:06 +0000 Original-Received: from localhost ([127.0.0.1]:44659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEzZ4-0006vp-1n for submit@debbugs.gnu.org; Wed, 05 Jun 2024 18:57:06 -0400 Original-Received: from sonic312-21.consmr.mail.bf2.yahoo.com ([74.6.128.83]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEzZ2-0006vC-Kz for 70794@debbugs.gnu.org; Wed, 05 Jun 2024 18:57:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1717628204; bh=sStieO3psgHUcGxQoGVBHjjAOfH7gYI5x8m2WGINAWo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=M1bO404GNVQrI1wfMjr5E1WBMqS1sNk1dQdwmr9cE8PJsMBGdDTUgWZGHFcmYG2lnQKf/TVmXuZ8yYoWqpZMDdlu/WfjXWyJ3cDhCo28ONqHN4hoFQmdYsDDhq6B7/Z/13c4VoZC7+YtflKbSoMmKpuqTNOkeZO5f9eUoFKzFB5n/4OfJ3RJW87bEGkzxP54XeGKtbtuWluVvTBZfVsqw1WV4mN72QuyQWtlPACgRjc4WstRZ3YUEzPH2yiguL+GZsl2A8De/BNSpwyCGsFUb/7e3x2o5HEJbfshGeRBS+gG02BeEYSxUWFU4zjRHxJp6lyi9RO3rYAc16VpkHOrGA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1717628204; bh=/1IcETi4I+UNR4H8GehTsT+0Xan7bgraJTDP057MiA+=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=i9G6mGj4F0GkV7IKGUtsbql6ZVGfdtI93CXPl8bmKHtamgVdTLxfEqFGIIF8FWNfn+OxPHM60F2VCDwWkP+ua0byayXZLq/gqdA3IMf+WrriW/MOdPfvDfrJMmO5RdsaMuycg1UemM5apTv3y+d9Fw15LhftrujkWmVFMngfWQYWvYgR4ebh+ddfhRsHxmMGKnBaFDxWdApUHuRiRer3jsCsn7oOQOm2ZSyYb95NR2p4U0Q0S7Oqvz6zu0+jvoi4BZ9gzhSuLluGhwbDjM6trhr/PA1a6Vym1xUnfaYMWgI/xVY2RC59mPCrfjH58aKzi9iyqwZFmtuW0kuZ1SbIuw== X-YMail-OSG: 1kFSkoAVM1l6kaHtG3_i4cieq8_PH2fIBpHNoRzmn54Fo0nNGb3V0aSs1HGbDHd OCOkDjUxiku6esgRKYGmDni1TcPrR33.dWo7_xzv2.BWguPKqAUUsWXyX.3HqkEdRhGstGvjwrJj shxEwM2ADmdtM4EWtM0XCkbdjYwPsNH5eyxQahJibeD4qqfPCTWUm24EM_GxnULbPrgJGSkSmjkr epMeaB2NMQ03gBkymYj5MjgNHUXDEKSBoBDS6oIywKwKjicxbbaFDxOL4BrJPaDTBUhAHlo.NUvt jqKr9yfekf1alJwQYIE2a0laKHO11eq6lHtHEYlHaLoKfj3NfLu1GPzhzabPvlIABf2A1SP5osaV Di7kFbxFl2H9tMCc7O9KFyvL4hP0JeMkawtJ9if5YJj6qBkOkmZO7C2mmM4G8wuwn24IhF8TKQdG wAO7fICcSgzNN9LUGa.JVGSjETAMjCeJFXWmc05QD_C3UEa98897fsyywQC5PkSmQLhLQSR1glWo a64Zm2zgRrsPdLuNEvEDJk.j_S1sGpfdpPyilKi..5pQNteR58XFPjJRpOkJRppWnKfbJKlJ5kkW Agqrphv.PJwYUHzm.N1FUUUld2Wh7NYfbWa.ACrIZKX38diTkk3aucqC2n1wFDlP6kvem1gOrj0J lB6kpW.COOu3RtOIEVN_tHK8r_.0_xmu6dw0ZL0llvHftm0_yGB0Nqcg9a8CXFDPqSlihzPetC0A WjHpHICbCQ_4bMLGfA7gLsIEqDrfe0yzqiLnamNm7B0PZ_AlWq6j0Yauks0UMRBHVlmIf8b3Wqjk mEFFblSVePpUCD4snYJw.AirQJ1B8PUptfghYB.C7H X-Sonic-MF: X-Sonic-ID: 01afe841-e40d-40c4-824f-638d4b1932c6 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Wed, 5 Jun 2024 22:56:44 +0000 Original-Received: by hermes--production-ir2-7b99fc9bb6-hcsdk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b0d243fd84e18f28c9d17fda4f6880e1; Wed, 05 Jun 2024 22:56:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.22407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286643 Archived-At: On Tue, Jun 04, 2024 at 06:06:16PM GMT, Stefan Kangas wrote: >Mattias Engdeg�rd writes: > >> Even with the obvious fixes, the pattern would still be incomplete and not even match parts of the examples given. I'm happy to work with Rust users or package maintainers to work out details but I don't want to do a rush job now, nor delay Emacs 30. > >BTW, shouldn't stuff like this be happier if it was in something like >`rust-mode`? > >It seems like the maintainers of major modes are in a better position to >add and maintain support for the compilers and tools of their respective >languages than we are. Hi Stefan: Actually I opened the initial issue because there is a rust-ts-mode now in vanilla and in my opinion it is a bit incoherent to have a native mode to support rust, but don't support compiling rust. Specially considering that adding such support seems extremely simple, it only requires to improve the regex to be a bit more strict. And the one I provided is buggy mainly due to the "too free" wildcard I used to match anything including the new line... Just improving the [^\0]+?--> in the regex; I thing everything will work properly.