unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 70794@debbugs.gnu.org,
	"Mattias Engdegård" <mattias.engdegard@gmail.com>,
	"Eli Zaretskii" <eliz@gnu.org>
Subject: bug#70794: 30.0.50; Add Rust compilation regex
Date: Thu, 6 Jun 2024 00:56:38 +0200	[thread overview]
Message-ID: <87ikyn578o.fsf@aol.com> (raw)
In-Reply-To: <CADwFkmn12kDCtFD3ZakVe2g3WKPPr2wjyobP+2nPmTi1B46=ew@mail.gmail.com>

On Tue, Jun 04, 2024 at 06:06:16PM GMT, Stefan Kangas wrote:
>Mattias Engdeg�rd <mattias.engdegard@gmail.com> writes:
>
>> Even with the obvious fixes, the pattern would still be incomplete and not even match parts of the examples given. I'm happy to work with Rust users or package maintainers to work out details but I don't want to do a rush job now, nor delay Emacs 30.
>
>BTW, shouldn't stuff like this be happier if it was in something like
>`rust-mode`?
>
>It seems like the maintainers of major modes are in a better position to
>add and maintain support for the compilers and tools of their respective
>languages than we are.

Hi Stefan:

Actually I opened the initial issue because there is a rust-ts-mode now
in vanilla and in my opinion it is a bit incoherent to have a native
mode to support rust, but don't support compiling rust.

Specially considering that adding such support seems extremely simple,
it only requires to improve the regex to be a bit more strict. And the
one I provided is buggy mainly due to the "too free" wildcard I used to
match anything including the new line...

Just improving the [^\0]+?--> in the regex; I thing everything will work
properly.






  reply	other threads:[~2024-06-05 22:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87y18nsp84.fsf.ref@aol.com>
2024-05-06  1:28 ` bug#70794: 30.0.50; Add Rust compilation regex Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-11  8:51   ` Eli Zaretskii
2024-05-15 13:10     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-18 10:52       ` Eli Zaretskii
2024-05-31 17:15   ` Mattias Engdegård
2024-06-03 14:41     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 15:35       ` Mattias Engdegård
2024-06-03 14:54     ` Mattias Engdegård
2024-06-03 15:28       ` Eli Zaretskii
2024-06-03 16:22         ` Mattias Engdegård
2024-06-03 16:33           ` Eli Zaretskii
2024-06-03 16:59             ` Mattias Engdegård
2024-06-04 22:06               ` Stefan Kangas
2024-06-05 22:56                 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-06  7:34               ` Stefan Kangas
2024-06-03 22:36           ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 14:33             ` Eli Zaretskii
2024-06-03 15:30       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikyn578o.fsf@aol.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=70794@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mattias.engdegard@gmail.com \
    --cc=spacibba@aol.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).