From: Robert Pluim <rpluim@gmail.com>
To: "J.P." <jp@neverwas.me>
Cc: Christopher Howard <christopher@librehacker.com>,
53941@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>,
larsi@gnus.org, Eli Zaretskii <eliz@gnu.org>,
gnuhacker@member.fsf.org
Subject: bug#53941: 27.2; socks + tor dont work with https
Date: Tue, 17 Sep 2024 09:29:15 +0200 [thread overview]
Message-ID: <87ikuukab8.fsf@gmail.com> (raw)
In-Reply-To: <87jzfbnj23.fsf@neverwas.me> (J. P.'s message of "Mon, 16 Sep 2024 18:52:04 -0700")
>>>>> On Mon, 16 Sep 2024 18:52:04 -0700, "J.P." <jp@neverwas.me> said:
JP> Robert Pluim <rpluim@gmail.com> writes:
>> More information hiding by default is a good thing. (Iʼm not the
>> original author, I just changed it to look at the actual local
>> addresses instead of hardcoding them)
JP> D'oh, I see that now. The original author was one Mr. Wong. If you'd
JP> like to be spared any further spam related to this bug, please say so,
JP> and I'll remove you from the Cc's. (But if not, I could certainly use
JP> the input.)
I donʼt mind.
JP> + (not (and-let* (((or (and (functionp nsm-trust-local-network)
JP> + (funcall nsm-trust-local-network))
JP> + nsm-trust-local-network))
JP> + (addresses (network-lookup-address-info host))
JP> + (network-interface-list (network-interface-list t)))
JP> + (catch 'off-net
JP> + (dolist (ip addresses)
JP> + (dolist (info network-interface-list)
JP> + (when (nsm-network-same-subnet (substring (nth 1 info) 0 -1)
JP> + (substring (nth 3 info) 0 -1)
JP> + (substring ip 0 -1))
JP> + (throw 'off-net t))))))))
>>
>> Since youʼve inverted the test, you should probably invert the name of
>> `off-net'.
JP> Ah, took that "by rote" from the old sentinel variable, but as you say,
JP> it doesn't comport with the semantics. Changed to `nsm-should-check'.
OK. I think you can push that patch to master if Eli is ok with it,
regardless of what happens with the others.
Robert
--
next prev parent reply other threads:[~2024-09-17 7:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 11:09 bug#53941: 27.2; socks + tor dont work with https Jacobo
2022-02-14 12:37 ` J.P.
2022-02-19 21:04 ` Jacobo
2022-02-21 15:01 ` J.P.
2022-03-01 14:29 ` J.P.
2022-03-02 2:37 ` J.P.
2022-03-06 2:40 ` Jacobo
2022-03-06 2:58 ` J.P.
2022-03-07 7:09 ` J.P.
2022-03-10 8:58 ` J.P.
2022-11-28 15:30 ` bug#53941: Last-minute socks.el improvements for Emacs 29? J.P.
2022-11-28 17:12 ` Eli Zaretskii
2022-11-29 14:24 ` J.P.
2022-11-29 14:36 ` Eli Zaretskii
2023-09-06 22:25 ` bug#53941: 27.2; socks + tor dont work with https Stefan Kangas
2023-09-07 5:53 ` Eli Zaretskii
2023-09-07 13:25 ` J.P.
2023-09-07 13:47 ` Stefan Kangas
2023-09-08 2:55 ` J.P.
2023-09-08 11:04 ` Stefan Kangas
2023-10-18 13:38 ` J.P.
2023-12-19 16:29 ` J.P.
2023-09-08 13:28 ` J.P.
2023-09-09 14:05 ` J.P.
2024-08-23 21:46 ` Christopher Howard
2024-09-14 13:33 ` Stefan Kangas
2024-09-16 1:59 ` J.P.
2024-09-16 13:34 ` Robert Pluim
2024-09-17 1:52 ` J.P.
2024-09-17 7:29 ` Robert Pluim [this message]
2024-09-17 12:41 ` Eli Zaretskii
2024-09-17 13:54 ` Robert Pluim
2024-09-18 1:10 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikuukab8.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=53941@debbugs.gnu.org \
--cc=christopher@librehacker.com \
--cc=eliz@gnu.org \
--cc=gnuhacker@member.fsf.org \
--cc=jp@neverwas.me \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).