From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73357: [PATCH] Make vc-clone interactive Date: Thu, 24 Oct 2024 21:45:42 +0800 Message-ID: <87ikth3989.fsf@melete.silentflame.com> References: <875xqrlr3b.fsf@disroot.org> <86ploz935f.fsf@gnu.org> <87y13nk39b.fsf@disroot.org> <87ed59tkpk.fsf@posteo.net> <871q12fhf2.fsf@disroot.org> <87jzesulk7.fsf@posteo.net> <87y131ffox.fsf@disroot.org> <86msj9wmna.fsf@gnu.org> <874j516bwk.fsf@disroot.org> <87sesl93xe.fsf@posteo.net> <87a5et4u90.fsf@melete.silentflame.com> <87wmhx4r7k.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9653"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , Philip Kaludercic , Eli Zaretskii , 73357-done@debbugs.gnu.org To: Aleksandr Vityazev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 24 15:47:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3yB2-0002I4-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Oct 2024 15:47:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3yAe-0004o1-4b; Thu, 24 Oct 2024 09:46:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3yAa-0004nU-F3 for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 09:46:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3yAa-0002M7-4v for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 09:46:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=6GQE0fYjmxQREINKphvqoT7mii0Q9fEKmXhqU/Lrap4=; b=m82BYKxsaeJU3pQLWQRcLHaR5hfDOi4/wWhddVrlT8Xd+wcpTyGMOl5LmD35FuuPOdrnBpi6q5X5jDu95u7IWECfr+EVTEGiL2DncHS5DwZ9JZrJCG3E6zKs10eKwplf24Fx88OcMZA9AkTnGf9oc/qu/c4tS7FIR3olFPUCRGsayHUaKkxXl3r5w8XbJXC6pJDNPqv1mauEMiXtgy2PyaEBOgaROyLthB1w/lKJg4zv4dsk7nbEZIwEufdiSKkwrbJJ+zqvNdm3ETNCH7JB/39m4wWd5CxyEJB4c44kcwp2GeQ8S78ByCQpno8AiktC4M4Gc2hs/gu781Q7yROmQQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3yB4-0004Uz-Nk for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 09:47:02 -0400 Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2024 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 73357@debbugs.gnu.org, spwhitton@spwhitton.name, avityazev@disroot.org Original-Received: via spool by 73357-done@debbugs.gnu.org id=D73357.172977759017225 (code D ref 73357); Thu, 24 Oct 2024 13:47:02 +0000 Original-Received: (at 73357-done) by debbugs.gnu.org; 24 Oct 2024 13:46:30 +0000 Original-Received: from localhost ([127.0.0.1]:34139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3yAY-0004Tl-6b for submit@debbugs.gnu.org; Thu, 24 Oct 2024 09:46:30 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:39908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3yAU-0004TS-Eu for 73357-done@debbugs.gnu.org; Thu, 24 Oct 2024 09:46:28 -0400 DKIM-Signature: a=rsa-sha256; b=vv+XpblNts5EGjKzibV3+eD/JsczNDhianPOpWQvnEfpq/Ox1c1zqJv344d/yHi1jpRSdyOaK1YSJMBrDXnKVnJ1M2MDg1GMmJEu3p1CVO3rLODx+Zi1iAxX9ldS8e2mIYep5D74Jps+5EK5FqmhSv7JC0nI/oinhPXPB+ShsvrgLeCrwG6ojyCYNnZcZpqhUAokzunObAnC/u1ATZqAvkosFHcQxbCSoR4a3HSMBvIcrIW2YfODxJxzOH/k1uk4wINrRasaCknYkH9y7eKFSl/Kqnu1vihQouTuYWY9nfkmIzLLN/WDG9KdIR92CrcxomN+hGZ4+6G+tgT2Lz8p7g==; s=purelymail2; d=spwhitton.name; v=1; bh=hG3tz2swUhost+4onXtuEw+GE40gEeUgR7nRih/wcys=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=DP67CYIt7hP3kys3fdu2916CgZML2oiVFJnNZAyLUEQ5EEZpxoEZuy2GEhSxa7p57jtHW3C/ozSJGswtbm+SMimIXi1yOIj7/6+gNI5XOk1NAOeXBmc5ySD3DLKnzHkLRTEBsNRdODg1njFQggvGH0gkFggxiR25faFANK2GiC014FqVyhwVoaw7EsHBPF5iSPbDCRycvczJyd6TtL2K+Nf6gZAAWO3znA8NNzQzfFfdIqm2an9lpNCzIKBQEpjJ5KkMkALkxexeveXoWTj94ZMWOUXmDO7eY1ezI2aSW6O0UU+P05CI19WRTHbVfugcIQyFmT9Rjlx7eWpuAEPMHg==; s=purelymail2; d=purelymail.com; v=1; bh=hG3tz2swUhost+4onXtuEw+GE40gEeUgR7nRih/wcys=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73357-done@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -219221376; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 24 Oct 2024 13:45:47 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 725767ED9AA; Thu, 24 Oct 2024 21:45:42 +0800 (CST) In-Reply-To: <87wmhx4r7k.fsf@disroot.org> (Aleksandr Vityazev's message of "Thu, 24 Oct 2024 15:31:59 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294188 Archived-At: Hello, On Thu 24 Oct 2024 at 03:31pm +03, Aleksandr Vityazev wrote: > I don't have a strong opinion on this. I originally proposed this: > > (when (file-directory-p directory) > (if (called-interactively-p 'interactive) > (find-file directory) > directory)) > > The OPEN-DIR argument was suggested by Philip, and I agreed with him, > since the option is also good. I'm fine with both options, I'll do as > you say. Sorry, I misread the code, ignore my comment here. > V5 patches: Installed, thanks. I renamed vc-backend-type and vc-heuristic-alist to less generic names. I also realised that vc-clone now can call vc-guess-url-backend even when noninteractive, and it always returns DIRECTORY which it didn't before, so I updated the commit message accordingly. -- Sean Whitton