From: Sean Whitton <spwhitton@spwhitton.name>
To: Aleksandr Vityazev <avityazev@disroot.org>
Cc: Dmitry Gutov <dmitry@gutov.dev>,
Philip Kaludercic <philipk@posteo.net>,
Eli Zaretskii <eliz@gnu.org>,
73357-done@debbugs.gnu.org
Subject: bug#73357: [PATCH] Make vc-clone interactive
Date: Thu, 24 Oct 2024 21:45:42 +0800 [thread overview]
Message-ID: <87ikth3989.fsf@melete.silentflame.com> (raw)
In-Reply-To: <87wmhx4r7k.fsf@disroot.org> (Aleksandr Vityazev's message of "Thu, 24 Oct 2024 15:31:59 +0300")
Hello,
On Thu 24 Oct 2024 at 03:31pm +03, Aleksandr Vityazev wrote:
> I don't have a strong opinion on this. I originally proposed this:
>
> (when (file-directory-p directory)
> (if (called-interactively-p 'interactive)
> (find-file directory)
> directory))
>
> The OPEN-DIR argument was suggested by Philip, and I agreed with him,
> since the option is also good. I'm fine with both options, I'll do as
> you say.
Sorry, I misread the code, ignore my comment here.
> V5 patches:
Installed, thanks.
I renamed vc-backend-type and vc-heuristic-alist to less generic names.
I also realised that vc-clone now can call vc-guess-url-backend even
when noninteractive, and it always returns DIRECTORY which it didn't
before, so I updated the commit message accordingly.
--
Sean Whitton
next prev parent reply other threads:[~2024-10-24 13:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 13:18 bug#73357: [PATCH] Make vc-clone interactive Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-19 13:36 ` Eli Zaretskii
2024-09-19 16:38 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-24 10:22 ` Philip Kaludercic
2024-09-29 18:23 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-01 11:09 ` Philip Kaludercic
2024-10-06 14:50 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 12:06 ` Eli Zaretskii
2024-10-24 10:19 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-24 10:43 ` Philip Kaludercic
2024-10-24 11:26 ` Sean Whitton
2024-10-24 12:31 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-24 13:45 ` Sean Whitton [this message]
2024-10-24 14:19 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikth3989.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=73357-done@debbugs.gnu.org \
--cc=avityazev@disroot.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).