unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Sean Devlin <spd@toadstyle.org>
Cc: Eli Zaretskii <eliz@gnu.org>, 73932@debbugs.gnu.org
Subject: bug#73932: [PATCH] Add noconfirm to 'package-autoremove'
Date: Sat, 26 Oct 2024 07:31:16 +0000	[thread overview]
Message-ID: <87iktfe2wr.fsf@posteo.net> (raw)
In-Reply-To: <487C14D0-1114-49BC-996E-E3C74D17950F@toadstyle.org> (Sean Devlin's message of "Mon, 21 Oct 2024 14:04:14 -0400")

Sean Devlin <spd@toadstyle.org> writes:

> Hello,
>
>> On Oct 21, 2024, at 12:35 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> 
>>> From: Sean Devlin <spd@toadstyle.org>
>>> Date: Mon, 21 Oct 2024 11:58:34 -0400
>>> 
>>> Attached is a patch adding an optional NOCONFIRM argument to package-autoremove to skip user confirmation before removing packages.
>>> 
>>> I want to call package-autoremove in my init file to ensure there
>>> are no packages installed except those I configured explicitly via
>>> package-selected-packages.
>>> 
>>> For example, in one session I might install package XYZ
>>> interactively via the package menu to try it out. If I decide I
>>> like it, I’ll add it to package-selected-packages in my init file
>>> to keep it around. Otherwise, I want to make sure it gets blown
>>> away the next time I start Emacs.
>>> 
>>> This workflow is cumbersome in the current implementation of
>>> package-autoremove, which prompts the user before removing any
>>> packages. This patch adds an optional NOCONFIRM argument similar to
>>> what is implemented in package-install-selected-packages.
>>> 
>>> Please let me know if any changes are needed.
>> 
>> Thanks.  I'll let our package.el experts review and comment, but if
>> this is accepted, please add a NEWS entry for the new optional
>> behavior.
>
> Sounds good. Here is a patch with an attempt at a NEWS entry:

The change looks pretty uncontroversial to me.  Is the variation
interesting, where NOCONFIRM is a predicate so that we can selectively
remove packages?

> Please let me know if any changes are needed.
>
>> 
>> Also, would it make sense to turn NOCONFIRM on if the command is
>> invoked with a prefix argument?
>
> Sure, that might make sense. If we do that, should we do the same in package-install-selected-packages? It uses its NOCONFIRM argument in a similar way.

We can do that in a subsequent patch.

-- 
	Philip Kaludercic on siskin





  reply	other threads:[~2024-10-26  7:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 15:58 bug#73932: [PATCH] Add noconfirm to 'package-autoremove' Sean Devlin
2024-10-21 16:35 ` Eli Zaretskii
2024-10-21 18:04   ` Sean Devlin
2024-10-26  7:31     ` Philip Kaludercic [this message]
2024-10-27  9:53       ` Stefan Kangas
2024-10-28 14:48         ` Sean Devlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iktfe2wr.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=73932@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=spd@toadstyle.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).