From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam James Newsgroups: gmane.emacs.bugs Subject: bug#74647: 31.0.50; Build failure on master w/ librsvg-2.58.5 Date: Mon, 02 Dec 2024 13:47:32 +0000 Organization: Gentoo Message-ID: <87iks219jf.fsf@gentoo.org> References: <87zfle1f6i.fsf@gentoo.org> <867c8i43iz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.7; emacs 31.0.50 Cc: 74647@debbugs.gnu.org, manuel@ledu-giraud.fr To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 02 14:48:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tI6nI-0009DE-F4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Dec 2024 14:48:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tI6n3-0007AY-1q; Mon, 02 Dec 2024 08:48:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI6mT-00076P-7u for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 08:48:07 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tI6mQ-0007FT-75 for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 08:48:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=lCXAY8xU+1d1S9WE7tJM6s5vvvwWFwtdsvM3M31hp1g=; b=YuqH7cUc24td2YiHKUnBf/36vpglSRAZ0HpClBzf8pxhewFDjBdK7chzPUP580kleVYBkzgLyBCVA26v0iuLy+i9XTcRvxBliWF5pSkDC/UTXqQVSboCuy1u/yS3HS8X0m9NJGeIBODNq5RrPzK52YvC5g+s+nng4nQVgBXmEfnUpdXF5q56wWcd9NwThpZf5PPMyC2sPsXwX8rVfQp7b4hbLXztOpA33XfHaR5bvVwWFWajJKFOyfS8TyJYCx+5eNqppZiKBXATVObVxsYRAofWyL5H9KW6Q7QfnBJAJE3JIyjQ0MXmNn158v3oSugcJJpSRRTRphJ6hqofhX1dnA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tI6mP-00011p-VP for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 08:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sam James Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2024 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74647 X-GNU-PR-Package: emacs Original-Received: via spool by 74647-submit@debbugs.gnu.org id=B74647.17331472643917 (code B ref 74647); Mon, 02 Dec 2024 13:48:01 +0000 Original-Received: (at 74647) by debbugs.gnu.org; 2 Dec 2024 13:47:44 +0000 Original-Received: from localhost ([127.0.0.1]:54747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI6m8-000117-4s for submit@debbugs.gnu.org; Mon, 02 Dec 2024 08:47:44 -0500 Original-Received: from woodpecker.gentoo.org ([140.211.166.183]:50944 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI6m6-00010p-3g for 74647@debbugs.gnu.org; Mon, 02 Dec 2024 08:47:42 -0500 In-Reply-To: <867c8i43iz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Dec 2024 15:29:08 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296321 Archived-At: Eli Zaretskii writes: >> Cc: Manuel Giraud >> From: Sam James >> Date: Mon, 02 Dec 2024 11:45:41 +0000 >>=20 >> I see the following build failure (with a clean bootstrap) with librsvg-= 2.58.5 on master: >> """ >> image.c: In function =E2=80=98svg_load_image=E2=80=99: >> image.c:12358:12: error: implicit declaration of function =E2=80=98rsvg_= handle_get_pixbuf_and_error=E2=80=99; did you mean =E2=80=98rsvg_handle_get= _pixbuf_sub=E2=80=99? [-Wimplicit-function-declaration] >> 12358 | pixbuf =3D rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err= ); >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> | rsvg_handle_get_pixbuf_sub >> image.c:12358:12: warning: nested extern declaration of =E2=80=98rsvg_ha= ndle_get_pixbuf_and_error=E2=80=99 [-Wnested-externs] >> image.c:12358:10: error: assignment to =E2=80=98GdkPixbuf *=E2=80=99 fro= m =E2=80=98int=E2=80=99 makes pointer from integer without a cast [-Wint-co= nversion] >> 12358 | pixbuf =3D rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err= ); >> | ^ >> make[2]: *** [Makefile:457: image.o] Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> """ >>=20 >> I've attached the full build.log. Let me know if you need more informati= on. > > Manuel, I guess the version guard needs some adjustment? Which > version of librsvg introduced rsvg_handle_get_pixbuf_and_error? It looks like it was introduced in https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/931, specifically commit 85cdba02a3e126c1099a62b3d6421ac0cb2d790b, which says "* Deprecated: 2.58.", but that commit doesn't appear in any release of 2.58, only >=3D2.58.90 (and so on) which are pre-releases of 2.59.