From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#1352: 23.0.60; isearch-success-function Date: Sat, 20 Dec 2008 23:45:10 +0200 Organization: JURTA Message-ID: <87hc4yttax.fsf@jurta.org> References: <005c01c9477b$6adb8290$0200a8c0@us.oracle.com> <87fxlrid7i.fsf@jurta.org> <000e01c9484d$cdc82f20$0200a8c0@us.oracle.com> Reply-To: Juri Linkov , 1352@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229811822 4844 80.91.229.12 (20 Dec 2008 22:23:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Dec 2008 22:23:42 +0000 (UTC) Cc: 1352@emacsbugs.donarmstrong.com To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 20 23:24:47 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LEAFY-000437-Do for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Dec 2008 23:24:44 +0100 Original-Received: from localhost ([127.0.0.1]:54110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LEAEL-0004ew-Mn for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Dec 2008 17:23:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LEAEG-0004eg-Ii for bug-gnu-emacs@gnu.org; Sat, 20 Dec 2008 17:23:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LEAEE-0004e6-3j for bug-gnu-emacs@gnu.org; Sat, 20 Dec 2008 17:23:23 -0500 Original-Received: from [199.232.76.173] (port=35752 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LEAED-0004e3-VE for bug-gnu-emacs@gnu.org; Sat, 20 Dec 2008 17:23:21 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:48464) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LEAED-0002Me-Aa for bug-gnu-emacs@gnu.org; Sat, 20 Dec 2008 17:23:21 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBKMNJCo026867; Sat, 20 Dec 2008 14:23:19 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBKM54M8022175; Sat, 20 Dec 2008 14:05:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 20 Dec 2008 22:05:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1352 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1352-submit@emacsbugs.donarmstrong.com id=B1352.122981035220029 (code B ref 1352); Sat, 20 Dec 2008 22:05:04 +0000 Original-Received: (at 1352) by emacsbugs.donarmstrong.com; 20 Dec 2008 21:59:12 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from relay03.kiev.sovam.com (relay03.kiev.sovam.com [62.64.120.201]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBKLx4AE020021 for <1352@emacsbugs.donarmstrong.com>; Sat, 20 Dec 2008 13:59:05 -0800 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1LE9qg-000Pz5-K1; Sat, 20 Dec 2008 23:59:02 +0200 In-Reply-To: <000e01c9484d$cdc82f20$0200a8c0@us.oracle.com> (Drew Adams's message of "Sun, 16 Nov 2008 16:45:34 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: 1e897a521fdb5eac39b1f944f187ca57 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 6392 [Dec 20 2008] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 20 Dec 2008 17:23:23 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23398 Archived-At: > Thanks, Juri. Looks better, to me anyway. > > Some details you might want to consider - Sorry for not responding to your last input after closing this bug. I've carefully read you message as I saw it, but found no more room for improvement. The final change was based on your original report and approved by Stefan. I think further trying to achieve the perfection will make this worse. In particular, your latest suggestions assume that Isearch is a library of functions with well-defined interfaces. This is only partially true. Rather it is an editor's feature with a set of subfeatures. So it would be more practical to use uniform function names that contain the same name prefix for all related functions and variables. This will help better recognizing the used subfeature in other features (like Dired and Info), helping mentally connect any related function names to it. In essence, what you suggest is using the prefix `isearch-visible' instead of the current `isearch-filter' in the predicate names. I see no preference for a property-based `visible' over an action-based `filter'. I think the word `visible' is more confusing since it can be misinterpreted as "visible to the user" instead of "visible to isearch". The existing name `isearch-range-invisible' has no such problem because it tests whether the search hit is visible to the user. So the name `isearch-filter-invisible' connects two features and names together: 1. visible - "visible to the user" 2. filter - "visible to isearch" -- Juri Linkov http://www.jurta.org/emacs/