From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Date: Tue, 18 Aug 2009 00:19:59 +0300 Organization: JURTA Message-ID: <87hbw6xhm4.fsf@mail.jurta.org> References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> <19081.46396.950562.917528@winooski.ccs.neu.edu> Reply-To: Juri Linkov , 4117@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250797763 26008 80.91.229.12 (20 Aug 2009 19:49:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Aug 2009 19:49:23 +0000 (UTC) Cc: 4117@emacsbugs.donarmstrong.com To: Eli Barzilay Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 20 21:49:13 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MeDdH-0002Ds-AX for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 21:49:11 +0200 Original-Received: from localhost ([127.0.0.1]:40222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeDdG-0003IP-Pm for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 15:49:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeDbp-0001xX-6R for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeDbj-0001qx-JB for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:40 -0400 Original-Received: from [199.232.76.173] (port=33859 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeDbj-0001qn-79 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:35 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46136) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeDbi-0002Sa-Kt for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:34 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7KJkpLR004437; Thu, 20 Aug 2009 12:47:30 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7KJc6KD002276; Thu, 20 Aug 2009 12:38:06 -0700 Resent-Date: Thu, 20 Aug 2009 12:38:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 20 Aug 2009 19:38:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4117 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4117-submit@emacsbugs.donarmstrong.com id=B4117.12505444995574 (code B ref 4117); Thu, 20 Aug 2009 19:38:05 +0000 Original-Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 21:28:19 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HLSG41005569 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 14:28:19 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.53.255.cable.starman.ee [82.131.53.255]) by mx2.starman.ee (Postfix) with ESMTP id DC5E03F407E; Tue, 18 Aug 2009 00:28:09 +0300 (EEST) In-Reply-To: <19081.46396.950562.917528@winooski.ccs.neu.edu> (Eli Barzilay's message of "Mon, 17 Aug 2009 15:53:32 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 20 Aug 2009 15:47:40 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30325 Archived-At: > Yes -- here's another case that suffers from the same problem: > `comint-dynamic-list-completions' reads one key (because it wants to > remove the completions window when space is used) -- so it reads one > key to test if it's space and uses `unread-command-events' otherwise. > So: run `shell', type one character and hit tab (needs to have several > files that start with it to pop the completions), then do some > shift-movements. This can be fixed using the argument `dont-downcase-last' of `read-key-sequence': Index: lisp/comint.el =================================================================== RCS file: /sources/emacs/emacs/lisp/comint.el,v retrieving revision 1.390 diff -u -r1.390 comint.el --- lisp/comint.el 23 Jun 2009 07:25:15 -0000 1.390 +++ lisp/comint.el 17 Aug 2009 21:19:29 -0000 @@ -3014,7 +3014,7 @@ (if (with-current-buffer (get-buffer "*Completions*") (set (make-local-variable 'comint-displayed-dynamic-completions) completions) - (setq key (read-key-sequence nil) + (setq key (read-key-sequence nil nil t) first (aref key 0)) (and (consp first) (consp (event-start first)) (eq (window-buffer (posn-window (event-start first))) -- Juri Linkov http://www.jurta.org/emacs/