From: Juri Linkov <juri@jurta.org>
To: Eli Barzilay <eli@barzilay.org>
Cc: 4117@emacsbugs.donarmstrong.com
Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift
Date: Tue, 18 Aug 2009 00:19:59 +0300 [thread overview]
Message-ID: <87hbw6xhm4.fsf@mail.jurta.org> (raw)
In-Reply-To: <19081.46396.950562.917528@winooski.ccs.neu.edu> (Eli Barzilay's message of "Mon, 17 Aug 2009 15:53:32 -0400")
> Yes -- here's another case that suffers from the same problem:
> `comint-dynamic-list-completions' reads one key (because it wants to
> remove the completions window when space is used) -- so it reads one
> key to test if it's space and uses `unread-command-events' otherwise.
> So: run `shell', type one character and hit tab (needs to have several
> files that start with it to pop the completions), then do some
> shift-movements.
This can be fixed using the argument `dont-downcase-last' of
`read-key-sequence':
Index: lisp/comint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/comint.el,v
retrieving revision 1.390
diff -u -r1.390 comint.el
--- lisp/comint.el 23 Jun 2009 07:25:15 -0000 1.390
+++ lisp/comint.el 17 Aug 2009 21:19:29 -0000
@@ -3014,7 +3014,7 @@
(if (with-current-buffer (get-buffer "*Completions*")
(set (make-local-variable 'comint-displayed-dynamic-completions)
completions)
- (setq key (read-key-sequence nil)
+ (setq key (read-key-sequence nil nil t)
first (aref key 0))
(and (consp first) (consp (event-start first))
(eq (window-buffer (posn-window (event-start first)))
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-08-17 21:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 10:48 bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Eli Barzilay
2009-08-12 20:54 ` Juri Linkov
2009-08-12 23:59 ` Eli Barzilay
2009-08-15 23:27 ` Juri Linkov
2009-08-16 0:00 ` Eli Barzilay
2009-08-17 0:47 ` Juri Linkov
2009-08-17 3:17 ` Eli Barzilay
2009-08-17 15:07 ` Stefan Monnier
2009-08-17 19:53 ` Eli Barzilay
2009-08-17 21:19 ` Juri Linkov [this message]
2009-08-17 21:18 ` Juri Linkov
2009-08-18 2:56 ` Stefan Monnier
2009-08-19 0:56 ` Juri Linkov
2009-08-19 3:27 ` Stefan Monnier
2016-06-18 3:53 ` Andrew Hyatt
[not found] ` <mailman.1719.1466222049.1216.bug-gnu-emacs@gnu.org>
2016-06-19 13:18 ` Alan Mackenzie
[not found] <<19073.19554.183166.905858@winooski.ccs.neu.edu>
[not found] ` <<20160619131846.68080.qmail@mail.muc.de>
2016-06-19 14:36 ` Drew Adams
2016-06-20 0:57 ` Andrew Hyatt
2016-06-20 3:50 ` Eli Barzilay
2016-06-23 3:23 ` Andrew Hyatt
2016-06-23 4:18 ` Eli Barzilay
2016-06-23 18:15 ` Andrew Hyatt
2016-07-07 17:23 ` Eli Barzilay
2016-07-09 12:38 ` Andrew Hyatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbw6xhm4.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=4117@emacsbugs.donarmstrong.com \
--cc=eli@barzilay.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).