From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#6223: isearch-yank-string should use isearch-process-string Date: Thu, 20 May 2010 03:16:01 +0300 Organization: JURTA Message-ID: <87hbm38m2m.fsf@mail.jurta.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1274315235 3374 80.91.229.12 (20 May 2010 00:27:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 20 May 2010 00:27:15 +0000 (UTC) Cc: 6223@debbugs.gnu.org To: Lennart Borgman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 20 02:27:13 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OEtbR-0000yA-Ql for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 May 2010 02:27:10 +0200 Original-Received: from localhost ([127.0.0.1]:57167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEtbR-0008Kh-3k for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 May 2010 20:27:09 -0400 Original-Received: from [140.186.70.92] (port=41777 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEtbH-0008Jq-JE for bug-gnu-emacs@gnu.org; Wed, 19 May 2010 20:27:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEtbG-00019J-6g for bug-gnu-emacs@gnu.org; Wed, 19 May 2010 20:26:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40992) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEtbG-00019E-3l for bug-gnu-emacs@gnu.org; Wed, 19 May 2010 20:26:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OEtRe-0007bm-4n; Wed, 19 May 2010 20:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2010 00:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6223-submit@debbugs.gnu.org id=B6223.127431461429236 (code B ref 6223); Thu, 20 May 2010 00:17:02 +0000 Original-Received: (at 6223) by debbugs.gnu.org; 20 May 2010 00:16:54 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEtRV-0007bV-MZ for submit@debbugs.gnu.org; Wed, 19 May 2010 20:16:53 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEtRT-0007bQ-HU for 6223@debbugs.gnu.org; Wed, 19 May 2010 20:16:52 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.95.74.cable.starman.ee [82.131.95.74]) by mx2.starman.ee (Postfix) with ESMTP id 72BBF3F4156; Thu, 20 May 2010 03:16:45 +0300 (EEST) In-Reply-To: (Lennart Borgman's message of "Thu, 20 May 2010 01:38:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 19 May 2010 20:17:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37062 Archived-At: > to be consistent IMO. Thanks for the suggestion. I see no problem with this change: === modified file 'lisp/isearch.el' --- lisp/isearch.el 2010-04-16 01:30:37 +0000 +++ lisp/isearch.el 2010-05-20 00:14:58 +0000 @@ -1476,14 +1476,10 @@ (defun isearch-yank-string (string) (eq 'not-yanks search-upper-case)) (setq string (downcase string))) (if isearch-regexp (setq string (regexp-quote string))) - (setq isearch-string (concat isearch-string string) - isearch-message - (concat isearch-message - (mapconcat 'isearch-text-char-description - string "")) - ;; Don't move cursor in reverse search. - isearch-yank-flag t) - (isearch-search-and-update)) + ;; Don't move cursor in reverse search. + (setq isearch-yank-flag t) + (isearch-process-search-string + string (mapconcat 'isearch-text-char-description string ""))) (defun isearch-yank-kill () "Pull string from kill ring into search string." -- Juri Linkov http://www.jurta.org/emacs/